Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp1462242rwb; Thu, 19 Jan 2023 10:57:42 -0800 (PST) X-Google-Smtp-Source: AMrXdXvVicFPhYu18jeg14BIq3orkVOztcRzOXmkqYd4Kv/Pp7nwQPNAodPUoZ9UHLlDa5hMVlDt X-Received: by 2002:a05:6a00:f07:b0:58d:a930:e230 with SMTP id cr7-20020a056a000f0700b0058da930e230mr12743130pfb.18.1674154662755; Thu, 19 Jan 2023 10:57:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674154662; cv=none; d=google.com; s=arc-20160816; b=RuZpn8lhYnR65iPh5xT6hEuWZim34qC4FUxNGwkOMWBqNe7UR+ltgmno3eiSfazjTO AvKqpdSfLlPZRCPzSqP7/ppLDWbjOSh9N57ff2keZ2nKTktuaMXUg+dZMyg6ummKEGTv F5wQvJy2Ir3xlbX0CWZRsUd6uI2DFLGtq3GUxvRuMkjMWUszIyrgsZxLRbw8D8aLFNxh aMOHhgEd+HMRZR1gXeTJs7nzkagw2oTgtUmWdoDa7LgbWD3zZZCuUKtG2XBS59hpmAsz a80CRkEuXBK5uZzUuAfWMK4yVK/uI2WFBYTvDB6pCzNLEmwx2psK+bvyj+GDnPyE0lWI Qg1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=sa8Oz+7EARYAtQ0WLnCqgtp/WsCMus/3I6/+CNJ1OPw=; b=McHFf66d/ZHoUMdfibpN0a8tJdlWnQM+UIyVV/X5zCgYp3WvpEuaHzPg+o8uLwHcuC LNQx7KGzlvLBU6ucNttRTlO1CR+52aYHtf4dJ1c17fYDMN2OZV+rfEPAbl7L/2yluRFT qyOmWEH7h71WIUTSVgX+4si3McPDD9iG21i+Z+4sGBLMtVDhsNKkRTqdNwW846csioaI OG6knKjBV0sQCzQLZzMZACj0pQo0WT24+PxElwYRgnf+XEuesmR84pNkZYBeFFaxulgI gGNJS0TxRQewqDhMdW3kGPNuOvUafaUCFFRDUTRGo3Y3N68WIdO5eVop7S6ybHo3Tfx4 74Ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=sPzq1KJu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k4-20020a056a00134400b005766cd2128dsi21240501pfu.269.2023.01.19.10.57.36; Thu, 19 Jan 2023 10:57:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=sPzq1KJu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230031AbjASSyH (ORCPT + 45 others); Thu, 19 Jan 2023 13:54:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbjASSyD (ORCPT ); Thu, 19 Jan 2023 13:54:03 -0500 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 128C637B52 for ; Thu, 19 Jan 2023 10:54:03 -0800 (PST) Received: by mail-il1-x12c.google.com with SMTP id i1so1631086ilu.8 for ; Thu, 19 Jan 2023 10:54:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sa8Oz+7EARYAtQ0WLnCqgtp/WsCMus/3I6/+CNJ1OPw=; b=sPzq1KJuKnyasXRpxYhl2vyV/bYi9yVZ56Vqego/VjuHdzz/5dWCi47UX2CUDpoDNC CcC5wYt/hUVVEpFkHtyZ89U3S4NTWky0LrDtrtiFDdFrjZELyHOpVBHxbNELtKnQ2iw4 nr1fs0E0gGKpdnwRST07vzvNPYUzWsF4Vi012BPK68GyqhQejq7mymG62LbNctNk1H5z ANiECjUYn3uY98+hJ+kIU7gfPJH2vu/HOgNnNuH23TbDVW4pbv+weD5qebAzq+j5ja3T n2GpBO55V9L6Il8+jeulDNzuo2GKi68Gu59deOK6KEDsKNVjB9594cAWwGeunxMF6FhC vCiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sa8Oz+7EARYAtQ0WLnCqgtp/WsCMus/3I6/+CNJ1OPw=; b=OlE5WtaG7/u3c+BwNK4KSZSBS3DQxZ/W1pFDrt8VadhS/HgygHFtapumEnrf+VTMzx PmOkWHvfM27WiFHN7yTaXo8w2dabFC8yAeKJDLWpIdB32qVVbebAqMteiuj4yzTsn19v cRcpsRp6uylboFvjxy1hD9zdZcMdjUuPZexxliwx5NPwkFqdaC2PlLR41L7GEMH2fhwy H7aANd89QL7ik70pWyT+Zxcl3pwCURA627UFj78ja37R5oMhYU0iQiQZLpjY6c0dOz9N MHKI4+E7D+f5WWXE0BK9dN82rCCljZBOBh1UfhWGh3gvj0hF0oUhoz3Sw6xNegPTlsRu qmqQ== X-Gm-Message-State: AFqh2krrZJ+DWivqPlqeFG9xIeBKhDUq9d7U6BZraK7k0NvL1r0SqF8/ xhCYXE7UdY15zAW9V/brudjOYA== X-Received: by 2002:a92:cda4:0:b0:30d:bf1a:b174 with SMTP id g4-20020a92cda4000000b0030dbf1ab174mr2555528ild.1.1674154442314; Thu, 19 Jan 2023 10:54:02 -0800 (PST) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id e36-20020a028627000000b003a7c2e97005sm763264jai.126.2023.01.19.10.54.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 10:54:01 -0800 (PST) Message-ID: Date: Thu, 19 Jan 2023 11:54:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH -next v3 0/3] blk-cgroup: make sure pd_free_fn() is called in order Content-Language: en-US To: Yu Kuai , tj@kernel.org, hch@lst.de, josef@toxicpanda.com Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com References: <20230119110350.2287325-1-yukuai1@huaweicloud.com> From: Jens Axboe In-Reply-To: <20230119110350.2287325-1-yukuai1@huaweicloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/19/23 4:03 AM, Yu Kuai wrote: > From: Yu Kuai > > Changes in v3: > - add ack tag from Tejun for patch 1,2 > - as suggested by Tejun, update commit message and comments in patch 3 > > The problem was found in iocost orignally([1]) that ioc can be freed in > ioc_pd_free(). And later we found that there are more problem in > iocost([2]). > > After some discussion, as suggested by Tejun([3]), we decide to fix the > problem that parent pd can be freed before child pd in cgroup layer > first. And the problem in [1] will be fixed later if this patchset is > applied. Doesn't apply against for-6.3/block (or linux-next or my for-next, for that matter). Can you resend a tested one against for-6.3/block? -- Jens Axboe