Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <423a29e2-886d-2c41-16d4-a8fca5537c2e@intel.com>
Date:   Thu, 19 Jan 2023 11:24:59 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [Intel-wired-lan] [PATCH] ice/ptp: fix the PTP worker retrying
 indefinitely if the link went down
Content-Language: en-US
To:     Daniel Vacek <neelx@redhat.com>
CC:     Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        "Kolacinski, Karol" <karol.kolacinski@intel.com>,
        Siddaraju <siddaraju.dh@intel.com>,
        "Michalik, Michal" <michal.michalik@intel.com>,
        <netdev@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>,
        <linux-kernel@vger.kernel.org>
References: <20230117181533.2350335-1-neelx@redhat.com>
 <2bdeb975-6d45-67bb-3017-f19df62fe7af@intel.com>
 <CACjP9X-hKf8g2UqitV8_G7WQW7u6Js5EsCNutsAMA4WD7YYSwA@mail.gmail.com>
 <42e74619-f2d0-1079-28b1-61e9e17ae953@intel.com>
 <CACjP9X8SHZAd_+HSLJCxYxSRQuRmq3r48id13r17n2ehrec2YQ@mail.gmail.com>
 <820cf397-a99e-44d4-cf9e-3ad6876e4d06@intel.com>
 <CACjP9X_v9AFVNRgz2a-qJce+ZqR0TzRzyd4gPFufESoRXmCdJQ@mail.gmail.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <CACjP9X_v9AFVNRgz2a-qJce+ZqR0TzRzyd4gPFufESoRXmCdJQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVpESVo5Tk55K2RNZDcvdnFBUVlZd1pIZ1h6TzY0V1k0MmhtemNFYlh6NWxa?=
 =?utf-8?B?b3FwWDViWlBIdC9ZWTQwVWxXOG95eGVtL2phZ1R6ZmFmT2xqOGtOQ0c0ZitS?=
 =?utf-8?B?VWRwVUErcm9JUzVGRVlmNXZLQ0o1bnl6dHNHVnpsSkUyOWV6NzV2dW9IQzBD?=
 =?utf-8?B?d2grSkRpUFhZR1FHQnZ2eEZaajJqbTJCcCtROUp3ajc0RjFKUVFLTUZ5Rkp5?=
 =?utf-8?B?eXdBZVdPb3RJUGdLTzJ1dFB6anJTbEtzR1FJaEcrc1Bxc0Z5bUV0M2JoVXRW?=
 =?utf-8?B?M2ZxWjhndGNkbGRLVVRZdkVBMEtoRnlpbmt3MVROMy9UbjIwcXlVM2c2bVB0?=
 =?utf-8?B?TjZWaENJR1lHeWVNSmVoZkNDMU84aExaZFpJMlh2UStzL3hhRjNkY01weGs1?=
 =?utf-8?B?U3FtUmJ5Q2FvRFc5c2hyUXhITENRVWF4VDM3RmNYZTUxeHFZUEZZUnhsWHM3?=
 =?utf-8?B?QUNKcE9zd0hXZ0l0akpuTG5LcjRycy9MYjlmd2J5VWRhOGF5L2ltUkh0ODcr?=
 =?utf-8?B?UzZWYTdqckhQb1d3ZTlMZk54ejArWnF4MVYrckZXa1NuQURTV05kZndWaGhy?=
 =?utf-8?B?dzJrWCs0S2UwMXN5RG9iblUvU0hYVThNODlOYnR0eTlzR3M3amRRdlJhZkJo?=
 =?utf-8?B?clc5b3hnYXVvZ0VYdFZZdGxLRFlzekRVNmE3eklOdkNPdVV2b293MVdoT2Na?=
 =?utf-8?B?SGR6ZXV6Ukd0TllFSXRlTmt2cEErdVRqdCt1UXBjb1Zqa2ZCUVNHRjVBdGdp?=
 =?utf-8?B?MjFYUXlXS1g4b09xcHA0N2JDQkRmc1h4d0hoTXJsYVkwK0p4ZXAwWjhsdnhP?=
 =?utf-8?B?S1ZBVVBIS2VvL1JTOUxHTXJIWnNRYmQzc1RNa3VrRmsxOGxpMkRQQUR0ODR5?=
 =?utf-8?B?TUNuVkd5VFljMlpzM2g1UTRTN1BreldMSVlmVHFjdGYvMms0NVh0UTNxZ3Ax?=
 =?utf-8?B?bmV3cFZ0M1FJdVM5cTl1QzMxZnVhVU00VGMrUmZzTElHdkdaRmNRaEgzVHd5?=
 =?utf-8?B?Nnk0M3lKQjAwTnV1ejgzSlJBeWFBd0wybjhPL012akI1U1drSHcrMVJ3UW5R?=
 =?utf-8?B?RldwRXFnTUxGV012TG8vT0dTNWFnSHNURXdzcDl1czNMdCtwSzV5ejk0MDFC?=
 =?utf-8?B?TjZURERWQU1WSVMrb1hmNDBpNk0yaVRtbnJFVnkxRE43R0RsWU5ocHR6Vm9Y?=
 =?utf-8?B?Y3ZENGpQNEkra0U1VGhSdXdzbk15S2NORXVob0dJdURZeWZ2bnY3TjlIbFcy?=
 =?utf-8?B?YVRIZEQrUlhlUzVBaVZCaFE5THg5MWM1L0ZYUE5Zb29wQ2FqSVJmNzFyK25L?=
 =?utf-8?B?WG9QS0VWZUpOWGQ1Q0FMZUxYNzVvOGhXOWlLQU5lTzVyMVFvS01LL3p2dHg2?=
 =?utf-8?B?N1JlRFJaaE54YVA0S2pVQVZVdW9KeTlWbENISCtURkxTWW1jSjdnOEZaTjJn?=
 =?utf-8?B?VzI1THdCOXZLc3RvRkNVMjE0WGhPV2dtREhTVXB2dmgxZkF3bzRMTU14V21p?=
 =?utf-8?B?Y0pUYWVDTUJQS0IvTW5EbXFEMkVLbEhpTXZubkZxaHNyZWtDOWJRVVJsYm14?=
 =?utf-8?B?cHVlcjZXcEUrNEh4VU80d3ZpZVNRdklpWS96dzdvZ3h0VXExSTQveFp1dDcz?=
 =?utf-8?B?c3J4ZWZDNnRwaSsyLzZOcDkzUzZ5MnZ0K2N0TVZ0Y09XOU5mY3pFNXFQbndV?=
 =?utf-8?B?b1dPNHVhQXZNenZaaUJOckk5cVhxRWVUVWU3c0IySkJINFBaN0RuelYvdUU1?=
 =?utf-8?B?TTR3WEQ2azJzY1pvOEtJQXhjZFBPVmIzMXRLRzdraHBOcHhPKzFwNGhaL1U1?=
 =?utf-8?B?MmJock1JUHk4dWpTcHJvYjhHZ1R0RjBDd0lTbjJtaERBa3JlUnZueldWREwy?=
 =?utf-8?B?MURZVFVlTHNVdzBsRktZcmZvNkxIOGk4eGZWZllIQlA1azdTVm9DWDJEVjYy?=
 =?utf-8?B?akh6VTFWMkNndk5DUVlrWEg1ZVRiME1EY1pjWHFXd2tTZTBRZDRIa1puT3hQ?=
 =?utf-8?B?U1ZCWDNuNGxidi9lUjRiSjgvTS9wOG1YYXVoQW5yck5yNWpsN3pxUFpqNGpY?=
 =?utf-8?B?ZVFTaisrSU9ETkw1dmpva3Y3Sy9ma3RZdmh0UnJlSWM1dGs2bG1IU3V4S01B?=
 =?utf-8?B?R1dvQTJhU1A5dGVKTlR6UlY1ejRTbnNwMzc1TnlqaTRxcmwvOWdlaFdwWkNB?=
 =?utf-8?B?Tmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fa04be6c-271f-4ec2-ea79-08dafa52dcc1
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 19:25:02.5879
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fic6CLutbGa30bkYzqcnTUIJQNLNmLuEq2C0SWKs1WfVKKo+SR7P9AYVXYGpDwJVx0aoDjNDNgBZwgki9AH4dLYX8rz4OXIG71RpiMdAnz0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7004
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/19/2023 1:38 AM, Daniel Vacek wrote:
> On Wed, Jan 18, 2023 at 11:22 PM Jacob Keller <jacob.e.keller@intel.com> wrote:
>> On 1/18/2023 2:11 PM, Daniel Vacek wrote:
>>> On Wed, Jan 18, 2023 at 9:59 PM Jacob Keller <jacob.e.keller@intel.com> wrote:
>>>> On 1/18/2023 7:14 AM, Daniel Vacek wrote:
>>>> 1) request tx timestamp
>>>> 2) timestamp occurs
>>>> 3) link goes down while processing
>>>
>>> I was thinking this is the case we got reported. But then again, I'm
>>> not really experienced in this field.
>>>
>>
>> I think it might be, or at least something similar to this.
>>
>> I think that can be fixed with the link check you added. I think we
>> actually have a copy of the current link status in the ice_ptp or
>> ice_ptp_tx structure which could be used instead of having to check back
>> to the other structure.
> 
> If you're talking about ptp_port->link_up that one is always false no
> matter the actual NIC link status. First I wanted to use it but
> checking all the 8 devices available in the dump data it just does not
> match the net_dev->state or the port_info->phy.link_info.link_info
> 
> crash> net_device.name,state 0xff48df6f0c553000
>   name = "ens1f1",
>   state = 0x7,    // DOWN
> crash> ice_port_info.phy.link_info.link_info 0xff48df6f05dca018
>   phy.link_info.link_info = 0xc0,    // DOWN
> crash> ice_ptp_port.port_num,link_up 0xff48df6f05dd44e0
>   port_num = 0x1
>   link_up = 0x0,    // False
> 
> crash> net_device.name,state 0xff48df6f25e3f000
>   name = "ens1f0",
>   state = 0x3,    // UP
> crash> ice_port_info.phy.link_info.link_info 0xff48df6f070a3018
>   phy.link_info.link_info = 0xe1,    // UP
> crash> ice_ptp_port.port_num,link_up 0xff48df6f063184e0
>   port_num = 0x0
>   link_up = 0x0,    // False
> 
> crash> ice_ptp_port.port_num,link_up 0xff48df6f25b844e0
>   port_num = 0x2
>   link_up = 0x0,    // False even this device is UP
> crash> ice_ptp_port.port_num,link_up 0xff48df6f140384e0
>   port_num = 0x3
>   link_up = 0x0,    // False even this device is UP
> crash> ice_ptp_port.port_num,link_up 0xff48df6f055044e0
>   port_num = 0x0
>   link_up = 0x0,    // False even this device is UP
> crash> ice_ptp_port.port_num,link_up 0xff48df6f251cc4e0
>   port_num = 0x1
>   link_up = 0x0,
> crash> ice_ptp_port.port_num,link_up 0xff48df6f33a9c4e0
>   port_num = 0x2
>   link_up = 0x0,
> crash> ice_ptp_port.port_num,link_up 0xff48df6f3bb7c4e0
>   port_num = 0x3
>   link_up = 0x0,
> 
> In other words, the ice_ptp_port.link_up is always false and cannot be
> used. That's why I had to fall back to
> hw->port_info->phy.link_info.link_info
> 

Hmm. We call ice_ptp_link_change in ice_link_event which is called from
ice_handle_link_event...

In ice_link_event, a local link_up field is set based on
phy_info->link_info.link_info & ICE_AQ_LINK_UP

What kernel are you testing on? Does it include 6b1ff5d39228 ("ice:
always call ice_ptp_link_change and make it void")?

Prior to this commit the field was only valid for E822 devices, but I
fixed that as it was used for other checks as well.

I am guessing that the Red Hat kernel you are using lacks several of
these clean ups and fixes.

For the current code in the net-next kernel I believe we can safely use
the ptp_port->link_up field.

Thanks,
Jake