Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <501c0e7e-fc18-9331-ea08-726af358b31a@intel.com>
Date:   Thu, 19 Jan 2023 10:28:26 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 3/9] fm10k: Remove redundant
 pci_enable_pcie_error_reporting()
Content-Language: en-US
To:     Bjorn Helgaas <helgaas@kernel.org>, <linux-pci@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Jesse Brandeburg" <jesse.brandeburg@intel.com>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>
References: <20230118234612.272916-1-helgaas@kernel.org>
 <20230118234612.272916-4-helgaas@kernel.org>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20230118234612.272916-4-helgaas@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3RWdFd6NVlqVU96N2I4bUp1SXNwSWt4VGJFenZZT3hlSldCVWw4VFJQekJn?=
 =?utf-8?B?aW9PaStaN2lRZVkwZWNkNFFrYmVvaDk0encvb2xVUG1GTE1jaGhkNzFhNVMz?=
 =?utf-8?B?aDZUdlp0S2xjOHFzYzJiYm5lSFc2QWk1MTFlWDZIYjgwWFJkeTdrQzZiS2pB?=
 =?utf-8?B?STJzSThSVUt0ZytVcGFLMzZiNFZuVkRMTzdzVDNBRk1mUWNnM1ZheEFlMkJa?=
 =?utf-8?B?dzhzMU5nK2VPQWZOZXdzbWJQdkg3anZnQ1VlN01GNDcwVElXaW9hRU0xRmdH?=
 =?utf-8?B?d1RIQW5ZemY0dDV0cm9TcHNYOW9BRjlBSzMwK3ZlMzIxNW1yQm0zV0pOWjNx?=
 =?utf-8?B?elBoVFVDM3hUeXA0STAvNzVzOG9SbUhCNFVyRW15Q3B1ZmloaUMzenhERnFO?=
 =?utf-8?B?b2lRbk1GK1hGampMZTZSUXd3OEFFYi9RZFhyYVkzL3RFdThjUlAxMlVrcHA4?=
 =?utf-8?B?bVgwNXcxcU1HS3BaeWR1aFNKQmxrVlJSY3U0K01reGV1NmhoK3prMGlUVThL?=
 =?utf-8?B?NngwbWNFMFdFK1dreUExRmZhc2hZUlhRdDcyRDcrSHhEK202Z3FMZTZabzhL?=
 =?utf-8?B?V3dqQlBGRUNmU0lrVWtKVlBvNXdFRjJLaVNlQ2kzT2ZnU05wUkt5TWo5dG5M?=
 =?utf-8?B?UFNOdDVhK3lLV3MxZ01ERHBvQlpaWmpXZmZqS1AveXJFQ2FXb0o1QmdBT1Nk?=
 =?utf-8?B?Q2I0UnRTYTgxeU04Y2xqSHE2OUVQd242bzRDUWtydVNKSEZzeHVYcHFDdzBT?=
 =?utf-8?B?TWNiRUhNbWF2QmlHZzE3ZldUaWs3eGF6UWswMjBraXJ5aVFVYjFyZHBuUUo4?=
 =?utf-8?B?aTF4WTA0dFFFZ1RweFlFVWFKZitTMWZPdVVsL3VYWGRSTitzOVl2aWNNTjQ5?=
 =?utf-8?B?WnlleFh3R3pkeVF2RjB6ZWVROVlsczFtSU9ka3BNT2NDZ0M2VDhSKzJZR2lk?=
 =?utf-8?B?QUJueElIRlJYQ1hRcmZ1QjZjaFJLaUxncFppOWxCNURNRi9sTFdMZXA1d3o2?=
 =?utf-8?B?S2tqR1VvcVh2eUdUWXM3QTJrdkIxaXN4YmNocFJMa2pXTURJMWlmNGxxTmIx?=
 =?utf-8?B?amJ1c0t3Uk9qNzlqSzZZbmNKa2IzWFA4YUFQU3F5ZnBkQ2VhQy9ibHdRVk9L?=
 =?utf-8?B?MU5LdTNjY1lmcVJvTXBvRjlldStqWU9xT094cHluU1MzQmtRSnJzdEdENjVz?=
 =?utf-8?B?MS9Ga1M5Y05qUCtRa1JVY2xvRE1OSHh5OTdXRXcrQXVBSFN2RmROTzAvMElz?=
 =?utf-8?B?UWJGZnJKZlQzRkh2allTbGxRTWhlWElOVkFqcXQwRmpmVzRndGNldVN1VGxX?=
 =?utf-8?B?cFlTVC91TWJlNlg1VFFkbjZVSE5FNVZPcW1IaitMTHlLUzJ1L094cEZkd2ow?=
 =?utf-8?B?UVZWVEJwWEJFd2xnekpybWRPTk12QjBVcHJlL0pZRDE4K2tIdTFqeDdnU2du?=
 =?utf-8?B?djFhTTNoV1VGZDFsMVB0bXJDQ0c1eDBJeTBHY2dxc3dyR1VnSGlNUzdhcUJG?=
 =?utf-8?B?bFh6a1J6V0tEdjN1QmlYaDhOUTJMMHJQK3I4cmUrZUdqY2M1RzhENVUzUHdh?=
 =?utf-8?B?bGFtKzFvTUZXeld3OENMZVh5NVlMY3JrdnQyZk94RVMwbmVwM0c5aWt0Q0N5?=
 =?utf-8?B?QWMrWTYrQmV5cmtkK1JPTDV5TEhJaXQ2VVdEVHNwSENMUW8va0pQWUltbWpG?=
 =?utf-8?B?SzN6MUtGa0hka0VQNUloV1N0UUNwNHhkMm1mMzUwWW5melpqQUJHdXU3ejh0?=
 =?utf-8?B?d3FaODE5aXdyMytEUW5oY1kzTUFxS25GS1FKK1Z6WnpzWGdWOGJOdjZaU3BW?=
 =?utf-8?B?UGk1QnBoOGRrczRDc2w4Y05qTmtCLy82OVdoN25ZMVp3cGIxSWN5cXNYOW9j?=
 =?utf-8?B?MDBaMDRkMm5XQmVKU0JUVElsNG42eGJ1eUVGZlFyYm9UVnFablY2M1lPM1JG?=
 =?utf-8?B?MEV2Tmp0RFNXS3hrZ0JJb2JsLzNnb1VRaXpSdVB5OFVVUkNZUWtQWjhreEVn?=
 =?utf-8?B?WmJnWWZyekRnNnJKTUE0UStSUm5aQ01NbENObHRVYy85WFpMOER5S21WTVNi?=
 =?utf-8?B?aFY2WndiVS9lanp4SEhiRUZKTXQwUEwwbXNnQS9zRVdZdDZEMy9aTkxubDh1?=
 =?utf-8?B?MjJiU3hHcjV1d05jU0JHb2MxaEp1N20zS0trOEtqREFxZ3I1b2VPaUU4eVpp?=
 =?utf-8?B?Wmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 57fd4b51-ab5b-4935-38af-08dafa4af63c
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 18:28:29.4824
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2xPSP82jhkGRJ3kcEPwsboWXU3yP0kq1seLMLxuqXEn81iMWX9J50W8QIP6GnGcyIcCcYwhWr9G+ZtrOphyuYUD85r6qS2172XUimbtB9ug=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7410
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/18/2023 3:46 PM, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration.
> 
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
> 
> Note that this doesn't control interrupt generation by the Root Port; that
> is controlled by the AER Root Error Command register, which is managed by
> the AER service driver.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org
> ---
>   drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 5 -----
>   1 file changed, 5 deletions(-)

Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>

> diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
> index b473cb7d7c57..027d721feb18 100644
> --- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
> +++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
> @@ -2127,8 +2127,6 @@ static int fm10k_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   		goto err_pci_reg;
>   	}
>   
> -	pci_enable_pcie_error_reporting(pdev);
> -
>   	pci_set_master(pdev);
>   	pci_save_state(pdev);
>   
> @@ -2227,7 +2225,6 @@ static int fm10k_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   err_ioremap:
>   	free_netdev(netdev);
>   err_alloc_netdev:
> -	pci_disable_pcie_error_reporting(pdev);
>   	pci_release_mem_regions(pdev);
>   err_pci_reg:
>   err_dma:
> @@ -2281,8 +2278,6 @@ static void fm10k_remove(struct pci_dev *pdev)
>   
>   	pci_release_mem_regions(pdev);
>   
> -	pci_disable_pcie_error_reporting(pdev);
> -
>   	pci_disable_device(pdev);
>   }
>