Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8756fac7-6107-57d3-c2fe-309dd8d3cf0a@intel.com>
Date:   Thu, 19 Jan 2023 13:02:10 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH net] net: fec: Use page_pool_put_full_page when freeing rx
 buffers
Content-Language: en-US
To:     <wei.fang@nxp.com>, <shenwei.wang@nxp.com>,
        <xiaoning.wang@nxp.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>
CC:     <linux-imx@nxp.com>, <linux-kernel@vger.kernel.org>
References: <20230119043747.943452-1-wei.fang@nxp.com>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20230119043747.943452-1-wei.fang@nxp.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnhQMFZnR0kzbEtZQzQyUk9SQjNkdWc1dmwvM21QMlNoSWNPUnV5dzYrVnJa?=
 =?utf-8?B?MjhiSUFMZk5CNkc1Y2N6YXlSYWRkRWR4RXhzSU1KMWZRTGIrTWk3OFZvMjNN?=
 =?utf-8?B?RldYY29uRFVjL0VPQ2RKZzVDSVZlY3Y0M3hJam5nbUFWL3ZFaXpZSWhLOGpo?=
 =?utf-8?B?R1hsb2x2aFNqR0pJY2c2RE9UcWZWemQ1aGd6ZkNzc3NsMjFjRmZpM0xBT0dX?=
 =?utf-8?B?YVZMQXlNQTYxcW5lOFBXTjZGOTdGbkZDNlZsSDdGMDlva3AyYnVJaHYwYnh6?=
 =?utf-8?B?c2U3RE9NL1dMaGRCY2ZpbW9nTnlMamIxMFBmcStxdkM0VlVZTC9wWDl5V1Ix?=
 =?utf-8?B?UXFUaVBkMjVsb0c1YkhrUTVKaEtnRWVRYmhFM05vYmdwRjdVNlp4RDZ2dHo5?=
 =?utf-8?B?a0h3L1hoeFdHM1ZZa0NkQ0hVelJTMktZUVZoRGRzU2ZCdkp1QUg5WTJkSm00?=
 =?utf-8?B?YzE4MkNuOEdzTEhKb1h4eG9qMEZ4Q3ZzbEZscC85MmwwaGVvdGpOWEpKcHl5?=
 =?utf-8?B?ZmdMSU9uR2luclBZWjE5TU42WHMrQitjbWdGTXp5aTNLM3E3cTROUk0reUEv?=
 =?utf-8?B?bTJqNS9mZjc5RkNRYzNVbGpmdzY0aDlpLzBsM0RUR2VNUlRiM3pLcUV4N0I2?=
 =?utf-8?B?UzlHL0JaTDRNcXhoRTl3b0hLTCtjelVjSWllSGJlNUJodW1XdVV1ZXdvN0tH?=
 =?utf-8?B?TEVsekt2dTA3ZVhjZk1zTjVJQWNBa25hWG5jVTRCQnB4UTFaaGpjU3ZGeGdX?=
 =?utf-8?B?Rm5VY1NLNWpZWFpNR3R1WkQxWVBGM0gwUEVtVWRZQWhEd2hYUWp4Q0thcXY5?=
 =?utf-8?B?eE1DTFBPZTBNenNhSy95c1FtVUNrUEJKUFdxZ2sxTFppMms5ajdnWC9BNlVq?=
 =?utf-8?B?SHJ6TlpZL1FFNE9ETHRHcTJZWmJEQlp6bWYvZ3M4TkdUaS9DSE9kYWV4bkpy?=
 =?utf-8?B?Z204WTJSMWxIalJFa1Eyb3pQUlRROHJLREFWMktMYnh3ZlJhS1doV2NOUkY3?=
 =?utf-8?B?VkVwMFlSVG82N2doRzdPLzYwU1ZvRDJ5KzNZMURLaWs2cXhDTGZjNjZoZ09W?=
 =?utf-8?B?Z0t1REhtVTFmUm8wcGZ6UVNaMlJrOGltcC9ZakNmQS9WRDBvRWtka01ORk44?=
 =?utf-8?B?RExLZlVxN2VGSjFXMFd4aVFjbEQ1aDFKQVZmcjVzUzJXOFhRSTZoQXVoYjVZ?=
 =?utf-8?B?TVNBR2VnVnF5ZFlsY01NSmFnd2hYd0Vnd3FRMC93aTh2Y0p6S0ZiRUtUNkJI?=
 =?utf-8?B?Z21uc0VTclErSkNmYlppa3UrVnNkT3dMQ2V6RGtCL0FxQlRoclZJcFR6SUp5?=
 =?utf-8?B?bHFQdGRKSDZVV0wzdGt2WUcyelNlMFFlN083N0JOaXN1cWt6Wm84b1ppaENG?=
 =?utf-8?B?TC9PUXB0ZDI1UytZZlROSGUwWkRaNlpmU0N4VVp4cCtlN2M4OVR0ZkZVU21E?=
 =?utf-8?B?SlV3ZlMrbTNhS2R1TXpCeElGS3E2ellwTk5jdVRIRFRlYktFWnN2V1lwWTZM?=
 =?utf-8?B?Z3p0S3EwWVpyQ3NVTVVmeVZKZkx3YithcXo1MFdVYW02NzVCdGxWQkcySG9F?=
 =?utf-8?B?K0tzaEpldWoyVEt4dzE0VGlaTU1WTEtyL0JrcmlvR2UwQ0NyY2hhMmh2c3Jr?=
 =?utf-8?B?WHFTazNoZ3hiYTRIY0pyVTVrZSt6dWR4TEdoSnFLZ2drK3ZvVEpienFOQnRu?=
 =?utf-8?B?ajZydGhoK1RqWjZ2N3czMTNIU0IvUFJwdk1FZWZQRHdDb3o4OS9YNUJYSFpq?=
 =?utf-8?B?QXJJN2xFV1llVzhHSG9CSjc3QnRyL3FwUTJ5MldxU3FQRVMrMmNaMzY4TDhT?=
 =?utf-8?B?Y3JGTElBd2diMzVkTGZ5L2FHWE5BSTNubFFUSmhXbTN0cGJGRStybWppdjhD?=
 =?utf-8?B?UVBURnVwODZud1I4T3JFcWZSRWdnTlBTNTJEVy8rS0dMZzZ0LzhQK3YrWmhF?=
 =?utf-8?B?VmErV2dhT3JZWURVZStreW5LZmZaRS8yekdkZmxETWpoRHhGWGROQ0swUEEz?=
 =?utf-8?B?TW94c0wwMjJzOXhrZUpEVTRoT2FSb2FqZ0luQytJamRCb09kSFRKOG9GN05i?=
 =?utf-8?B?RFpSVk92ZVJJVUJuampZVXRGa0Q2WmxpRk9HTVlUa3pEQ1pQMFhiNThRREo0?=
 =?utf-8?B?MDBjSlpMbUkyeFlIMklLNWloMW85b1lpQmdrTVBtSExMYlFnU3pOYXNPL0Yx?=
 =?utf-8?B?SlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e79fe0a-26b3-4a53-4340-08dafa606fc5
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 21:02:12.6755
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 51p77ZHhcfGC2oo1bpD2fohNNvyWrgYO+X79bn8zROBiw1ub/JPAHV/ZIUf6S08hQHqdku3KdoWbGw6kcfB+fotwxRDBVGkO9tJQ4Fvsomo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7824
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/18/2023 8:37 PM, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
> 
> The page_pool_release_page was used when freeing rx buffers, and this
> function just unmaps the page (if mapped) and does not recycle the page.
> So after hundreds of down/up the eth0, the system will out of memory.
> For more details, please refer to the following reproduce steps and
> bug logs. To solve this issue and refer to the doc of page pool, the
> page_pool_put_full_page should be used to replace page_pool_release_page.
> Because this API will try to recycle the page if the page refcnt equal to
> 1. After testing 20000 times, the issue can not be reproduced anymore
> (about testing 391 times the issue will occur on i.MX8MN-EVK before).

I had a look over other users in the kernel and it seems this bug hasn't 
propagated anywhere that I see.

Thanks, for the fix, seems good to me.

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>