Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp1691168rwb; Thu, 19 Jan 2023 14:12:00 -0800 (PST) X-Google-Smtp-Source: AMrXdXvBsldEf3wAUTHrbTAGC9pTkyVvv9Rehv4BT8HqVcp246FgKja408SGTqstZF6azJBX4Ynj X-Received: by 2002:a17:90a:a402:b0:229:5e73:78ec with SMTP id y2-20020a17090aa40200b002295e7378ecmr13775215pjp.34.1674166319870; Thu, 19 Jan 2023 14:11:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674166319; cv=none; d=google.com; s=arc-20160816; b=EsWTwYuyvdzoSVJq7Q+OwOk17oWZsKHy08CQcL0BeXzAaRPmW97YxM0wFD1TDFlTxQ QOgKaSOqiuP4IBN03ZSzswK14MEIqZYf6Jr5VFguR2XBb2W+SaqvHrAuE5Gh7pSQdZ7M lucgLY73RflgRxDUe8Ef5CZ+B5kVQ9aq3ipNWiXz6CRo2Ly9lbLHSZDKOzGJ074HVbOE Gz33Bf+Ap6qAyisWCSpWfwYnObLttRnYv72Dgn+9WaTNDdTrS170B1dAAW9idwBT0i5o vlIGSUXcBuYe0IUVk2ir1MRizLogx/41hoRXnvXYNdYl50rXckPgMMK9EyaxWNgAkt08 kDuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Eebpdj0zw8Q1TDZY/+4P3A5fyIa+LyO4/2oBMUD/V84=; b=saakUaLabpkRKHhfgl3vfzsQZTDU2yo2/4ynzNbgWZdnKTPq7p826Wlk22BbJtSRDN gWxm2lqY5nODhIqy881ElaWI9kPXO978f2cuTF4568tUAvU8dWiG/TFpHjILPwsEzjpj 6jxKk4+zOBoEHKohl43+cTplex++qnjrJBo3KzPGgEJXdsCjhHmgkldgDMJThHOlVKuH iUsacuMJs9Ctw0MovT8Ei/9SlmXcg0banVlHzwIFSAAlsQVQXAy2o7fQTwJrCUDawMsz brsTMtSy4GiX97eTrqjJrbLJU++nToZTA+9Jx9zNs2u5DKCjVnvWyihxU/Mo08tq+dpB u6iA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QuXpGV1g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kx14-20020a17090b228e00b00229bf39a1ecsi389941pjb.76.2023.01.19.14.11.53; Thu, 19 Jan 2023 14:11:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QuXpGV1g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230032AbjASWD1 (ORCPT + 48 others); Thu, 19 Jan 2023 17:03:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229623AbjASWC5 (ORCPT ); Thu, 19 Jan 2023 17:02:57 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3F014C2B; Thu, 19 Jan 2023 13:41:16 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5FEC661C1D; Thu, 19 Jan 2023 21:41:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB970C433EF; Thu, 19 Jan 2023 21:41:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674164475; bh=VhT//xdaFJPL+dSaI47Z5lILBjkKNuCbZfXeuUicLJY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QuXpGV1gFsGP6Vt1PI8UcWgi4x+iHPLQ2GhQyJCPCcS5NtMAJrcoTNG8bKnV+6XA7 VTY1lhJK5jZt7/WZbL4cgaQi2gxlb9bPcGTRK10xcDcekU+MlG8IBpB5/sscFoOWsC h9ga5iUbMBihFJcfj0QjKzIr3HV4GrwseDTJQVgX1DyurpLTL7mjVNVit+V5UW8NVw onL3FbbfEJ/tLmpebZGR4PUiwiDf2Er+2wv3LYQIF9wvbaAIkXt0qcGEOI0/aknnYr ozmT8Xw9BqNp8GADORcZ29uKlJmHx2Gn04kxdDRhkBdBxh1JGp/SZumQB8p0MdsknL FmnMSbBvaBI+Q== Date: Thu, 19 Jan 2023 21:41:10 +0000 From: Lee Jones To: Stephen Kitt Cc: Daniel Thompson , Jingoo Han , Sam Ravnborg , Helge Deller , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND 1/4] backlight: aat2870: Use backlight helper Message-ID: References: <20230106164856.1453819-2-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230106164856.1453819-2-steve@sk2.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 06 Jan 2023, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt > --- > drivers/video/backlight/aat2870_bl.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Applied, thanks -- Lee Jones [李琼斯]