Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fea0fa6e-c2c6-f904-4e9b-94f40fa443ea@denx.de>
Date:   Thu, 19 Jan 2023 22:49:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: linux-next: build failure after merge of the tty.current tree
To:     Stephen Rothwell <sfr@canb.auug.org.au>, Greg KH <greg@kroah.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Johan Hovold <johan@kernel.org>
References: <20230120075832.02bc1124@canb.auug.org.au>
Content-Language: en-US
From:   Marek Vasut <marex@denx.de>
In-Reply-To: <20230120075832.02bc1124@canb.auug.org.au>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/19/23 21:58, Stephen Rothwell wrote:
> Hi all,

Hi,

> After merging the tty.current tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/tty/serial/stm32-usart.c: In function 'stm32_usart_interrupt':
> drivers/tty/serial/stm32-usart.c:804:62: error: 'flags' undeclared (first use in this function)
>    804 |                 uart_unlock_and_check_sysrq_irqrestore(port, flags);
>        |                                                              ^~~~~
> drivers/tty/serial/stm32-usart.c:804:62: note: each undeclared identifier is reported only once for each function it appears in
> 
> Caused by commit
> 
>    f24771b62a83 ("serial: stm32: Merge hard IRQ and threaded IRQ handling into single IRQ handler")
> 
> I have used the tty.current tree from next-20230119 for today.

I already proposed a fix in the build robot report

[tty:tty-linus 4/7] drivers/tty/serial/stm32-usart.c:804:62: error: 
'flags' undeclared

Now waiting for Johan to confirm that's the correct approach.