Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp1719576rwb; Thu, 19 Jan 2023 14:39:11 -0800 (PST) X-Google-Smtp-Source: AMrXdXtOoIH5+Esil4jMGn/eFQUORDahUm6rIqTETEW+O7GsNlgUZXHYPILnGWNd+y6RWrP7GlKI X-Received: by 2002:a17:906:6d14:b0:7c1:765:9cfc with SMTP id m20-20020a1709066d1400b007c107659cfcmr27343586ejr.34.1674167951193; Thu, 19 Jan 2023 14:39:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674167951; cv=none; d=google.com; s=arc-20160816; b=o7CZhIvu26XEHu39xd1IF0t7Z45Ga8FKXvJRWXfEErEut4iIS8z/syiJ5DrwU5y6vf 1y78ueyIqsrbWySNRISSSCkadK7vFvjIof8Kh/Snn6vqsGufJQwLmn0dtB+na/ofKeQI dvjtxY77nWj9BG90Vxk0Yz1U4o3EvlLxlYefFH82Ug6LsVnCXGfvohwOCZNDEVhHnJCi 53QUHU9MXIJ23Dw1Vispn7VJZ2EsRbqvXChfCWDHyYnN6TWjLTfh87vhQ4kUCNNGYn/8 Gu1h90z84MilGJ31sI+hg+Fo08G36o/CAyEWMXRWivxdLooQmqDx1FSHBph6PgvU01Y8 I4JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=GSGRDQuPCB0Xs0HyJG43wHk9KBgo+gT4l/RTtq5fqbA=; b=UDlNzAumtj0/w0GCJIgFxSm/aaSwlsHXqTcs4Y3TeReuz/XzJviR6TTfela29DxyIS mdN4tM5bnWmYysCm6xx+hLmRmBfaYX+otzRVkph6wlrzdELCSXXz/7uDA82sI3FR4Rbq MWYuv5SgUg0gKesKnfDXMNff2wRs9dSMrh5i2VeM7H1Er71sfFpZ1syBbRT6KRyOwT/R qAui+jihRxP5RiYnsakcKTEM2Kqptv7MESdybG3Z52i694l07RspDTcjd9c03VxuF946 4wZcD0hiJvvTKu6tFeTUsA3zh1r0VLIY15V3MKMnF5bmDK/7cY+X1A9A++hp/3B6cWuW Y6jQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oM6m0WwB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gj13-20020a170906e10d00b0086fcc2f95cbsi12837557ejb.943.2023.01.19.14.38.59; Thu, 19 Jan 2023 14:39:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oM6m0WwB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229801AbjASWAp (ORCPT + 46 others); Thu, 19 Jan 2023 17:00:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230292AbjASWAB (ORCPT ); Thu, 19 Jan 2023 17:00:01 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59046C1302; Thu, 19 Jan 2023 13:38:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 64C316193C; Thu, 19 Jan 2023 21:38:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB3EEC433EF; Thu, 19 Jan 2023 21:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674164324; bh=FQJpoqxB6OaO61PvKyPRMDj1dmn+wD7csP9DHZDao1Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oM6m0WwBPsUWLaDpmDqxpqLwFwJQr0g2vnqyvRQ8PLnZvtZQshzk8GZa/qFTfOkc7 2Ed9CgwtStzfPTesAmGmg+1CrFAdEqcVXehS/NdoHWgWgOGlQO7moagoYDGdi6b+R6 EAyPCr352T35mGNsPlQivTjAHIgrGVAFgWikOupsxBd1eVIFe50nrhDfPtod11wrjd Rjwlx23za76bHDQoRt36xnIZZS4NlVWOBbF96B44b9we8dXbdKm0+gKEm2X6UTW4PI Zznzy3JnY6gR4JGCkCc8Z0Y7q2BaxnZnKuqaL7O19SFI1+xP59D3nmtSvoiLo7SpaT mOt7eHuRbtRqg== Date: Thu, 19 Jan 2023 21:38:39 +0000 From: Lee Jones To: Stephen Kitt Cc: Daniel Thompson , Jingoo Han , Sam Ravnborg , Helge Deller , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND 2/4] backlight: arcxcnn: Use backlight helper Message-ID: References: <20230106164856.1453819-3-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230106164856.1453819-3-steve@sk2.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 06 Jan 2023, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt > --- > drivers/video/backlight/arcxcnn_bl.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Applied, thanks -- Lee Jones [李琼斯]