Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765241AbXHXTbm (ORCPT ); Fri, 24 Aug 2007 15:31:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760691AbXHXTbb (ORCPT ); Fri, 24 Aug 2007 15:31:31 -0400 Received: from smtp3.hushmail.com ([65.39.178.135]:58681 "EHLO smtp3.hushmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760209AbXHXTba (ORCPT ); Fri, 24 Aug 2007 15:31:30 -0400 Date: Fri, 24 Aug 2007 15:31:21 -0400 To: , Cc: , Subject: Re: [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api Reply-to: postfail@hushmail.com From: "Scott Thompson" Content-type: text/plain; charset="UTF-8" Message-Id: <20070824193127.7E067C3825@mailserver10.hushmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1008 Lines: 32 On Fri, 24 Aug 2007 15:15:30 -0400 Alan Cox wrote: >ase, 0x80); >> >> remove also the hwbase var. >> >> > + rebase = pci_iomap(pdev, 0, 0x80); >> > t = readl(rebase + CNTRL_REG_OFFSET); > >Switch to ioread* if you are using the iomap interface. Its not a >trivial >conversion and its slower and bulkier - the original ioremap was >much >better > >NAK this change therefore Jiri had requested this in relation to previous patch on unchecked ioremap return codes, but if the original ioremap is better NAK is fine here and I won't resubmit w/ the hwbase var pulled out or the readl -> ioread32 switchover. --------------------------------------- Scott Thompson / postfail@hushmail.com --------------------------------------- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/