Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 19 Jan 2023 14:42:04 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     "zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Zhaoyang Huang <huangzhaoyang@gmail.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, ke.wang@unisoc.com,
        Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
Subject: Re: [PATCHv4 2/2] mm: use stack_depot_early_init for kmemleak
Message-Id: <20230119144204.a5a67be85544cd29cd656a5b@linux-foundation.org>
In-Reply-To: <6e9e406a-8a94-4e34-9e5e-f4bb3a321b4e@suse.cz>
References: <1674091345-14799-1-git-send-email-zhaoyang.huang@unisoc.com>
        <1674091345-14799-2-git-send-email-zhaoyang.huang@unisoc.com>
        <6e9e406a-8a94-4e34-9e5e-f4bb3a321b4e@suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 19 Jan 2023 11:32:36 +0100 Vlastimil Babka <vbabka@suse.cz> wrote:

> But to be cleaner I'd also suggest Andrew adds the hunk below. The call
> to stack_depot_init() becomes no-op after this patch so it's not a bug
> to leave it there, but it's just misleading now.
> 
> ---8<---
> diff --git a/mm/kmemleak.c b/mm/kmemleak.c
> index 91dda5c2753a..55dc8b8b0616 100644
> --- a/mm/kmemleak.c
> +++ b/mm/kmemleak.c
> @@ -2095,7 +2095,6 @@ void __init kmemleak_init(void)
>  	if (kmemleak_error)
>  		return;
>  
> -	stack_depot_init();
>  	jiffies_min_age = msecs_to_jiffies(MSECS_MIN_AGE);
>  	jiffies_scan_wait = msecs_to_jiffies(SECS_SCAN_WAIT * 1000);
>  

I added your signoff to this.

I used not to bother for such minor to-be-folded fixups, but now
Stephen sends me automated nags when his scripts detect this.