Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 19 Jan 2023 14:05:26 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
        LKML <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Stefan Talpalaru <stefantalpalaru@yahoo.com>,
        David Woodhouse <dwmw2@infradead.org>,
        "Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
        Jonathan Corbet <corbet@lwn.net>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Peter Zilstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>,
        Andrew Cooper <Andrew.Cooper3@citrix.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH v1 Part2 1/5] x86/microcode: Move late load warning to
 the same function that taints kernel
Message-ID: <Y8m+pr3t84VQTQTM@a4bf019067fa.jf.intel.com>
References: <20230113172920.113612-1-ashok.raj@intel.com>
 <20230113172920.113612-2-ashok.raj@intel.com>
 <875yd2i4b5.ffs@tglx>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <875yd2i4b5.ffs@tglx>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WpiPjZT4QgVMlZnpSw81l4+t0geGjrww+YprWEofToDOsnTZa0HdSFovU3a6?=
 =?us-ascii?Q?Dk3mOYiXAzsW36b/+C91+z7LyAPYM1KUg5pgqKAA2n9WbQdCpKA+lIkc/Zcz?=
 =?us-ascii?Q?rpZRj1OAdqknyyrYdDGyWxGDeHaCwH0B9/VTpYgPoqIJEstR7c8KNaUp92gr?=
 =?us-ascii?Q?AsWIiKqcrlTX98RNkJPpiwZFlz6SxW1FY9yBKHFHRQYTBmow3dCfhpGFmxth?=
 =?us-ascii?Q?4V7JJJvwhsuBLzMkShi8JYtYsamooPrFla0h/x3i1jx+P+z74J7ZqBUHR+YU?=
 =?us-ascii?Q?fwNfxdvp1kBglu8LbQkFBkau0f2rlmuNajEqYY+lB8KCarHkx9JAZZ9MYuJp?=
 =?us-ascii?Q?l4C0P0/GDZSeRQzZh63BZ9SXvXonU8ZVbmEda8x9zTBlhI64XJPJNP8VgVw5?=
 =?us-ascii?Q?PDlV8JClpgJpW0qGj6v1pDsCGaikqYw8mjYYHQYue5L9jGEpiffKp6CVpeJX?=
 =?us-ascii?Q?ziCzmB92JKxtsWMG4nfNwXnTzqlcwmpesmTv7DSI8YuQnHLcO9PCMCsGrioJ?=
 =?us-ascii?Q?xI+x+X8TBD+iwyNMFPUuHRSrwFig++8wd++2p1RDzK628drOwOYYueJwpkqd?=
 =?us-ascii?Q?LTLqY/U+8EwvOTBjrkvNzRrzMwj913Sq7J93zxmfKyQiI84r2CJHIc9+mHIm?=
 =?us-ascii?Q?Hpujy8BgK+poP6OFV2Cv52mcx1y0gOviXFCeFLS5+JhEWOqdibAI8E/Bk7CP?=
 =?us-ascii?Q?lbTqzMgS+ZGr4MyoDPrLu3kFy/DeKPIqS1VE/ZN+bGs7TopCdYhC3+RAX9DU?=
 =?us-ascii?Q?gdx0dVpvO8pY6KR5gP0WvMNx3Npy2iGq6v0ZqNJnn/et8FBo0VXjvfUuK4M5?=
 =?us-ascii?Q?PAZ+Px5OZ8avB0m0/ND4b4b9dfJe6urtIdSVNqsvaqCbVAMQpsPKuvgdOqax?=
 =?us-ascii?Q?qsLWRxlrsKLofqHp/aKcVDld/15gDPALy5U8t7LB/IbjOatFn8zC2efr+lLv?=
 =?us-ascii?Q?H21WmUTapcYhCsg18cJleVF5DSB/Ya4sKeT9gtk6hDUkKOpOKRbw+4c/Op/f?=
 =?us-ascii?Q?RlLRwd23j6CUu+caKguTatGiw6MWBN+q7x9JYjtgorH5nd7gHXDOBrhDrWgV?=
 =?us-ascii?Q?8K/6gKwka8XsHBtO+U1cXlQ0rZ6MPFjJIMHmOuEp1H9FIjcDtOE4sJxEvUhq?=
 =?us-ascii?Q?2+ivrTGIH/WytBzRKq/GmYh04C/4Se77hv/HjbtvhN6ZFv5FHV2GDwCNK3FY?=
 =?us-ascii?Q?yzR59XbZXgoIj5rmAQAEyNca5cX6ePuosHn3PpC9wumhfgnMd2qSl18BmBZ2?=
 =?us-ascii?Q?8B6c5ZL8G9dDNtqNeOv9KS9nFlvDj9hLHfJ6E8dysWsIa848p/3Il4Qwvlrf?=
 =?us-ascii?Q?eBon/rKzWy9KPhszwP6BVQe4Jy6sz0TUIilmgQPNhxH23aVBlDKsZLxYiDnC?=
 =?us-ascii?Q?LPjtPXAvJNi7QE8yEaGUNwHUhwPCnf8BKLFGCEz4q5+rsPQImwpeTttjMtlY?=
 =?us-ascii?Q?aEpbOKwOENe7Szo7jP6tTmG8r86XYIFVJs30f4bDDuwju0t+SB3+SCIgolA4?=
 =?us-ascii?Q?GmmNCSIQsz/18/9lTucS+4gFxAVyQPz7BHqknriMfylaIsgNLmhQHiYHHjdw?=
 =?us-ascii?Q?4Dk7Rsblh0ZROLlOpL0OmjDQU0Eb//yGsxCOnNnEhdVTqam9icALw836RYzH?=
 =?us-ascii?Q?oQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f993ed94-66f1-44e9-6678-08dafa694829
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 22:05:31.9122
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U5UPCKvTYke++KfPj5IadCrUgHMSY83MoPri6G5Q3tDbKTrXpoaEvPsRQ1XWHnq2fHLMjWM+s0bb81lh4c2pCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5583
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 19, 2023 at 10:48:30PM +0100, Thomas Gleixner wrote:
> On Fri, Jan 13 2023 at 09:29, Ashok Raj wrote:
> > Currently the warning about late loading and tainting are issued from two
> > different functions.
> >
> > Later patches will re-enable microcode late-loading.
> >
> > Having both messages in the same function helps issuing warnings only
> > when required.
> >
> > Move the warning from microcode_reload_late() -> reload_store() where the
> > kernel tainting also happens.
> >
> > No functional change.
> 
> I had to read this more than once to make sense of it. Let me try a
> translation:
> 
>   Late microcode loading issues a warning and taints the
>   kernel. Tainting the kernel and emitting the warning happens in two
>   different functions.
> 
>   The upcoming support for safe late loading under certain conditions
>   needs to prevent both the warning and the tainting when the safe
>   conditions are met. That would require to hand the result of the safe
>   condition check into the function which emits the warning.
> 
>   To avoid this awkward construct, move the warning into reload_store()
>   next to the taint() invocation as that is also the function which will
>   later contain the safe condition check.
> 
>   No functional change.
> 
> Did my decoder get that right?
> 

Yes, that is accurate.. inspite of my awkward phrasing :-(

I should copy this commit verbatim before i resend :-)

Cheers,
Ashok