Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 19 Jan 2023 15:44:25 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Peter Xu <peterx@redhat.com>
Cc:     James Houghton <jthoughton@google.com>,
        David Hildenbrand <david@redhat.com>,
        Muchun Song <songmuchun@bytedance.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Zach O'Keefe <zokeefe@google.com>,
        Manish Mishra <manish.mishra@nutanix.com>,
        Naoya Horiguchi <naoya.horiguchi@nec.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Yang Shi <shy828301@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 21/46] hugetlb: use struct hugetlb_pte for
 walk_hugetlb_range
Message-ID: <Y8nV2TvMK12yTPzE@monkey>
References: <Y8gRpEonhXgqfb41@x1n>
 <CADrL8HVGMTowH4trJhS+eM_EwZKoUgu7LmfwyTGyGRnNnwL3Zg@mail.gmail.com>
 <Y8hITxr/BBMuO6WX@monkey>
 <CADrL8HUggALQET-09Zw3BhFjZdw_G9+v6CU=qtGtK=KZ_DeAsw@mail.gmail.com>
 <Y8l+f2wNp2gAjvYg@monkey>
 <CADrL8HVdL_NMdNq2mEemNCfwkYBAWnbqwyjsAYdQ2fF0iz34Hw@mail.gmail.com>
 <Y8m9gJX4PNoIrpjE@monkey>
 <Y8nCyqLF71g88Idv@x1n>
 <CADrL8HXkdxDdixWRKNw6RFdbiBX-Cb1Lk7qxg6LdeNywbMOaOA@mail.gmail.com>
 <Y8nNHKW0sTnrq8hw@x1n>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y8nNHKW0sTnrq8hw@x1n>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9nlHK+sIAAYUsdEh/GfBZ3oM/oMnpLW9AMjj+OZ3Gl3sqS5eO79t1tZQMwf7?=
 =?us-ascii?Q?5d1YAZ0cwp49U95sYee1nJ2hPT7+BNOZ7ApkLwF8pOR4rd9TK+XAsvakv4i1?=
 =?us-ascii?Q?Vbk+CSyw7rn4pTjlozONQazwy2P4vVhpLdSwtHBrokwlDmHpJAypiM2sDSQ7?=
 =?us-ascii?Q?0yYS4L9tCUM5hqlCCKGcSM5uuKGL73R5+O/0PwFpx+aoNLSHj/15m7QfhTPA?=
 =?us-ascii?Q?nvS4YVILo58ctaZ9xRfLOwVzgE3LZCWMUgvJ1MJNQOGOJ7gtD7lt7bHZaxxC?=
 =?us-ascii?Q?NpxxvRPYbDDbIXMLhemC9Ibca5fEVNkImbeddOEPvnRsYeMJU8XfF2yPCc3q?=
 =?us-ascii?Q?UUtxMIuLhCRZepb/0BzySw4fDhqweVhVc4O8SXYjRWUr6WD9I8jvTQq41X3b?=
 =?us-ascii?Q?P/XXDwp/K62KUJK8DhUNY9mOmAu1Y2njO9k4CrHeBBUOL2Xwekof31MN2FOp?=
 =?us-ascii?Q?B2ugRTXvA5z6W33MxqaogecpIgbZ+GdDR0L3cshXxehywxUbJfnEMNIiGzzh?=
 =?us-ascii?Q?xUS0io6t+2OepOcOmKwyD4F7KbTucYZ6bBpu1YjE5pCcmPA9U2T8CZJ+GhWP?=
 =?us-ascii?Q?SPwjUmwhLzOEeYVYoiaQ14tQfLWPzwAMcZGMZVc+52Kz+a3pO6CWLllW//Zh?=
 =?us-ascii?Q?SQlmufnEty9PjL2SOwQ7XW7Ci/cJxC0f2xxKX7/fQweMghvEaFa/NnHtMvkW?=
 =?us-ascii?Q?hz2FzM4yKTq0EKVCCyQd//I9mrCcTSFG6viRFd5u2WbceOYr/Ic+G/it3nwB?=
 =?us-ascii?Q?yibtNSf7H8+5UUFRR1H80hm9+JEiBlfcjB9r3wxNyS9kkP1IClad74xXT5+T?=
 =?us-ascii?Q?9Qb50q7Sko995yT/+wKRYOWHE5W3W8u8JCGCYLDpkpRXjZ6SUNcZTlFucAp2?=
 =?us-ascii?Q?VCLqTOHYhA8Fcbs3UjRu63WYIi58HfH4TH/RmU3omkq1Fpnlhvevm8ZeV4YN?=
 =?us-ascii?Q?zqMB3rWTe3V/qDqsBdpN31buD7w2VPPOhj63BMqjkbz0pntda2tFBNEEWOy3?=
 =?us-ascii?Q?nnd+/7NygtW7Tzv/ZGdTq6uRfB7ckkHJESaQUbIYTftpm7l6YrGQeB2pkQ9T?=
 =?us-ascii?Q?bzP2nYOc9bvj75XkP42YA5Xn8sfOOQcyj7FCR4Tq34LOkU5whtIrmBm+G/4q?=
 =?us-ascii?Q?+5VwP3x5WXs0gKewSUU3BnRYj4lYmHL1hwgXMhTa6ZDHvqQHrE4NwwiNveyJ?=
 =?us-ascii?Q?N/0o5okvU/QVM/wEBE5DH1EpWxTkg5SpOwnAe6TvhmDySU5C14ybMrdwhdR4?=
 =?us-ascii?Q?r9E5GcGx1Zq08044Agw9Lze7z+5bk1RIBiU7D/HOvzL7FqHD6Hm4ti5L8nVU?=
 =?us-ascii?Q?h0ekrS9VV4XyVaimKafSUUJSvrpsEnxrzCXHCejRG6DAxb7wxqContGkw8u3?=
 =?us-ascii?Q?KshiVEVw9PRh6NiDWFCSOITSdcmmstRWNJJxVejln65cICmZRrs6Wpkqr32F?=
 =?us-ascii?Q?ozujWrDEouoKRayL/kJ4I0oo+u2NnYLG1sbcjMHiMZ/WofqdVpM5xrdrNLZI?=
 =?us-ascii?Q?qEN/ebf7F6V33Cm+3vrQiYCo01U2RtUgSaIRg/rkwJj00rwrVqCYAWxkPadp?=
 =?us-ascii?Q?KHzrvGyKZC2M/YAzhBnLnOwCiYMSteWZn8uere+4T+ldfWwiuZ3qROlEZ/MC?=
 =?us-ascii?Q?pg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?ldrJbPruBFwjegwmhTrNRPBzKAp3x9bC/yTRlBGmyOsPy1ebNCjScK72bN7H?=
 =?us-ascii?Q?07B+fIIm8nBiRmxgXGXzwim0BAnttjlHE5ya2LOu94rJEyr/sVIS3FxUjT3z?=
 =?us-ascii?Q?kqCvWmaWOuCKuwKy1BuTKYcoAqpjFaeWI0yPcVzPkN+mtUA/rNzAuA/4S3tF?=
 =?us-ascii?Q?vL5aGt056yCl7+1rpgVDp0llX5Z0Ff3Eam1FXYAZL2fuZ7yObu/y+dhGHbQv?=
 =?us-ascii?Q?l0KM9wi/g0NJO+O15F860nMPVyBz0u2InWJmpn8IzmY1+ISC7OKDFK8pJIZ9?=
 =?us-ascii?Q?MatVIfb0g3yRmJA1xsGOismA3MJ6OZpfn+Wui5GB2LRs6Hndzi6Wdml2G8iG?=
 =?us-ascii?Q?mHiXREcYlDwUHiPhHboqRVKlcM4rmnAeU2SNiTnovoGv4K/VfIeLqSmZQ2ov?=
 =?us-ascii?Q?cnkf9GukiiN7HEjEq3UMo4E8BK7MpD02bvkS5gRrdjS6yuydSPa2qWdKSV/z?=
 =?us-ascii?Q?3iYoVfTzg6w/05f8It23QRAM3OYKtyUO64W/pcpRWg2C0zd7n1oLS8CwxGPI?=
 =?us-ascii?Q?UOerrzQIDnhTdv7vwsRV7XLQsuIOj6hxztIaW/jCqAsz6cMhk1M4bF1uxhTK?=
 =?us-ascii?Q?LG1ib0ktiz3maZ53M2lF9DWih+oxtFZPU0zeokG/pD6kzEnndnVh0caFhGVp?=
 =?us-ascii?Q?NLRPYxXg8dfOtDNdSpMI17ErQlchIhBvlV3vu+GjSTFe8WZ2qWMRNUVp187e?=
 =?us-ascii?Q?OMVreOs2u2qqSR9GnZgHq2N4+l+YsW5krcpJAzvYEbuxlUlCMGbjmXx+XrRH?=
 =?us-ascii?Q?uR8fza8aB9yQ3F47riXDJB5B3jihHO/patsgbBqSUgXgJ/B6TpTPKKdz3fGr?=
 =?us-ascii?Q?agmBAiyjH46uRuXsAKytUNuQa43MTAwyp6iBpcjwxHUU8xdL/4BVl6YDwg93?=
 =?us-ascii?Q?SciNWAkcm9q+aUJAV7IShCWjlmNWf5eyGbDvO5NPgejZi5zyqUtJet7wU1iq?=
 =?us-ascii?Q?/mYJ9xEyPQpcPm9iJlnb70wmwVuJbZ8tZUvKuoAFGwqBenIy7x8U55DtYhqe?=
 =?us-ascii?Q?yZYhcDqDYK0mRQ5Ppc0qNQYRA0AUPYSQ0dZSbTp1DRp9aYb0Pt6unXRmaIcp?=
 =?us-ascii?Q?7YmszVbb5g71j3eAUN+bRGqVFC4TMu9Sn9vBAdmHHu6R1DcZBFhtQIzusVYc?=
 =?us-ascii?Q?CTjcpQoXnYOwbmOMkP1CFKPqiqMXCxIECg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3139502-bdd5-4fa7-f2b6-08dafa771acb
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 23:44:28.5690
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: envkgo1KYFn1di+imuB80ZOBJOt1IXocMcRH7XQezVmVMJjSdexmL9ElJBOVdvz9hreBlnMBUnhUxO2E3fD8JA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6621
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-19_15,2023-01-19_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 spamscore=0
 mlxlogscore=762 bulkscore=0 malwarescore=0 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2301190202
X-Proofpoint-GUID: xwve10mHDy_abZqlrIssgzqxSs0npH2W
X-Proofpoint-ORIG-GUID: xwve10mHDy_abZqlrIssgzqxSs0npH2W
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/19/23 18:07, Peter Xu wrote:
> 
> Actually when revisiting the locks I'm getting a bit confused on whether
> the vma lock is needed if pmd sharing is anyway forbidden for HGM.  I
> raised a question in the other patch of MADV_COLLAPSE, maybe they're
> related questions so we can keep it there.

I can quickly answer that.  Yes.  The vma lock is also being used for
fault/truncation synchronization.  Commit e700898fa075 make sure it is
even used on architectures that do not support PMD sharing.

I had come up with a rather ugly method of using the fault mutex for
fault/truncation synchronization, but using the vma lock was more
elegant.
-- 
Mike Kravetz