Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp1828012rwb; Thu, 19 Jan 2023 16:21:12 -0800 (PST) X-Google-Smtp-Source: AMrXdXsg93pa4iIfS0Euh1FRJBolcoDUwV/Fic94VDklpCENd08z2sI1aVWMmestXDnntmlJmZNF X-Received: by 2002:a05:6a20:3d09:b0:b8:6fe8:5ed7 with SMTP id y9-20020a056a203d0900b000b86fe85ed7mr17940946pzi.44.1674174072589; Thu, 19 Jan 2023 16:21:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674174072; cv=none; d=google.com; s=arc-20160816; b=n+jfJQczrr/CW1Jpr0Io3UqnU8p58FrkHckiJe4MgIAwHbvkM950uxNvRL9YEnflzW OG2yOVHZojk4BPuBRkfNBgvdrX/JKF4htUlY68FLn/6waIdZcz0dLOUc7BckJSglWsAt Pduuic8cuRDeCkax2jiqy44ORiV0WXTLl+YAvFkWw2BOj5j7uTfn+N5JxNbyjn1vweng MyuHioDgBUsR0p6XLURYTywek98UH/5zSZjFAVIbNiqLA949bui+p//1CEHMiu08HW3m dyfLqh9vcEN1JfD5AKYeD94O6fwP/tFP72ehiIHDmUP/KtT82HbhajwbLStFevGcUX4n bdaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=2RYDaQakvnKQMHYWcGZyFzWZGbJWcAlfnMO9tuHV3GY=; b=yjaDFNs8oH5Yl7vD9HqcCBcxPUCUJAayyl+YcQB2DNloUVRmBXWERHXKv1bsbVvEpN QWm5Zu+tnJ+ZrOOa78tVbomS034QDZgtofnq9DUyMyHBlUwvV6F4tOCGLJ6OwYrhSs0T mUrgwdQr12jojdOgSydIHf9yOrhZtbCMPCiEHN7vuL64/N0yw320cnAsfaTVSyah4S2N SlUCPVrF5blQAH3udSY2lZqPDhZUWp4NONdlsk60P3QKZ7oyvi0BfWtLy+ctVrTJSwmu Ql8TxrJMV8PdUT3CDezsC5MB3jAnWeGYHPu6sTGNMbAoPLul3VWWvj3TRby+vQ+6qG+x /NXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="epTqo8/G"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t186-20020a6381c3000000b004d07a5c5875si6849090pgd.572.2023.01.19.16.21.05; Thu, 19 Jan 2023 16:21:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="epTqo8/G"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231187AbjASXPa (ORCPT + 46 others); Thu, 19 Jan 2023 18:15:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230453AbjASXON (ORCPT ); Thu, 19 Jan 2023 18:14:13 -0500 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5347F93C6 for ; Thu, 19 Jan 2023 15:12:51 -0800 (PST) Received: by mail-pg1-x52e.google.com with SMTP id d10so2800785pgm.13 for ; Thu, 19 Jan 2023 15:12:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2RYDaQakvnKQMHYWcGZyFzWZGbJWcAlfnMO9tuHV3GY=; b=epTqo8/GH4R2BQ1E41zW0K2lvL4E85jVpNh1kazLjYlZomZHpWFKvEFc4KP/4voUKd oDhHR+qTm44ZJMscqbp0SfNGv8dpLTjJrGf6zc9u+k8MfUxoYkzAysCdAXkEfhNF6cvx Yusdvp/Sk+TielCZ2tVy0bscV2eA4K9apqu6MUQS/L9VxcZM8E/baAL3equmOEof5AQ4 saznbLELNR8lgHkg19njvaR0GnJTyBSF7VdEizP2eN9BDYX6R/hrdTgzNMstSSK+Lf4d V/yV6c4o9Bi6TZf5W4nbd+Ypxyd1T+J47XylPXDPYDy4kBBagHLd6Vc5ULBejQ4lDZQw rPcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2RYDaQakvnKQMHYWcGZyFzWZGbJWcAlfnMO9tuHV3GY=; b=XRS/fJI1oMBKZ13pHKrlyeJIfbbLFRYbcsCHNCDPIIN5F1ueb+JepT3THS6/2WkNAj aVfwmTmuiuwtEgxMMiTMbNSXLhkQqGtCT7PA9gxgmItdqeYuwOYYu2nP4UwStcVwbr7n SSvYd9E8wUghW4EHh2WbZCkrUhceAUAdUkNywVEnxOuK/J1ExsSYCi2/NRX8cy3W3z4G 8FZxsMPVT5jXBWmGCzHYn0WJwgq6+zIJKek444GnVAbEaiud9BlmnNa6Oy55uJ4Eq6Yn IvJ3Zy0UVKWqNRMKXbqBqEuNHsrLwIVmFRJ7oxc8H5CViNyAwjq0LOdgkaR7XPs94xIC ag5A== X-Gm-Message-State: AFqh2koZP8DiPBZPaBfk1BT0hEgqrtWArASiN5jb2rjzBomYh2Oz+3Zh OEpJYl7GX0EMMOA9jIzDSoLBaYXtAuk= X-Received: by 2002:a05:6a00:1d23:b0:58d:a91d:e9f8 with SMTP id a35-20020a056a001d2300b0058da91de9f8mr11154285pfx.18.1674169970704; Thu, 19 Jan 2023 15:12:50 -0800 (PST) Received: from localhost ([2a00:79e1:abd:4a00:2703:3c72:eb1a:cffd]) by smtp.gmail.com with ESMTPSA id z189-20020a6233c6000000b0058de3516c3esm4241259pfz.142.2023.01.19.15.12.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 15:12:50 -0800 (PST) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: Rob Clark , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , CK Hu , Mao Huang , Daniel Kurtz , Bibby Hsieh , YT Shen , linux-mediatek@lists.infradead.org (moderated list:DRM DRIVERS FOR MEDIATEK), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] drm/mediatek: Drop unbalanced obj unref Date: Thu, 19 Jan 2023 15:12:55 -0800 Message-Id: <20230119231255.2883365-1-robdclark@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rob Clark In the error path, mtk_drm_gem_object_mmap() is dropping an obj reference that it doesn't own. Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Signed-off-by: Rob Clark --- drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c index 9b3d15d3a983..f961c7c7456b 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c @@ -169,8 +169,6 @@ static int mtk_drm_gem_object_mmap(struct drm_gem_object *obj, ret = dma_mmap_attrs(priv->dma_dev, vma, mtk_gem->cookie, mtk_gem->dma_addr, obj->size, mtk_gem->dma_attrs); - if (ret) - drm_gem_vm_close(vma); return ret; } -- 2.38.1