Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 20 Jan 2023 11:03:45 +0800
From:   Xu Yilun <yilun.xu@intel.com>
To:     Russ Weight <russell.h.weight@intel.com>
Cc:     Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        linux-fpga@vger.kernel.org, Wu Hao <hao.wu@intel.com>,
        Tom Rix <trix@redhat.com>, Moritz Fischer <mdf@kernel.org>,
        Lee Jones <lee@kernel.org>,
        Matthew Gerlach <matthew.gerlach@linux.intel.com>,
        Tianfei zhang <tianfei.zhang@intel.com>,
        Mark Brown <broonie@kernel.org>,
        Marco Pagani <marpagan@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 01/11] mfd: intel-m10-bmc: Add missing includes to
 header
Message-ID: <Y8oEka2u3TSNiWtw@yilunxu-OptiPlex-7050>
References: <20230116100845.6153-1-ilpo.jarvinen@linux.intel.com>
 <20230116100845.6153-2-ilpo.jarvinen@linux.intel.com>
 <1afecb9c-b17c-d2a5-d887-b7dced939586@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1afecb9c-b17c-d2a5-d887-b7dced939586@intel.com>
Precedence: bulk

On 2023-01-17 at 08:43:03 -0800, Russ Weight wrote:
> 
> 
> On 1/16/23 02:08, Ilpo J?rvinen wrote:
> > linux/mfd/intel-m10-bmc.h is using:
> > 	- pr_err(), thus include also linux/dev_printk.h
> > 	- FIELD_GET(), this include also linux/bitfield.h
> > 	- GENMASK(), thus include also linux/bits.h
> 
> Reviewed-by: Russ Weight <russell.h.weight@intel.com>

Reviewed-by: Xu Yilun <yilun.xu@intel.com>

> 
> > Signed-off-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>
> > ---
> >  include/linux/mfd/intel-m10-bmc.h | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/include/linux/mfd/intel-m10-bmc.h b/include/linux/mfd/intel-m10-bmc.h
> > index f0044b14136e..0d4db5d9d5af 100644
> > --- a/include/linux/mfd/intel-m10-bmc.h
> > +++ b/include/linux/mfd/intel-m10-bmc.h
> > @@ -7,6 +7,9 @@
> >  #ifndef __MFD_INTEL_M10_BMC_H
> >  #define __MFD_INTEL_M10_BMC_H
> >  
> > +#include <linux/bitfield.h>
> > +#include <linux/bits.h>
> > +#include <linux/dev_printk.h>
> >  #include <linux/regmap.h>
> >  
> >  #define M10BMC_LEGACY_BUILD_VER		0x300468
>