Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 19 Jan 2023 22:29:05 -0600
From:   Bjorn Andersson <andersson@kernel.org>
To:     Rob Herring <robh@kernel.org>
Cc:     Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: pinctrl: qcom,pmic-mpp: Restrict 'mpp'
 child node name pattern
Message-ID: <20230120042905.d2pdrzyv3e3airdj@builder.lan>
References: <20230120020600.3232001-1-robh@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230120020600.3232001-1-robh@kernel.org>
Precedence: bulk

On Thu, Jan 19, 2023 at 08:06:00PM -0600, Rob Herring wrote:
> Just 'mpp' is a bit ambiguous for a pattern. It allows any prefix or
> suffix. I couldn't find any actual users, so update the pattern to match
> the example.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> index 72cce38bc1ce..891a7385d7cb 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> @@ -74,7 +74,7 @@ patternProperties:
>      oneOf:
>        - $ref: "#/$defs/qcom-pmic-mpp-state"
>        - patternProperties:
> -          "mpp":
> +          "-mpp$":

How about aligning it with the other Qualcomm pinctrl bindings and make
it "-pins$" instead?

If my grep is correct we have one "mpp5" and two "-pins$" currently in
the sources, so this should be beneficial as well.

Regards,
Bjorn

>              $ref: "#/$defs/qcom-pmic-mpp-state"
>          additionalProperties: false
>  
> -- 
> 2.39.0
>