Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp2081545rwb; Thu, 19 Jan 2023 20:45:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXv4Td+UlaAN6O6zIXwf4LTgjLO9APaBMtVDVT2/1LJZI/FBIjFV7GGKsu8tJk8Xn5HhU1gq X-Received: by 2002:a05:6402:27cf:b0:488:e7ae:5cc4 with SMTP id c15-20020a05640227cf00b00488e7ae5cc4mr17563933ede.41.1674189914349; Thu, 19 Jan 2023 20:45:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674189914; cv=none; d=google.com; s=arc-20160816; b=wLYWfUhK30UmOR35mQWG0NBgotRblSiHpRCx4Kk37lgBWmIUxoyqvhM1A/V+s1nElw HyjBnmIfV3ZTdYCURNnjyiEYpVM1scqpq9DDN3wxml+4gBx6Mhlpbt/AGWoqfmgvgPwo rR3wKQqtyz4ivAAEVn6zQNOR2qmjzCpdl61av/6e1MQiVBa+f0RLSNBZV5hSikpJ300F Q5uTjfqbF9dUIr3/QfLnlB2Dsc8IlpAZ0zeZltCIKDxH0vmIZbtkEI48kJiyWLZDwHHN h8sioMSWOr4CoZbm/wbIJZ8zdh0WLEkNjzDcg6MTMJV0WUmpnTmwaH449aq+0Cmq2RUe Fypg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=2lIUwszs20vP8ZqwnhMcV/6lWMoLi/u8ghdqcD9n4/M=; b=LPMoZfixbSLPl5zDJOqe2OOPCUWvS4PB2SVazalQEi89J0MmMDFBRzWczJwXB6UxCe LAgXpeY2mcTSO76VQAjT/77CwY12vjeUvUssrwdYGPxFOm8soDVNV6coyJWuB7r8219W P8z07w+COKEy7VRCodhXut7LTrs0hc53PLnY4rjr3Ds3b4pu3bkd37aRLsnlCu31WN6N soJQvAZeDfJV1WbJI8p4baaMQupgM1bebu4WdLqGi4BHg0p0/cTkrD8QiB98fjho57+d ixKCxiU+KVvZwJ3QqSPOms3dmpxvqdALP55f4YkJdS2pSXX3mFYS2/ardjJ4K02HFDYG kpFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Fd6a2F+2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k26-20020aa7d8da000000b0048bed17d7d9si37828505eds.8.2023.01.19.20.45.01; Thu, 19 Jan 2023 20:45:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Fd6a2F+2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230050AbjATE2y (ORCPT + 47 others); Thu, 19 Jan 2023 23:28:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229790AbjATE2a (ORCPT ); Thu, 19 Jan 2023 23:28:30 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEBF1B1ECC; Thu, 19 Jan 2023 20:28:25 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 07FB5B82812; Fri, 20 Jan 2023 03:52:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F006C433D2; Fri, 20 Jan 2023 03:52:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674186732; bh=MC1ENP+CPVPn+1arFstG4AqmfHtgPeKoFZHEIfXNfBc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Fd6a2F+2dwaIRbyZ2hydGSBCCfBkRYByrCSBY4+EWztnRHHwawx5KTdS9x2PwHL3/ NRymhnOUZeo95z8cq8S0FnVhQhBr/AOX5rS0GGcDrmcob7gwLmumYWLXwzLcoiyPS1 7tNQfDLyCtoro9Heom9UiKuU4fLKcKi+7/UtUhGCgGxOuL1P/hn+3nSDutccPvkSnZ tcgvgwTvANSMbUjYJfr/v1mXLwJ8CS8oxBaadiXrTU/yH1nLumjzd4fC8HUryzERBQ KQ5TfbnuVnrLLwll/BFT7+61sjIp1StTV8o4CG5co/UmYGgFF1it6BJhPIKrghBKf/ CBqQl39GhMSqQ== Date: Thu, 19 Jan 2023 19:52:10 -0800 From: Jakub Kicinski To: Yanchao Yang Cc: Loic Poulain , Sergey Ryazanov , Johannes Berg , "David S . Miller" , Eric Dumazet , Paolo Abeni , netdev ML , kernel ML , Intel experts , Chetan , MTK ML , Liang Lu , Haijun Liu , Hua Yang , Ting Wang , Felix Chen , Mingliang Xu , Min Dong , Aiden Wang , Guohao Zhang , Chris Feng , Lambert Wang , Mingchuang Qiao , Xiayu Zhang , Haozhe Chang Subject: Re: [PATCH net-next v2 08/12] net: wwan: tmi: Add data plane transaction layer Message-ID: <20230119195210.03537a93@kernel.org> In-Reply-To: <20230118113859.175836-9-yanchao.yang@mediatek.com> References: <20230118113859.175836-1-yanchao.yang@mediatek.com> <20230118113859.175836-9-yanchao.yang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Jan 2023 19:38:55 +0800 Yanchao Yang wrote: > drivers/net/wwan/mediatek/mtk_dpmaif.c | 4005 ++++++++++++++++++++ clang detects out-of-bound memcpy/strcpy or such somewhere in this file. Please fix that. Please try to make the series smaller than 17,770 :/ Strip stuff down to minimal working version. I don't think anyone can review 17kLoC in one sitting :/