Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp2082484rwb; Thu, 19 Jan 2023 20:46:16 -0800 (PST) X-Google-Smtp-Source: AMrXdXsvKm0UDzo+WcQ8hqAn4MjxDS2sFtIu7Tnw76X742oeeHIsjvULuSqmXAeLv3ROGLSJH2Cc X-Received: by 2002:a17:906:4694:b0:86d:c1b2:257b with SMTP id a20-20020a170906469400b0086dc1b2257bmr24289223ejr.19.1674189976003; Thu, 19 Jan 2023 20:46:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674189975; cv=none; d=google.com; s=arc-20160816; b=HzNtkZ/2RilaCBvOD3SPapszR/wbFcnbZH9bEZkF9/VZnxDbCKJCSEEIKNw18KdfeK k1OzM7HWuZnTbFbTGyzVX819TnejC29UzWvFBpbgq9ApbjG+ncxZgLgNHeDSD6YImYux dyRKgpcAqJDOh9xibtRhCLG10c8adLr5gdDFue5ABGtlZ6hGgt6D5el4m6Nm3bWpNnsa H8cNhHzT6LEs5/KMoFRAeVztKCUzO62C861L1LuxRzdDrJX0BGYO9G9q5aWM6XWNMISb fLSV9/DU7hSjbSQRmlZdVz7Uy8AoQA5bIZcWrR/W5nRAFyEexOWlA9wj1djvMh1LLoL3 NqZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=eOaj5ya8NeJSoNv1ZVdr5PfSsgkKED2aWCxjWInzZHk=; b=JLtq+5tw96BKoJBwS67FRd1o8QIYM1/4jYX69B/Sv1VR94NVEOAlJo6ZMX72QivYsf v/Lx+2RZzuI7y4F2SEGMtsGEMw0jlU455LrUesVvb/bfQ3ctFtljUa9Ygy7S/EzlE+NK dEt+95xrBkkVvp4DwWXlGjySuPvT+WdZHzUOZeAgst08sbRa4TPm4syqIJWeOlWv0Ecq mSD3IcGjfqDdhTTnPYe2hdWm3P3GR1kGNDtfx9EZXVKam/hXHdqbEBi1EWc4XKWRI+ti pwz3pRDOZ1tpD1+vA3dT70jxEmrOHIX052D9gzo4LSoe7X57D1219LM4r9WHv85Jbybb Typw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=Ri97XIO7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c26-20020aa7c99a000000b0048e82d753a3si10427498edt.227.2023.01.19.20.46.04; Thu, 19 Jan 2023 20:46:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=Ri97XIO7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229847AbjATEVN (ORCPT + 47 others); Thu, 19 Jan 2023 23:21:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjATEVL (ORCPT ); Thu, 19 Jan 2023 23:21:11 -0500 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F49418AB0; Thu, 19 Jan 2023 20:21:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eOaj5ya8NeJSoNv1ZVdr5PfSsgkKED2aWCxjWInzZHk=; b=Ri97XIO7jGbXUKdK86NYY6bzV2 p56yOo7FjVWv6UAAIcirwrWKl+miSaO0HK5pW0ESmsHrAFqfdYUr21C7uGTvFAyACgPx/ZlNONWOt e1YzUBVxa/EEjOjytse5LrejWX91zK2GCBBX/WNwq8dAK881c/SZjDvpY2OGbqtEjex6CNZT/lij3 0OZ59RRMAHjBAoiZzuC18t1mbL0W3afXsBYRVlrOnqh8mmkEOb8ASzhXYHs9tjN4atGIfQFWY02dN 9apf6pkLqXPSbFhDgXrY70uMR9pjvNhIddKqOpTjxNwuA1xZu7xW/lsVXqH9dvbUhxq4jDQo1eKn0 c46ZIuVA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1pIitm-002vFI-2i; Fri, 20 Jan 2023 04:21:06 +0000 Date: Fri, 20 Jan 2023 04:21:06 +0000 From: Al Viro To: "Fabio M. De Francesco" Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Ira Weiny Subject: Re: [PATCH v3 4/4] fs/sysv: Replace kmap() with kmap_local_page() Message-ID: References: <20230119153232.29750-1-fmdefrancesco@gmail.com> <20230119153232.29750-5-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230119153232.29750-5-fmdefrancesco@gmail.com> Sender: Al Viro X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 19, 2023 at 04:32:32PM +0100, Fabio M. De Francesco wrote: > -inline void dir_put_page(struct page *page) > +inline void dir_put_page(struct page *page, void *page_addr) > { > - kunmap(page); > + kunmap_local(page_addr); ... and that needed to be fixed - at some point "round down to beginning of page" got lost in rebasing...