Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c7eb0b28-4b55-f1f5-7338-dfc96015db89@intel.com>
Date:   Thu, 19 Jan 2023 10:28:42 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 5/9] iavf: Remove redundant
 pci_enable_pcie_error_reporting()
Content-Language: en-US
To:     Bjorn Helgaas <helgaas@kernel.org>, <linux-pci@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>
References: <20230118234612.272916-1-helgaas@kernel.org>
 <20230118234612.272916-6-helgaas@kernel.org>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20230118234612.272916-6-helgaas@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1A1NytsZXRLcVJpZ3JwVGQ4eUxZMkQzbllJWTNhT1o4UlNENTUvSzR6M3pC?=
 =?utf-8?B?TUVPS0JkeVMrN2Erc1YyMVJER2taKytiODVJOTFiMnJUSUVmNm5rNnZuUEhT?=
 =?utf-8?B?RGR0d1FwSDMxTktZbzhRVVFabSthMlUrVlpZWnJMdTZrN2JDQU9zTkxUV095?=
 =?utf-8?B?ZlpmWDhPZnB2emcybjFIVFVxU01jeFlqZjVNaTBQai8yOU1melc2dXB4NWlU?=
 =?utf-8?B?aW5wUTVXY2gwUTNIeldiSFJrSHhjbUZpSDhWQWFSMUxISUJrUW5jVlVpMW1F?=
 =?utf-8?B?K3NYemNZbFRzc2g0djZKdVVtczFTcWd4cTVJZXA5NkdRQmlBdjJkeWE2blNt?=
 =?utf-8?B?YTRuWmtyVUJ6YmV6S0ozcjErNG56VEFZTW5YWjNNTk01ZDdxRnRWMDdRTm9x?=
 =?utf-8?B?ejcrQ3BRdzZ2OXdKNjAyd1pKNisvbmFvVjZiUVZvVEFqVkcvc25sVzdDb2Vl?=
 =?utf-8?B?YUtqUy9BdkRiaWxKRXRGbjcrcjFUM3FEZTJCOGdyYThPc0Rsbmw5Sko1Uktl?=
 =?utf-8?B?cVhrOWg3OThsaHJrblA4NkZNMWl1NWpmZE02OEMwZVc0YjJjTm5KQmErMUdW?=
 =?utf-8?B?bStWVi9HbU4xcm1hMzBla3J6dWJ1cnZlUEN2aUU3UURsSEg1enkwMmNHdG5m?=
 =?utf-8?B?cVdqNEM5OE1rcDF1akE1VFBNYkxyT0pDRHFYOFlDdFhqbnFxWTh5SkpMRmQ2?=
 =?utf-8?B?TGdGYTd4ckI0eUpIYys3MGY4UDJ5WWxxMHZGVmhBTlR0RnJJU056VHJQZUJL?=
 =?utf-8?B?dUVSek4zZllzbFI1QUF6dVBXM1pBL1ZBcndVREpEYlg5Z3lDRm8vNUxLdndN?=
 =?utf-8?B?OVNXN2VvcjJNdksxcHJYaGgyOWQ2YXRBdGJuSmhSVXBxWjRaMjRwUnI0cmNO?=
 =?utf-8?B?VFZlYmg2ZG8yRmFkZ2dRZlBnV0VWVXVRaHNYWjl0aklLWis4aStwZ1dLMFBp?=
 =?utf-8?B?R3AyUUFLVE9OUFlJNFA3MGs3ZE9hc0xzOHJyZ25UZGtYWldkZnRKRUJZM0Nh?=
 =?utf-8?B?NlRncE9IMmVQV2JHZndqV1BSR2lnWFVXMXRtcko0QWllUEY1OU5OS2pJYk1J?=
 =?utf-8?B?UG9OaTdzUFdLQ0RDcktqbXByUnJWWXZ4TmpnQWNjZFZBWVpCdnZ2UHNseUFZ?=
 =?utf-8?B?NWo5MklGcXZTVHF0NmNPLys4Y1RpUngwVDVDeWQ4Y1l3VW05UVZqUmdJSlBT?=
 =?utf-8?B?MCt3em5CWXBsMkhPaFhad2lIblc0TTFsaGtFNTlrV2NNM1VURGhFY0c3YThD?=
 =?utf-8?B?VFRNMFJySktiajFSdEFiRm8zT0R5S0krREt1b2xuNVdyWDZtYUNTaTBBSjRz?=
 =?utf-8?B?b0hKelNRQXZoSzVOdjJXZVZsc2c3SFJFcE54eUE2ZjY5TkhrQ1ppQ0J6YnVK?=
 =?utf-8?B?aGV3OGFJbTJmTXExcmNpVldRMXVuVWJRangzZXZvQlRiNzJMZndHU3ZjSnIr?=
 =?utf-8?B?d3NkR3lVQkg1TE1QWTRvSXFWVkN0VWFBQjJhWTBNNzlmaGtRQ2xJWEhUcW1J?=
 =?utf-8?B?ZklJTlZXZ1hkTnJwYnd4dEE1UGpKemNlOHRWNXJMTloyVXBPK2krSUR0R05G?=
 =?utf-8?B?cXhBMklxVE9OQUJ1RUpyQlM4MXlwdk5BdkxYcjZOUDlTWnZZQVRQY09WSklF?=
 =?utf-8?B?citxdjA3Vm1vM2gvdDRQMnBvMXJZQzlqQ3Z6ODNrMnZsZE5YaE1kWUcvbTBE?=
 =?utf-8?B?WWVJSEJON2NsalRvbkc0TzhLL0txdzRoQ0VnYVNLY1BMNG5DbWRJYWhqVGkr?=
 =?utf-8?B?QWhVWnIxdFpTWkFoS3JCQXJUTUpPY1JWUGRnZmlrYjE2U3hZSCthK2pEYVlH?=
 =?utf-8?B?bkRMeXB2bXUxY1BLSWtXSnZxSEtINDR4c20yeFgrTnoxUU9nbkM1OTg5RG1Q?=
 =?utf-8?B?MTdBVkxnYkhNVGlFL1BiTmI2aDE4c3J5emhqR0pNaWtvNDNPem9jOW5zUEY0?=
 =?utf-8?B?K2pFWmQ2N2dQTGU4eDFVTHMyQVlaMDNOTy9TeWxBM1c2by9IYi9MZjFBazUz?=
 =?utf-8?B?dDhQNTRxaGozc0hBV2JXL1ZtbEhWNStSbyt2Z2lybWcycE15QTRPYWFKRFl3?=
 =?utf-8?B?SENIb0JHdGs3aUtJTVQ4ZC9hWXJwekUrWEhVaDhhamFmRGt3NmZscW9vWmNj?=
 =?utf-8?B?VXBtNDRvVkRlVmNJeDUvdmtDR1hucEk3RUdHc3Y1ano1bHdXRnkrc09YSDly?=
 =?utf-8?B?eWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 068bc704-190f-49f7-3ae3-08dafa4aff3b
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 18:28:44.5129
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3Tf+GyYmK4/EH8sCbzEyfgCHH75Fzb5WTJrP24yLq4Fxg5KtKoppvKosDXpUPbus34zTqvOOgzYJJ1ff5NIF7NqhnX8b1XTcYcZaZCnyaMg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4786
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/18/2023 3:46 PM, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration.
> 
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
> 
> Note that this doesn't control interrupt generation by the Root Port; that
> is controlled by the AER Root Error Command register, which is managed by
> the AER service driver.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org
> ---
>   drivers/net/ethernet/intel/iavf/iavf_main.c | 5 -----
>   1 file changed, 5 deletions(-)

Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>

> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index c4e451ef7942..2835af20ec19 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -4876,8 +4876,6 @@ static int iavf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   		goto err_pci_reg;
>   	}
>   
> -	pci_enable_pcie_error_reporting(pdev);
> -
>   	pci_set_master(pdev);
>   
>   	netdev = alloc_etherdev_mq(sizeof(struct iavf_adapter),
> @@ -4956,7 +4954,6 @@ static int iavf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   err_ioremap:
>   	free_netdev(netdev);
>   err_alloc_etherdev:
> -	pci_disable_pcie_error_reporting(pdev);
>   	pci_release_regions(pdev);
>   err_pci_reg:
>   err_dma:
> @@ -5172,8 +5169,6 @@ static void iavf_remove(struct pci_dev *pdev)
>   
>   	free_netdev(netdev);
>   
> -	pci_disable_pcie_error_reporting(pdev);
> -
>   	pci_disable_device(pdev);
>   }
>