Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp2119021rwb; Thu, 19 Jan 2023 21:27:39 -0800 (PST) X-Google-Smtp-Source: AMrXdXs5fljUiH/ajq+gKUDyeSfPri370/qyMYbuyCxwXkCm4tgQxO0yfl7w4Y/qUsfoaJz0Y4Z1 X-Received: by 2002:a17:90a:7043:b0:21d:6327:ab6 with SMTP id f61-20020a17090a704300b0021d63270ab6mr13724828pjk.1.1674192459414; Thu, 19 Jan 2023 21:27:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674192459; cv=none; d=google.com; s=arc-20160816; b=AMFqkEzCdMpXtMeNkzW0RzbZs2j5xU63E4F6svKvOronx0Tcb4Wy33CnW7efMz+/u9 PgDeoYpz+rZARqLzkRK2ehr8C68LuwtK38zLDsRy47HCZpXuzB4mK8iCRE4UXMCo3UZl TgjEgtrgcL9UGvjsRYw9iMpqPzdUPNqMP1srrfNZpsnJ9Teo0tIoyvCp5obWaPUzeQHX G5/6hpIWsgJhhg2rKjCxss/KAoxvcbNSRlu4xB0WhS6A0EupnuaCpWhTejUQ2VOstbRs COAgMy1hSn3nTOwWqzmcv9B28Esoz1CMZwfcREbECMRV7gAqHTM1/vl6zqZCPjUjWRxr F+FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=DbCK4sdyRSsWjzgZTMeTOcxpITuo0OSTmBc81jF0+2c=; b=SeVoeFKIU27kGXB7jr/bKmgEI0dCgCc1zJOnRHf+7HszRZvi3rdT+AXkkOqngvkrO4 Fy9cNwTe4DcZ5O/LsOsYvOj569zREhQGM1D/eMmZ6amATyk9P0rQrGjgHhIfXGbw3yvt lneGNxVtfk/6lGLPeS/e6CHj9OAzH8NUM9weT3uI44KV0CXOzIxVNdfvxeCuLZ1opawf yKgChZZpzNIPh6vpKcj3F2p/Ru2SN9kq9Q+sXfFLf8ZeTSKYdY10qepUyLgagJ/vToZJ RRJbotJ5JChItipsNCn/3E0htVDu5MGEsS+e3fUTwygR/boeye4Vgjoj2VCLTg/ueie6 bkxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IMDM8X+J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f12-20020a17090a654c00b00226e2321ea3si1281904pjs.157.2023.01.19.21.27.34; Thu, 19 Jan 2023 21:27:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IMDM8X+J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229539AbjATEuL (ORCPT + 47 others); Thu, 19 Jan 2023 23:50:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229722AbjATEtb (ORCPT ); Thu, 19 Jan 2023 23:49:31 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72567D0DAC for ; Thu, 19 Jan 2023 20:43:24 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BB80EB826A5 for ; Thu, 19 Jan 2023 20:57:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 390CAC43392; Thu, 19 Jan 2023 20:57:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674161868; bh=agbUGJOpRM48rXjHCnwA0EWMxXQAmOrokiPjNj8tXRs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IMDM8X+JGhZrv40FDVi+Xbq0y1BMxv0941edpqsV0rEmE8eYs967IORb/ws2qfW4Z R2CJ6PdhcTa+CGHxTmu1NiN1T/RaNwsR3jl3JN/YmBU4ZKt62JCrkBlq06/rQ2lMSa xBABvLhST286HTqtB+a8aKvyWWCIq3TPXLujncdDNm2znEu4+DTR3MQVRLOBcMGB2a SHSwYaM+UzGZGSuy3Tv1GKI8FRQLyKdZwfEJlXpe7szWlyoWOO5YwyD4CQVmfWvALG cHY1Ha6TSSNbao3gOMj86Sw2GD8IbfhoiL0LpD1A4FrNLpyStGlmy5zRiN8dwQs9Jy iANi6PDomCr9w== Date: Thu, 19 Jan 2023 20:57:43 +0000 From: Lee Jones To: Liang He Cc: ckeepax@opensource.cirrus.com, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mfd: arizona: Use pm_runtime_resume_and_get() to prevent refcnt leak Message-ID: References: <20230105061055.1509261-1-windhl@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230105061055.1509261-1-windhl@126.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 05 Jan 2023, Liang He wrote: > In arizona_clk32k_enable(), we should use pm_runtime_resume_and_get() > as pm_runtime_get_sync() will increase the refcnt even when it > returns an error. > > Signed-off-by: Liang He > --- > changelog: > v1: add missing pm_runtime_put_sync() > v2: use pm_runtime_resume_and_get() > > drivers/mfd/arizona-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks -- Lee Jones [李琼斯]