Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <adc11ed3-de89-a389-e629-3c951257469c@amd.com>
Date:   Fri, 20 Jan 2023 10:42:05 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH kernel v3 3/3] x86/sev: Do not handle #VC for DR7
 read/write
Content-Language: en-US
To:     Alexey Kardashevskiy <aik@amd.com>
Cc:     kvm@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org,
        Yury Norov <yury.norov@gmail.com>,
        Venu Busireddy <venu.busireddy@oracle.com>,
        Tony Luck <tony.luck@intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Sean Christopherson <seanjc@google.com>,
        Sandipan Das <sandipan.das@amd.com>,
        Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Michael Roth <michael.roth@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Kim Phillips <kim.phillips@amd.com>,
        Kees Cook <keescook@chromium.org>,
        Juergen Gross <jgross@suse.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Daniel Sneddon <daniel.sneddon@linux.intel.com>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Borislav Petkov <bp@alien8.de>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        "Jason A. Donenfeld" <Jason@zx2c4.com>,
        "H. Peter Anvin" <hpa@zytor.com>
References: <20230120031047.628097-1-aik@amd.com>
 <20230120031047.628097-4-aik@amd.com>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <20230120031047.628097-4-aik@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dGV3RFJtc3hMSWM0ZHVVR1lXcm5YQ3lROXZud0xpc3M1NGRQeTU2SThaSDVL?=
 =?utf-8?B?QWh4bTJ2SGNyQnJoeExxY3ZqVlNnWng4TytaaGJDME94ekJlNzByNUw4aVdT?=
 =?utf-8?B?RTd3ZE1kMjFWdTZpSjRqbFp4MktRSGVLSUY4SE1HT1NmeEVySS9rcUQreDls?=
 =?utf-8?B?QTZFRFZFMEJCcTA5a1l0b204OGYxSTR3MEgrSW1DWDJzOCt4bkxNR2VHdUlp?=
 =?utf-8?B?bjFxYXQxV0hhbTE1ZS9vSDFIVmxpQzMwTUFCM3lkZnJIZ0I4akNPY1hJU3ZY?=
 =?utf-8?B?WW5oY2VtUFFxMzdYN1BTSzc4YlFwdXNUMk0zTm9EdGcxbW4xdGxmWkxMdCtW?=
 =?utf-8?B?aGsrT3gyYmV2RktlK3NmRlE0c1pNSjA1NHVWL2Y0MWJqaFBhSTF4NTFNdFZK?=
 =?utf-8?B?V3VIMVVlcEtjZVdJRkswUHo1OThqazBsNHdJS1BTVFU4aTdJcXlYM1k2SG45?=
 =?utf-8?B?VVp0bklSSENobk5nVnNWWXJSTWI5d2JwZ1JYc2ErbkJJNEwxaTVxaVBuZGpY?=
 =?utf-8?B?RWNlT2h3WnZxSG5WeHltMUw0SlBjU3hPZy9QWjJzU0R1QWpyRHdZQUQ4SGxP?=
 =?utf-8?B?Y0tjd1g2ODhXVmhGYVVaRmYyYXNoWDJIUWZMb2l4SFl6d1FINVQrNTg3Qldh?=
 =?utf-8?B?VFFFeHIyd1NxQmg4YkR4U2RHNGUyaFN4SFduWjN1Qmw0aGdGTTRzK0puRGNE?=
 =?utf-8?B?WSs5cEZ3VW96aldIYlhmTEhmb2dhNVFuUTVKSFZCckFYQjJDcFVxdlBod3NI?=
 =?utf-8?B?RURBM3NHTkFpaUZQTllKU2J5eDFrMEJFUXNOUHBlTTF2R2tSaWV6U1hVOXNX?=
 =?utf-8?B?d2FrNHZxYU9hcTZpVnhNaFpJRWtYWUdyUXNScExJMjNzblc5RWJvRFJWMWxu?=
 =?utf-8?B?aFU0MnZYTWltemc5RTBIZER5MzZheVJ2aW95bmNlVndLRmhuM1psdlFoZG94?=
 =?utf-8?B?c2JUeFlGSGM1QmU4dVFmUmN3eXBTZlRjWmJzUXJWc1ZtWEkzV0JuTU9vQ3kv?=
 =?utf-8?B?RmxKR2ExTG9NNzkweXM0Uk5oVlF1UXdlQW56M09oaWpWcWdkSUE0dE1Bay93?=
 =?utf-8?B?eXkwQ1dLNEFscEZTN0hkL1lCcU5mcHVkREEwRmdDeENGZE1Da2NYU1NzZ05t?=
 =?utf-8?B?eVNiYmlzL0oyY243VXJPRzJQbmZubm1uZVd3d290K2x0WlRuZEJxSXRRaURX?=
 =?utf-8?B?WFBrVm0wTzdsMzZnblRsTG1kZXQ0dml5Z2dENmd0SzNhUnZkWnN2SjdJUnpH?=
 =?utf-8?B?VGtnNEQ5czBVa25tN1E0TFQxdU1ielBXUU9GUGJvbjhlanVJQ3R1VWdIWVVy?=
 =?utf-8?B?U3RNUVNKc25CcE5xR3RYZ1diNUF3N1p1aDF0aEJSNUYyMWpYam1GTDlhVXkr?=
 =?utf-8?B?VXpxeUlDNitOZDhld3lYOXVpcDYvdGhvbVU4SzQzcFowRHY3QVp1a0JKNkN1?=
 =?utf-8?B?WWlVNytaOXBLbXErTjZVR01Id2hEbnAwTGRNRy9pQTN1bkpyOU4yMy96SjVP?=
 =?utf-8?B?M09TSlFIb1lGYjJJZWJVZWc3VkpDdm10Vk9TNWtQOThKdnZEN0RwNVpQN0Vq?=
 =?utf-8?B?aEo4OTBrdTVqUUE1UFRJMURRamp2TVZrOW5XZDRrL1d5Ly80ZmFrYTVNK203?=
 =?utf-8?B?QVMyOUFPbTMvdFVGZ2lSOHY5ZXlkajNDdGVQajVCUm52Ui9yeXN3cEd5MzZO?=
 =?utf-8?B?RHhqREpOcmFXZHJiTlhCSVNMWm1TZHV6UXBQOVc4Q3U4Qk5pMUkrKzBZRVJl?=
 =?utf-8?B?amVxcjVROEFzcjQ2SDZSWlAxRUoxUlJkeXM1WDdIa0pFeGlrN0VZejYxeTQr?=
 =?utf-8?B?djdUUlVVSmp0elJHTVRHRjc0M0kyZ3JUVEVMR0FkaTJ5aXpyQ3NKYW9xRzVD?=
 =?utf-8?B?VXF0MlowQzJYeXErZTF2YlBvQ05NSWF5dFlXai9lbDRmU2JWRHhIb25pZFY4?=
 =?utf-8?B?Y21uZG5ORzJPc2RqdDB0djRMRk1YVkgwaHovY2pUNHBTcGk0OXIxeHAyQUlE?=
 =?utf-8?B?cnpqWk9LR0dVQWhkWWVhLzJFNkc5T0dzV1ZrLzEvTE9KNXlyOXc4YkRqSGNn?=
 =?utf-8?B?THNzQml6WFZJdUJmbnJBR1dHUllmRmdVbitWWlhoQk5rR2gzeWRlcSs0bHcr?=
 =?utf-8?Q?nh/reQR4QVmEEBNMUqnmvF+T+?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 878bc5e3-546e-4af4-230d-08dafaa4ebb0
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2023 05:12:26.6346
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qqIJoSrG00s1aTpQDzj3GYHo71mNJsFV+1cQmbBUwN422jMJDkktD0jR+uA0E7pQcus9Qb/2FK3TVoGzsvqNxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8575
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20/01/23 08:40, Alexey Kardashevskiy wrote:
> With MSR_AMD64_SEV_DEBUG_SWAP enabled, the VM should not get #VC
> events for DR7 read/write which it rather avoided.
> 

SNP guest feature negotiation patch is part of tip now: https://lore.kernel.org/lkml/167414649850.4906.1693185384677559889.tip-bot2@tip-bot2/

MSR_AMD64_SNP_DEBUG_SWAP is already defined. As this requires guest side changes, please add MSR_AMD64_SNP_DEBUG_SWAP as part of SNP_FEATURES_PRESENT bit mask.

Regards
Nikunj