Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp2139746rwb; Thu, 19 Jan 2023 21:51:33 -0800 (PST) X-Google-Smtp-Source: AMrXdXtCb4Hp9B4W0eQcZV+xFa0App1MayAgS8KihCMZMcJErIZHIRubXbPtGqzm2Osayh+Kld9l X-Received: by 2002:a62:148d:0:b0:58b:ca43:9c05 with SMTP id 135-20020a62148d000000b0058bca439c05mr13054399pfu.16.1674193892875; Thu, 19 Jan 2023 21:51:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674193892; cv=none; d=google.com; s=arc-20160816; b=KcUN25ju0t7TKe+wSWKdo8aO18Huk3RjarB/gNuUnPyCUE/xd6Kth4RFAZ/+fmBafS 7j7KC6jyEKXESr86lWb+AvTyC6f6H4Ncy+fL29XYTE73QYuQGiNthxLjsSiwiogSbw1v 1ihLdojyt4DbvvsboUHVJtI2d3JpWQIL3OSNJU4V2NqbA+Q5GE/BL+uXB397oNe8pBwO /Oz+rODhcei5rt5lq4Vj7OEalZEnrPLQZDhACBVglxV+6jZhZrB1U610lZAAr8uZ1f8t ImOmDcNy7EivJG+w5t1mxmliasFCZii9NrU00AFXjmwDvL6QgkOKqs24HY5if6EUMXAi 7RXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=F0WsJAqx8PPR8h367l3Ilm2FQfN4lU105WSJxq4tty4=; b=kY3PaErrR7qrZRZzfx3+N+l6nbab6gKasq2IH1Wu9zbZvdtPGcxmlONescOAizH/6q PWbJQTYYuPUdp23KnfJH3E3qIL2/gGlVVfgWp1qSF01n5iC4jisd1zXVZgaxUI4bVman MWdxWPPwin5r4+NConHNbuq4a6n610Hk3eIhIWfsV8UsrBh5+wz4S0WzWAn2pkgNXShO +KUr9fHuY3YfxnMglKLD9i3OaGhVvf47n6vlXklwasKAAT9fxysRTSFNFc6VDkrHtCLY CjqVtyA5XM1S2adfi6VKMIyRH8kFQAL8v4olrIGK+dt81NAIZjJMmf8zIiALRTCR8fSo upGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TWemGikn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 205-20020a6302d6000000b004792abca1a3si42847684pgc.20.2023.01.19.21.51.26; Thu, 19 Jan 2023 21:51:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TWemGikn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230402AbjATEvZ (ORCPT + 47 others); Thu, 19 Jan 2023 23:51:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230416AbjATEum (ORCPT ); Thu, 19 Jan 2023 23:50:42 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2704BBFF61; Thu, 19 Jan 2023 20:43:55 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 45B7EB82292; Thu, 19 Jan 2023 12:13:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CFBEC433D2; Thu, 19 Jan 2023 12:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674130436; bh=kvNujVetUBnBdfFPtEOg0jtnfsme9rQYGsNTHFLbznY=; h=Date:Subject:To:References:From:In-Reply-To:From; b=TWemGiknLSA1++g+P9cbbapukHT6XTqf0dvDktE8ZcG9t+9XuB8sSZwd7psDiMrwZ 1Si1Kua989poNMTXIIgyi0aEu2///hJzjTTc3aGCxAJzZTb3CwUwrDsQifQ0/t9q2e kBUOP3bdoAxBjs2sL9CJJRJUAPOLYL80KPBgiqpclNU9k+VbbeC/hccmboMLms6P4J PkLoqqRdprhjqPLeYqxhlQDCT6SoZtYR5Qp/IPiPj0LrVA8Zfd/m9TgL1WuDFGtStO 0QWhNZ1wYMSVaLsKarUAPKTAVnGuEHdcFfWJiwFSyTYDToz8Yi06PzOxqhU5YHQ2NT zGuNOEKl5FKtg== Message-ID: Date: Thu, 19 Jan 2023 13:13:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 2/3] ASoC: google: dt-bindings: sc7280: Add platform property Content-Language: en-US To: Srinivasa Rao Mandadapu , agross@kernel.org, andersson@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, quic_plai@quicinc.com, bgoswami@quicinc.com, perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org, quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, judyhsiao@chromium.org, devicetree@vger.kernel.org References: <1674108674-8392-1-git-send-email-quic_srivasam@quicinc.com> <1674108674-8392-3-git-send-email-quic_srivasam@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <1674108674-8392-3-git-send-email-quic_srivasam@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/01/2023 07:11, Srinivasa Rao Mandadapu wrote: > Update sc7280 machine driver bindings with platform property for > supporting ADSP based platform's DAI links. Subject: ASoC: dt-bindings: google,sc7280-herobrine: > > Signed-off-by: Srinivasa Rao Mandadapu > Tested-by: Ratna Deepthi Kudaravalli This tested tag is a bit unusual. How were they tested? If dt_bindings_check why this is not the same person as you (submitter)? > --- > .../devicetree/bindings/sound/google,sc7280-herobrine.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml > index 869b403..ccf1b1d 100644 > --- a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml > +++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml > @@ -75,6 +75,17 @@ patternProperties: > > additionalProperties: false > > + platform: > + description: Holds subnode which indicates platform dai. Neither commit msg nor this here explains why do you need it and what it really represents. Basically description repeats "platform" name of property - there is no single new information. > + type: object > + properties: > + sound-dai: true maxItems > + > + required: > + - sound-dai > + > + additionalProperties: false > + > required: > - link-name > - cpu Best regards, Krzysztof