Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 19 Jan 2023 17:05:56 -0500
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Zhenyu Wang <zhenyuw@linux.intel.com>
CC:     Deepak R Varma <drv@mailo.com>, David Airlie <airlied@gmail.com>,
        <intel-gfx@lists.freedesktop.org>,
        Saurabh Singh Sengar <ssengar@microsoft.com>,
        <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        <intel-gvt-dev@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for
 vgpu_status debug attributes
Message-ID: <Y8m+xBhGCa3kgcO2@intel.com>
References: <cover.1673375066.git.drv@mailo.com>
 <188df08e0feba0cda2c92145f513dd4e57c6e6cf.1673375066.git.drv@mailo.com>
 <Y72zVXYLVHXuyK05@intel.com>
 <Y8TkTi+/GQwhiMvO@zhen-hp.sh.intel.com>
 <Y8b3IRhx976Ke99X@intel.com>
 <Y8d6CwD3dHLKOUZ5@ubun2204.myguest.virtualbox.org>
 <Y8giB988U5cqsGdd@intel.com>
 <Y8icPEqkdF+7mg7E@zhen-hp.sh.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y8icPEqkdF+7mg7E@zhen-hp.sh.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3l9Xxy53yxM7MMT09jR/OHPecoxN4a3PYoVKaal9W8zNvWWqrmIWF2Lkg8FZ?=
 =?us-ascii?Q?+dFLHyt232QhQu442sdCWxuIV9GMm5B/gk2yrcLB6PTA9nJaR39CQk2K2kzd?=
 =?us-ascii?Q?eD6WsjK/SGp3liJrJiOD8nmlRFTfZeNap796SAKmhqqv/eczw5oBBt7yjm6m?=
 =?us-ascii?Q?1untaf7bFh0f17B0bnND0pkRvIw1rSjuaGiu5BZkNiwR3RhEf+9wn4veUid3?=
 =?us-ascii?Q?JrZQ100vw1StftMgHZKGRIS1RQYPPl9MD4B5wiEsO2T35c8BWInOTTQUd/sc?=
 =?us-ascii?Q?rl4biSAEpoxEtLUlPNgB2InE3kzxnvClP3Zra3IGamNFnF1Vs0VSCJRlaHxM?=
 =?us-ascii?Q?G/CUN3NbzFovGEEp1Hc+mGaG4jUEVNLpGc11gh6gCLtlE+Mc+HzVINlZgmVg?=
 =?us-ascii?Q?g4SHfIxnDD2Gz0oWl8PLh8+HT/msTWmnrrKBPjpOdjKKPrxV6MWYqbQtMico?=
 =?us-ascii?Q?I1IVKcfGgPexrYVXVh5f8Zi1m6BxlWtME6q1iD7HO31Ab0zSzyxNgWGm3oDk?=
 =?us-ascii?Q?Ofi7HuN/BGLQl4pCHEw1rdwq2gY36wFi0iw+R1dPrdcgi7RPqcyOnd7KziSI?=
 =?us-ascii?Q?TuFa7BzJrUHvV+1naL1FqsCnNa04sbDYzY+GgWLKOKF7GH2cWnv8lC15dwvp?=
 =?us-ascii?Q?Nzdiwyd2/8DwxYnGIiSfk3keR5sCC3me1ANFJZ2KgY98y1T9HxW4sty+kJih?=
 =?us-ascii?Q?LWvN9dJa1oqvl0y460KNclHzuIK8SeYJvPlhjNXJMF1FnEREHlXLnCzLG+tS?=
 =?us-ascii?Q?Ql0yclcf5Bup2jDJUfK5zLb5iD6lZ3EOjTUpANSeF7tJO9jZUwlsIhYSbwUe?=
 =?us-ascii?Q?6BDRcpsdUFkDrBciWYf5XTO5rL2FTJAIm6sQuNB/VGlcIPLSjHgjnb99BuQH?=
 =?us-ascii?Q?ufNHMTbvMK1Bxnwy8/wcxLNp7Rkdn03fp/Ok/N2We65sjFXqjhJgs+sdfO0d?=
 =?us-ascii?Q?2jg7SA8PHXv3nyoPdIMQ91NsJajBOCMzpiDaVNrILI8z9VdbWUqNad6cSswp?=
 =?us-ascii?Q?LNHQH0xIgOrn4r+XtuyZEEm9JK/+ba6Gswl8vppmNwIUr+bvSco1q+bwn7IE?=
 =?us-ascii?Q?bT8NsG71B5ioj52K0k5cU3IsHYYdOXpcrOcY8Bw7U6lcbmGnUkYhdCI8UJUf?=
 =?us-ascii?Q?xDVd0YIT0bZ2y+raAVrHbAqifA7jy8PPxmeJHLL0lgY2Ics3kN6HNQnLlwwd?=
 =?us-ascii?Q?2vBbx3cVD3eJUHt158bEcpkdG77j4K9wDZ7pljLaof5hbJCTfoXxyh92AdTE?=
 =?us-ascii?Q?q3dq+rpmUTBOOMHKwqmqTrdIPAo0biI11YDW4/29HlOxQF5tk8i7KjRSGati?=
 =?us-ascii?Q?s/AO133pACRpR4dyKO87oYrj91kP/eq8M3TOr8ByeZeNdEF1vnfoK5FLQYFq?=
 =?us-ascii?Q?i5HpjJdjhk6EhcED+V0atUqIAldjQMScVi7LpRlK4IqmGqm/MFScZk/c1Yem?=
 =?us-ascii?Q?h/mCQNscpl7Ij/bo8NpF+cXMokit7KHS4eJMCOVQWXHU0RlyMoiPDcgPiZGt?=
 =?us-ascii?Q?a7z4Td380fAsxRQ+BTyaVDTw7Q4/tVpI9BTtt8cb//6GW6zsJpyc/68DQNrX?=
 =?us-ascii?Q?82hMp6lT5PGQ6kn11qresZ0uc3S1j8/mwtw8qAFT886rWyOh4zqbRZXjvT2r?=
 =?us-ascii?Q?kA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c8939b6e-d5c1-4ba9-7464-08dafa6959f8
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 22:06:01.7137
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Qz7Q4wKYj1yt1F0vDx+Xxgx85nGeqhdFDcl1oX4m6GjADUJgQyBHsFY5vXWXI90tgTpbMleHq991pMxGHQPnIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5045
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 19, 2023 at 09:26:20AM +0800, Zhenyu Wang wrote:
> On 2023.01.18 11:44:55 -0500, Rodrigo Vivi wrote:
> > On Wed, Jan 18, 2023 at 10:18:11AM +0530, Deepak R Varma wrote:
> > > On Tue, Jan 17, 2023 at 02:29:37PM -0500, Rodrigo Vivi wrote:
> > > > On Mon, Jan 16, 2023 at 01:44:46PM +0800, Zhenyu Wang wrote:
> > > > > On 2023.01.10 13:49:57 -0500, Rodrigo Vivi wrote:
> > > > > > On Wed, Jan 11, 2023 at 12:00:12AM +0530, Deepak R Varma wrote:
> > > > > > > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file()
> > > > > > > function adds the overhead of introducing a proxy file operation
> > > > > > > functions to wrap the original read/write inside file removal protection
> > > > > > > functions. This adds significant overhead in terms of introducing and
> > > > > > > managing the proxy factory file operations structure and function
> > > > > > > wrapping at runtime.
> > > > > > > As a replacement, a combination of DEFINE_DEBUGFS_ATTRIBUTE macro paired
> > > > > > > with debugfs_create_file_unsafe() is suggested to be used instead.  The
> > > > > > > DEFINE_DEBUGFS_ATTRIBUTE utilises debugfs_file_get() and
> > > > > > > debugfs_file_put() wrappers to protect the original read and write
> > > > > > > function calls for the debug attributes. There is no need for any
> > > > > > > runtime proxy file operations to be managed by the debugfs core.
> > > > > > > Following coccicheck make command helped identify this change:
> > > > > > > 
> > > > > > > make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
> > > > > > > 
> > > > > > > Signed-off-by: Deepak R Varma <drv@mailo.com>
> > > > > > 
> > > > > > I believe these 2 gvt cases could be done in one patch.
> > > > > > But anyways,
> > > > > > 
> > > > > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > > > > 
> > > > > > for both patches... and will leave these 2 patches for gvt folks
> > > > > > to apply. Unless they ack and I apply in the drm-intel along with the other ones.
> > > > > >
> > > > > 
> > > > > yeah, they're fine with me, feel free to apply them directly.
> > > > > 
> > > > > Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>
> > > > 
> > > > Unfortunately I got some conflicts when trying to apply on drm-intel-next.
> > > > 
> > > > We probably need a new version, and probably through gvt branches it
> > > > will be easier to handle conflicts if they appear.
> > > 
> > > Hello Rodrigo,
> > > Sure. I will send in a new version. I am current using linux-next git repo as my
> > > remote origin [tag 20230113]. Are there any specific instruction/location from
> > > where I should access the gvt branch?
> > 
> > https://github.com/intel/gvt-linux.git
> > 
> > but with the linux-next your patch is probably right for them.
> > 
> 
> yeah, I think so as currently from last pull request I don't have
> other updates in gvt tree, maybe it's just d-i-n hasn't included
> recent gvt change.
> 
> I saw Deepak sent a new one, feel free to apply. Let me know if
> there's still any issue.

It still doesn't apply in drm-intel-next.
Could you please take it through your branch?

> 
> thanks!
> 
> > > > > 
> > > > > > > ---
> > > > > > >  drivers/gpu/drm/i915/gvt/debugfs.c | 6 +++---
> > > > > > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > > > > > 
> > > > > > > diff --git a/drivers/gpu/drm/i915/gvt/debugfs.c b/drivers/gpu/drm/i915/gvt/debugfs.c
> > > > > > > index 03f081c3d9a4..baccbf1761b7 100644
> > > > > > > --- a/drivers/gpu/drm/i915/gvt/debugfs.c
> > > > > > > +++ b/drivers/gpu/drm/i915/gvt/debugfs.c
> > > > > > > @@ -165,7 +165,7 @@ static int vgpu_status_get(void *data, u64 *val)
> > > > > > >  	return 0;
> > > > > > >  }
> > > > > > >  
> > > > > > > -DEFINE_SIMPLE_ATTRIBUTE(vgpu_status_fops, vgpu_status_get, NULL, "0x%llx\n");
> > > > > > > +DEFINE_DEBUGFS_ATTRIBUTE(vgpu_status_fops, vgpu_status_get, NULL, "0x%llx\n");
> > > > > > >  
> > > > > > >  /**
> > > > > > >   * intel_gvt_debugfs_add_vgpu - register debugfs entries for a vGPU
> > > > > > > @@ -182,8 +182,8 @@ void intel_gvt_debugfs_add_vgpu(struct intel_vgpu *vgpu)
> > > > > > >  			    &vgpu_mmio_diff_fops);
> > > > > > >  	debugfs_create_file_unsafe("scan_nonprivbb", 0644, vgpu->debugfs, vgpu,
> > > > > > >  				   &vgpu_scan_nonprivbb_fops);
> > > > > > > -	debugfs_create_file("status", 0644, vgpu->debugfs, vgpu,
> > > > > > > -			    &vgpu_status_fops);
> > > > > > > +	debugfs_create_file_unsafe("status", 0644, vgpu->debugfs, vgpu,
> > > > > > > +				   &vgpu_status_fops);
> > > > > > >  }
> > > > > > >  
> > > > > > >  /**
> > > > > > > -- 
> > > > > > > 2.34.1
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > 
> > > > 
> > > 
> > >