Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp2141971rwb; Thu, 19 Jan 2023 21:54:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXuBPcX3FVmh0hcfbz7/eXfcarswxJnpYJMb5h+1UPbgbfS/S88LwKnpv6JirgGgkKuFwsUJ X-Received: by 2002:a17:902:f650:b0:192:b43e:272 with SMTP id m16-20020a170902f65000b00192b43e0272mr16613128plg.53.1674194063744; Thu, 19 Jan 2023 21:54:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674194063; cv=none; d=google.com; s=arc-20160816; b=TvFXrVRLiyMFeLQ6nDbyS1POdtPa684FurB4PIyBXJaBfF/mvIuOMkPUxIKUjs6bdD PhxB4gxR41jxlPgQ4k+TlD+ZQS3G9OFvQc9QkCgmdjp2aXKMfQhQdzgQp44qL0tzxeBw Fpjhs6nO0oI9YQNtt4lRH0NOBVMKczzgdWpxNKeRWYgXikVNrqjyjTnzKTIx6gx2Okay aOkiSnlqGi8/cmV3/sUT4SHwr9GQ+9OFJigOpXVJuhPX+sztqiyjYVTqUn/beembDiab sXmjgq6QCMd5XK+hNq8BmgXaXP34uOtCXAhHOJ4Qagj1MypQdX2428HqmtlXrbp4r++u voHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=MsYPEs/NMDCyX8flZchUi8mT5DVpM+reFdDBAL/k6hY=; b=iJ/b9mC2Fu7wmvy/aG1DVb4bUv7M2FofL34lkWVQDmb1OwEbxEa8pJbpqUQkPo5Oa9 fD6O5cGKF85MQgK5SIcqL18iysj0GFCyis4ga66iSLQM9C8fncJlOBUdHg92weN7K50k 7fcSXjiCYwiM57WKIqXPz77nlB19vVbnbfGYYVj3pX40k6MkRs1mpigkg0aAzWvBBW9E lWMZaw9s485laasBdijy1Gt31/cLsojXxk4RGxSqigHV4G9yCZczxK7z6pmyUIyx6BZK v1nnogj+/jFY/dkUWlwmzGGt16NJRLFBYwO0NczdgCMjSTtdrT0MrXMuT8At5XTR2ElH KpMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="pW/EJdAh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b17-20020a170902e95100b001926a7725e0si39677148pll.509.2023.01.19.21.54.17; Thu, 19 Jan 2023 21:54:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="pW/EJdAh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230455AbjATFYN (ORCPT + 47 others); Fri, 20 Jan 2023 00:24:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbjATFXn (ORCPT ); Fri, 20 Jan 2023 00:23:43 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AEE07AF37; Thu, 19 Jan 2023 21:14:04 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E4E9CB82674; Thu, 19 Jan 2023 21:39:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 902BBC433F0; Thu, 19 Jan 2023 21:39:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674164375; bh=yQT7vF8YUwj4dpk5uOYW6ZI2HJbDbf0PuVFcTzzBj/s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pW/EJdAhnBZ70wuOAsx/7rczHPj006EtmoxDD+J6Ce2Zw+Nanrs7JqMej38VCsGfu w8x7ze74AHlVv7fjBNnd+nHIqwQuL4mKA/e17XE0iav6L8XfugKQp8l15PAIYhd8Ec WyCDvGyPoKvLRryTge0rzzAJqffxADf1pnrYgyfyBiAVhT34+Xek1K0eWTWns9lox6 udROIv+bL+htcolekcNqfSdqWzsI7UFO0CG/DAP8eODuq360y+JjrPCZMQIT2uph05 +q1i82sD8VBVDqp47gKyyb0CQmIzXAeOdmSVYY1Ltzws1lQr8EZxjHY625K13H1BFv R3+Uo/3FdQXHA== Date: Thu, 19 Jan 2023 21:39:30 +0000 From: Lee Jones To: Stephen Kitt Cc: Daniel Thompson , Jingoo Han , Sam Ravnborg , Helge Deller , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND 3/4] backlight: ipaq_micro: Use backlight helper Message-ID: References: <20230106164856.1453819-4-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230106164856.1453819-4-steve@sk2.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 06 Jan 2023, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt > --- > drivers/video/backlight/ipaq_micro_bl.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Applied, thanks -- Lee Jones [李琼斯]