Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a700c648-f1de-83af-ae6a-181bf8f04e21@oracle.com>
Date:   Thu, 19 Jan 2023 21:56:53 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: =?UTF-8?Q?Re=3a_=5bPATCH_linux-next=5d_mm/hugetlb=3a_replace_get=5f?=
 =?UTF-8?Q?hwpoison=5fhuge=5fpage=28=29_with_get=5fhwpoison=5fhugetlb=5ffoli?=
 =?UTF-8?B?bygpIHdoZW7CoCFDT05GSUdfSFVHRVRMQkZT?=
Content-Language: en-US
To:     yang.yang29@zte.com.cn, mike.kravetz@oracle.com,
        muchun.song@linux.dev
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org
References: <202301201036092738081@zte.com.cn>
From:   Sidhartha Kumar <sidhartha.kumar@oracle.com>
In-Reply-To: <202301201036092738081@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTNYeTJZMlpiTnFGSFRRWi9xc0VibTZRSFR1UHowbDBGekhIZnJ1NVc2ME1r?=
 =?utf-8?B?WFE5eUV0Njk1aFhOR1dYWllIdklrR09pbWJzdWkxRi9vbEJZdlVPeHRFS0F0?=
 =?utf-8?B?WVNiK3VLSXN5dURiQ083aXJTWWtGNlJQc0pZS21paWJaYmV5NXhHYTUzMjcw?=
 =?utf-8?B?Qmg3bWU1KzVNcWhJZ0Y4cGd3QXl3VDR0SkVsVlplZ1I5RFF1WUNCaG1ZdzVJ?=
 =?utf-8?B?bHJxMks2UEhmcnNHMVZGQ1RGSCtOaHR3bjlleUUyZUFRK2NHR1k5YjRoZEZm?=
 =?utf-8?B?Yk5jWVF4NXVtai96RE9ITnAxeG83M2xDVU44VncvTjZVenF4M3JZVmV1bWQ2?=
 =?utf-8?B?NG9IbXBmR0NNclB1dGNwUktrRURESkdaZmMzZ2YwNStEZU9uNjF2RzlQMEx2?=
 =?utf-8?B?VlN5cm5EdFQvY2kzaFdjeXVWRjNrRGU2bW52TDdOLzhQWmNrdmk5aExhQkl2?=
 =?utf-8?B?SnpYb3JpbU5aRXdBbks5QmdranhycW12Y3ltdW0rM3MzYm1lNXFHenh0dGdM?=
 =?utf-8?B?S0lZUUkvYXk4K2xFTkNEWXRWcmNVdEZ5QmUzemEzaW1mTzN1M3d2WEdjS29U?=
 =?utf-8?B?WUtsSzdUVVoxRnUyZjBMQlNhT0RXdCtHajAveGxVNFJLb2trcXZnanBpL2JS?=
 =?utf-8?B?L1JYRjBHVEk2bHZYcFdXRUhONFAzT1BGbE43L0tBQnNOYzVBdGZUZm5aVkZF?=
 =?utf-8?B?OXhOMmc1WFhWQXNlcFhYQzhYVE1vNmxGWUFNdmtYRGpsVnFhd3BudGhoVExN?=
 =?utf-8?B?cy95Y080dDdYMlpIMGlsT2RSZFpGWVZlZHY5Y1hMUXYzL05vM2M5WHBXN1FQ?=
 =?utf-8?B?K1RJVXMyWnF2Q0hBb0dzb2JsbExoaHY2L1MweXdNbFhRSEsyZkUxTi94NW93?=
 =?utf-8?B?SVUrUGdVY2QrUUFiMEhNTDh1UkFuSUhSeHFIS1dvczI0QjFVMUlKYnFQZVRB?=
 =?utf-8?B?eTFyNUlXL0FsSUlBZktXQ1NlNUdGU0lZdjFQSklJOThxTWFRZUZnUm5GaGFn?=
 =?utf-8?B?ekk5T2NmMU10OTRkTlc1NHlReWFBbUVMbzVRa1lCVnFHempVbEFqM0xCSTl5?=
 =?utf-8?B?TGd1R3JTS3k2dmhzSnQra1AyTStiaHpWMysrcHdKUEx3MzZ2bVorSlE1Wnkx?=
 =?utf-8?B?SURXbGIxcXNDZzZTcGdpMGhrRmsrRERGTkMrSSsyTzVVQTJIRDRpYTJVTk9Q?=
 =?utf-8?B?eWVhcktjQnVRNmpOZ3ViRDFsQ0VJeGhaNU1ZOGZuMWNOSEZWbUJLdktnY0Qx?=
 =?utf-8?B?R1V5TlU5dWptK1JYa1JZSkFvZERwbDR0cGEzWUJHSFJlVFFPMkpnSzhPYlNS?=
 =?utf-8?B?Z2ZleHhXRWdwSEViSTNqa0VMRURlVWY1bEpPNU10YnlYakl6blEzUFRLSm5k?=
 =?utf-8?B?VWFCanoxSDNBV3d6YkswblVKQnphdCt4aEFQRVRydEZLVm5qVi9xVG04S29l?=
 =?utf-8?B?WStIOFRxaG1ZUlRyNkNmZkxzdEx1RkZZbVBVOHZCbVlxN0Z5SlVtWUxYempk?=
 =?utf-8?B?TmgyejNLUnZDdW1sSDl0MFk1dTRnb3BqTVNuUENpVDRGajkzeUlPZGJNRDVy?=
 =?utf-8?B?VXYzTUlzai9zeWo0U1dtdEVhVXo1NVVWRU5yMnFyb0c4a2VPY1ZrZG9iWXRV?=
 =?utf-8?B?YklvZmt6UitnMkNUZzhUYTVlalRjMEFidXlwR0NIelFkamoyR1RnT0lIZHVk?=
 =?utf-8?B?NTArVkVzcDB2NlpvV3JNd2g3NjNEMmxTSU5Rd29sNkNIZWs3L2FUdWRmM1px?=
 =?utf-8?B?ejdiSFRtc3VVMlMwRDFiSFZtcnY4SXJYdlUxbTBpMUxrUms2b3VKdnVITUpu?=
 =?utf-8?B?OWZ4RlRtM0JOUkovbStGejF1amp4eUprLzI4bm1zWnRiazIrOXBHWExKdTNS?=
 =?utf-8?B?WlVNMDdZOTJwSldOYXh2cCtxNkNibnJqQ0habVNCVklLV2VGN1M0QThHbUQ4?=
 =?utf-8?B?R09HTWxvRTQyZmJRZzFpMGF0R1ByL2NLbnRHQWR1T3VCYVlrQnIrMFZuRUJ5?=
 =?utf-8?B?dktaMHlHS2E2N2hnL2pwajN6WnhNcVNZOFpLNnQzNzFtdUo3ZlplNzhxNFhi?=
 =?utf-8?B?NEVDbERaR3dwck01cUhIclV6alZkS2RWRC9Hc1l2d1dobklmUVRsR1J2MTM0?=
 =?utf-8?B?MkZQMUtIdFhWMHVDOSsrTUpadFBzN1gzNVFwR1l4Z1dtbWVYcVZoa0c5VHlC?=
 =?utf-8?B?bUE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: SC/PCx2l6hlymnvTs4c4axHPV++TBZA+3VE4eKM5jaHDN22rL++X3pAVY8QWR6oWrnMzuwlRe3mMw9+pMbe6LL0bruL4vXjOayX6KVetmrS/qqQ3oyjo8YRcxQtY3sldhxav81fEZqpdc72lKUrMyTcYFXjK2caiAMSzBHXqTnvU8g48ZYv8Mqiy6QyCwPsKnFZnpfkBKlc1DE7eHi4MjLzMyKtT0qnpUZCes/Gfzo9lRFQcUn63+G6mvkPAVKSta8XbLM0cF4bxiZ/oc1MmfhXJlXoQgAnEYORv29rSR+sWlx3VCnfD1z00KoKR9CjhTCMoP+choIrRLrqWr32XLevPhcYd5sZP9w98Xsw8+qzkY8obAUoJ/cvR1dc1cfP7unqDi5Nz+s7NqOe9sclGgedse+WUAhU7S5gisBwNTRSHzAXZ+rUrKp+Dj+B8mizVorjJltTgxV9MOLEf7Ym4QbMpaU+8A8PXbIQZmNI6kNypuPe9NUx3+cldndtgrVtSbYhXKzTK8HTyyx0Oka5Z+2iYZlewEDDxMLi3IoC+ZgSgsAaJo1wfP/I7w8XVG9z/jZrJcOEJyxgFW9Y60pnSG7JuWFkgJxQuNu94lbI1Nat19kXT6/j+pqXiQoonXeDSocKm13cUdGq1AHIVuGB+wEu/9PpEfGZweAYYiez2wSHASBnf4h8DN4hq3RdoRwZPTGdfs2fT8ECoel2vOVOu3kSNQiXM5kTcKyegS0QK0GxqWsmMiKREo/Jx2VKK+fE1u3jT79rAESuYo9YLR0b9Ww/XfnXd+XmbVQMYuE7u6Q9ViBjnFEZOQkT7JBIndpCdIsm8CKJ1d7F2Bk7Ivh+6CD3XLyyJX3tz4swHRO/mwd4HxEIpRl2attSIv5FtPyrK24P9arOy8fDaa7qKcOrgYQ==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8cbbbea6-2b95-499a-f8e4-08dafaab22a2
X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5117.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2023 05:56:55.8022
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ixDY8dCG0vdFiLaw2r2Xrtw8NUyo7CqoUdi/5OzvlzQL2KM8hHPrrYNoKM7Mgv0vyjqrnM+tyuMKnnrSobllPIwsoSCMfYSs2ZUJH+iJnsU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4447
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-20_02,2023-01-19_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0
 malwarescore=0 spamscore=0 mlxlogscore=999 mlxscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301200053
X-Proofpoint-ORIG-GUID: fh80ErlxJARvu1nuxeRmHDG_vXRFu4ch
X-Proofpoint-GUID: fh80ErlxJARvu1nuxeRmHDG_vXRFu4ch
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/19/23 6:36 PM, yang.yang29@zte.com.cn wrote:
> From: Yang Yang <yang.yang29@zte.com.cn>
> 
> When CONFIG_HUGETLBFS is not set, there are two problems. One
> is implicit declaration of function get_hwpoison_hugetlb_folio(),
> the other is get_hwpoison_huge_page() is defined but not used.
> Fix them all by defining get_hwpoison_hugetlb_folio() instead of
> get_hwpoison_huge_page() when !CONFIG_HUGETLB_PAGE.
> 
> Fixes: 92e109a2c5a7 ("mm/hugetlb: convert get_hwpoison_huge_page() to folios")
> Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
> ---
>   include/linux/hugetlb.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index f14a6bd2a6ed..9189cc359c64 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -417,7 +417,8 @@ static inline int isolate_hugetlb(struct folio *folio, struct list_head *list)
>   	return -EBUSY;
>   }
> 
> -static inline int get_hwpoison_huge_page(struct page *page, bool *hugetlb, bool unpoison)
> +static inline int get_hwpoison_hugetlb_folio(struct folio *folio, bool *hugetlb,
> +			bool unpoison)
>   {
>   	return 0;
>   }

I believe this issue has been fixed by this patch:

https://lore.kernel.org/linux-mm/20230119111920.635260-1-arnd@kernel.org/T/

which has been added to mm-unstable now.

Thanks,
Sidhartha Kumar