Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 19 Jan 2023 18:43:17 +0000
From:   Conor Dooley <conor@kernel.org>
To:     William Qiu <william.qiu@starfivetech.com>
Cc:     linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
        linux-mmc@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jaehoon Chung <jh80.chung@samsung.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] riscv: dts: starfive: Add mmc node
Message-ID: <Y8mPRQnGPpAhpu8C@spud>
References: <20221227122227.460921-1-william.qiu@starfivetech.com>
 <20221227122227.460921-4-william.qiu@starfivetech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="XKsT41m8CI9UsBxP"
Content-Disposition: inline
In-Reply-To: <20221227122227.460921-4-william.qiu@starfivetech.com>
Precedence: bulk


--XKsT41m8CI9UsBxP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey William,

On Tue, Dec 27, 2022 at 08:22:27PM +0800, William Qiu wrote:
> This adds the mmc node for the StarFive JH7110 SoC.
> Set sdioo node to emmc and set sdio1 node to sd.
>=20
> Signed-off-by: William Qiu <william.qiu@starfivetech.com>
> ---
>  .../jh7110-starfive-visionfive-v2.dts         | 25 ++++++++++++

FYI, this file does not exist in the v3 Devicetree patchset sent by Hal
Feng:
https://lore.kernel.org/linux-riscv/20221220011247.35560-1-hal.feng@starfiv=
etech.com

Would you make sure that future revisions take into account that there
is now a jh7110-starfive-visionfive-2.dtsi file instead?

Thanks,
Conor.


--XKsT41m8CI9UsBxP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY8mPRQAKCRB4tDGHoIJi
0toIAP4zpbU0OLSqlFxJVLB/Y+fIjOaoIFT/p8c4yIjZ70N3XAEA5X6zPiLp8UDG
nNz0GgJfub7PTipxdxFuprUVZpvnkAg=
=roCg
-----END PGP SIGNATURE-----

--XKsT41m8CI9UsBxP--