Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp2220446rwb; Thu, 19 Jan 2023 23:17:39 -0800 (PST) X-Google-Smtp-Source: AMrXdXsUWJtrQ3yrAf/XU7P0WwVsNTZg3R6CK4PGjnvcT4Q/9gO1dC21k69oFJ7C65CM9iDsQ/6W X-Received: by 2002:a17:903:26c9:b0:194:9b68:aba4 with SMTP id jg9-20020a17090326c900b001949b68aba4mr13184645plb.69.1674199059711; Thu, 19 Jan 2023 23:17:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674199059; cv=none; d=google.com; s=arc-20160816; b=MsNf8UmFvbCbbxS2UxbDJiAs5ByvcLCSpD6FjV9QN8j7l3iVSFNrP+lF+wWiCFLej3 PsxZEerrnSdAUY8bH/NYbRZ+mrHyxk4+lMbLg+8r1+MPWkviZQgvWRutyKPWPM6eTUh9 8FFvZLljlGX+Fkqiq9QrKtC7I/y2vaAwsVYXuw5DeZY6e5dsYH7jORUBXNrcL/J3besf 07wbCT1x7cf/s9PVw+7q1bxDLW+PjpEOkEBFX5Y8ZiSQXwzlso79RfAxtQMuADicijIY Zu6qzclPO2Lw29JdULrXDl2D+cCIU/o9WpWe1yyjpyAqYO8fOOxSimok0pq+fpfhQKwB o50w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9Ed+d3USRfIWJF6kDedPAaVnuzlqoFgO1DPR1nC3ibk=; b=CutGGvalKBUN28HdXxq2xC/VhKU7A6gQrD5WD1qHL6TqmhZNHRFX8TwEVrgBWNWpyY NNdOmhgssWiWANsrD3dtE1k24delGFwxEXO1KGNsg5DtRVgxDksXEVMQBgjuXeuSgRWZ PJbMm88HkeGXWhUGSQvl1YGHy9LFOeR8J/zft4yzs0V5LTsuemteNyKX6I+squNhwLTh QoD5yPLoSyffQS/ef1oeUTTfBppofkhdpZI6hYvz7SG9R2eVv8i3JwHtXpShI7YmgH6f 6jlGIXjHLQ9oMT0MH5YMi9tu9+jHmpFqgU2T0WQ+LjlbVfU3aEJPMiY9uN5flcUauUo7 XVSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ELxaULdR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l5-20020a170902d34500b0016efde92292si39536387plk.255.2023.01.19.23.17.33; Thu, 19 Jan 2023 23:17:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ELxaULdR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229597AbjATHFe (ORCPT + 49 others); Fri, 20 Jan 2023 02:05:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229571AbjATHFc (ORCPT ); Fri, 20 Jan 2023 02:05:32 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFDA760CB1; Thu, 19 Jan 2023 23:05:26 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7B19561E2C; Fri, 20 Jan 2023 07:05:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 475CBC433D2; Fri, 20 Jan 2023 07:05:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1674198325; bh=Z7MvmukRBMOVCQZwdpuSlmuG3oETlfTsg97FPGsKsW4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ELxaULdROdpnsoiiTjLMFRuMi2tAln5DRtvohbDMTeLsFWw7tAfEVM+PIdmRbEcDF wr2LmmRjggIz3pf9A47KnGvEU01CbQLdM64WnawYfNEC9qaM07yFzlZisMhAS1501m NrTgWi2wElf9kJw2rry23r53muU4dzGXpqwtM4So= Date: Fri, 20 Jan 2023 08:05:22 +0100 From: Greg Kroah-Hartman To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, Frederic Weisbecker , "Paul E. McKenney" , Zhouyi Zhou , Will Deacon , Marc Zyngier , rcu , Frederic Weisbecker , Ingo Molnar , "Rafael J. Wysocki" , Thomas Gleixner Subject: Re: [PATCH] tick/nohz: Fix cpu_is_hotpluggable() by checking with nohz subsystem Message-ID: References: <20230119204434.4017605-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230119204434.4017605-1-joel@joelfernandes.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 19, 2023 at 08:44:35PM +0000, Joel Fernandes (Google) wrote: > For CONFIG_NO_HZ_FULL systems, the tick_do_timer_cpu cannot be offlined. > However, cpu_is_hotpluggable() still returns true for those CPUs. This causes > torture tests that do offlining to end up trying to offline this CPU causing > test failures. Such failure happens on all architectures. > > Fix it by asking the opinion of the nohz subsystem on whether the CPU can > be hotplugged. > > [ Apply Frederic Weisbecker feedback on refactoring tick_nohz_cpu_down(). ] > > Cc: Frederic Weisbecker > Cc: "Paul E. McKenney" > Cc: Zhouyi Zhou > Cc: Will Deacon > Cc: Marc Zyngier > Cc: rcu > Fixes: 2987557f52b9 ("driver-core/cpu: Expose hotpluggability to the rest of the kernel") > Signed-off-by: Joel Fernandes (Google) Also want to cc: stable on the patch? Anyway, for the driver core portion: Acked-by: Greg Kroah-Hartman