Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 20 Jan 2023 08:05:27 +0000
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Jesse Taube <mr.bossman075@gmail.com>
CC:     <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        Yimin Gu <ustcymgu@gmail.com>,
        Waldemar Brodkorb <wbx@openadk.org>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH v1 2/2] riscv: configs: Add nommu decfconfig for RV32
Message-ID: <Y8pLR7CUad2eLe+A@wendy>
References: <20230119052642.1112171-1-Mr.Bossman075@gmail.com>
 <20230119052642.1112171-3-Mr.Bossman075@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="GLd6KBy4q8LeeBDp"
Content-Disposition: inline
In-Reply-To: <20230119052642.1112171-3-Mr.Bossman075@gmail.com>
Precedence: bulk

--GLd6KBy4q8LeeBDp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Jesse,

Same here w/ a single nit.
I'll leave judging whether supporting rv32 nommu is worthwhile to others!

On Thu, Jan 19, 2023 at 12:26:42AM -0500, Jesse Taube wrote:
> riscv: configs: Add nommu decfconfig for RV32

typo: defconfig

Thanks,
Conor.

> 32bit risc-v can be configured to run without MMU. This patch adds
> an example configuration for RV32 nommu virtual machine.
>=20
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> Cc: Yimin Gu <ustcymgu@gmail.com>
> ---
>  arch/riscv/configs/rv32_nommu_virt_defconfig | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 arch/riscv/configs/rv32_nommu_virt_defconfig
>=20
> diff --git a/arch/riscv/configs/rv32_nommu_virt_defconfig b/arch/riscv/co=
nfigs/rv32_nommu_virt_defconfig
> new file mode 100644
> index 000000000000..460907253a80
> --- /dev/null
> +++ b/arch/riscv/configs/rv32_nommu_virt_defconfig
> @@ -0,0 +1,16 @@
> +CONFIG_BLK_DEV_INITRD=3Dy
> +# CONFIG_MMU is not set
> +CONFIG_COMPAT_32BIT_TIME=3Dy
> +CONFIG_SOC_VIRT=3Dy
> +CONFIG_NONPORTABLE=3Dy
> +CONFIG_ARCH_RV32I=3Dy
> +CONFIG_BINFMT_FLAT=3Dy
> +CONFIG_SLOB=3Dy
> +CONFIG_VIRTIO_BLK=3Dy
> +CONFIG_SERIAL_8250=3Dy
> +CONFIG_SERIAL_8250_CONSOLE=3Dy
> +CONFIG_SERIAL_OF_PLATFORM=3Dy
> +CONFIG_VIRTIO_MMIO=3Dy
> +CONFIG_VIRTIO_MMIO_CMDLINE_DEVICES=3Dy
> +CONFIG_EXT2_FS=3Dy
> +CONFIG_PRINTK_TIME=3Dy
> --=20
> 2.39.0
>=20
>=20

--GLd6KBy4q8LeeBDp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY8pLRwAKCRB4tDGHoIJi
0kg2APsF9EWMCh3V0/jjH/xYpiSbRuTSUV5wrKfqJH3ToQ7IWwD/RJR7Rut4vZTe
BQoyi9Tt2/66Fk2/IAg2KAkUwC9x+AE=
=yXNl
-----END PGP SIGNATURE-----

--GLd6KBy4q8LeeBDp--