Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 20 Jan 2023 17:17:22 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     Doug Smythies <dsmythies@telus.net>,
        Shuah Khan <skhan@linuxfoundation.org>
Cc:     "'Rafael J. Wysocki'" <rafael@kernel.org>,
        "sedat.dilek@gmail.com" <sedat.dilek@gmail.com>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests: amd-pstate: Don't delete source files via
 Makefile
Message-ID: <Y8pcIjGsikDeGqoU@amd.com>
References: <001201d92c93$98c8a040$ca59e0c0$@telus.net>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <001201d92c93$98c8a040$ca59e0c0$@telus.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gGvSooCfVHWjx7MDvRQ20BHJPNzUSJY4O4twRu5Ddq9A8eq/Yvog3JVZPoJS?=
 =?us-ascii?Q?V3R+UWxLD/D+1X+w2cPZnqsuJ5TTbIfEhFzQy6Qpc6WDRSDt6yRacP1LdCFJ?=
 =?us-ascii?Q?+Cj1j5794UiWa5UHiTs0ZNKWJb4gAMzPwDQSQsB36puJKktTU015ttoQKhbR?=
 =?us-ascii?Q?GX8qR9vvTxmpppe+w75rOOLW+3wV0noyW8BRMUj0L9dvCtiV6qEcL2sJftzL?=
 =?us-ascii?Q?2ROhBYH9iZ7/GC81XlernVu1F3c5cRc14SbHZBVqNmZsRX1vsl0Ga4xbuwkJ?=
 =?us-ascii?Q?qfdOVsCVse9CHZLu5cVqk/QUjnV+dzf25R+BXkfQvLD1PzJPGoYhG18sn6AK?=
 =?us-ascii?Q?icXFy1IQZ5dJWQAfG5xsDnwO8mew/dO9HCTiJFf0B2m/SYfBu07B5TDn/m0O?=
 =?us-ascii?Q?YEx20pSXkurQWstsoVeO7o0auTP5qOf2hZiRYdnbJT0V10daZCegwC6DeGDy?=
 =?us-ascii?Q?q/Xj/9/h0Cx9qK+raCwKKWzkIAmEr/VHt8iJ1GOqP4oYV5p2T/VQOU+rcgSf?=
 =?us-ascii?Q?THcqFdzKmFQJFVXPZCNGxy2CRJeZDsVXcMM539dfaCIY4o+NwQ7VPbTr/7gg?=
 =?us-ascii?Q?SU8DVvrt/myA1OZ40STwsp0um6RtljM3Fq1GR9eNDl2dJZHts8wEGiXF6/9t?=
 =?us-ascii?Q?7K+alzXsqE9nHBeo15M+aQKLPcy96SQwe2m22k0o1oXcv77LY2UvfMHqkoup?=
 =?us-ascii?Q?TF7RI6c4woJgZrO0NhalcV9EGhkBwuSEET7KpSU7y+g+/ej/BXo5hyltQZwr?=
 =?us-ascii?Q?5i8unXxV+udAOnatCdHP8RtzQhIFjzddksL0yDKhdVONFqSTfWNl2x1HmpbW?=
 =?us-ascii?Q?ucT+ftgLI75ATm7ILHejAMa2P1WU71RBYjA+aiNt0hkQRwLB1xS7Ro6vGtbm?=
 =?us-ascii?Q?VATX5eIh8acw5Na5ofMcWtXRon9AhQBrAxDEvvPuQSs4JWTwYrLZ7LXk+1ay?=
 =?us-ascii?Q?uUR6vNzF50Zo5PJPBgJgsUicyd6/gk6Gxs2tMG2ziGrgZli7jMjS53U/fFzb?=
 =?us-ascii?Q?b6+MHuTaTuqW/7m5ma8bWuAqkyjaYiF8B4GygvCqC5Yw7f9DukHxj/t4h1I3?=
 =?us-ascii?Q?SpHMa4BmgVLF+/mwi4nQriWQaNw6P4amCtUgiWupnXex5iCl0Bo59wIGjiF+?=
 =?us-ascii?Q?76/a7QEtDpqUX49A33fZb1qnH70dByXqh6Qces3lHREzD8ZM9ObKTz7IO5tZ?=
 =?us-ascii?Q?pppTir+GggVDUYXIAtHndk4s2p9HhcsStPkhkvVTxw7DOi0JEYxUdOx2Lqzu?=
 =?us-ascii?Q?6eVT1ASgsgGpcwiUIltaSaFeuu1kIgC3AHuDXVb6ExqsP4/ZiamY2+MeSkW1?=
 =?us-ascii?Q?ElYFZlZXHErfDHe9s2dEqF/WkTp60B8+lVlPnfkffuO/Yn/FrwFHWqUAUvbB?=
 =?us-ascii?Q?8mMDXqocgLgKpGzno3AtLvlSzfmotn/W0FdygW9pTAJBvTh3xKXERzNJoMIC?=
 =?us-ascii?Q?UPbqwxKhGtv2RuHpAJw2gceDiXhKeCQdnOXmr/LvFAiaxgRbGexlO8mDAL61?=
 =?us-ascii?Q?8+H791aCDkVDDur0PCugHlke3IxBPW12DnxL48Qxf+pnCInhTlvO0b0tDbdc?=
 =?us-ascii?Q?Tscl5sqZitpWHoyIcxf+imzeCaG0p9pRkJERflhX?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df9a4714-850a-4770-e35c-08dafac72fc6
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2023 09:17:43.4908
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pj/F3kY+XFDV60A2fAfbLVOfojGJ7zxnS6p1YaTlSxoAfUHoxu8K5USYFgnxdKuAG8rnk8yvYFSFlhr3vtWUAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7650
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 20, 2023 at 01:54:01PM +0800, Doug Smythies wrote:
> Revert the portion of a recent Makefile change that incorrectly
> deletes source files when doing "make clean".
> 
> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> Signed-off-by: Doug Smythies <dsmythies@telus.net>

(+ Shuah and linux-kselftest mailing list)

Thanks for fix!

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  tools/testing/selftests/amd-pstate/Makefile | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile
> index 5f195ee756d6..5fd1424db37d 100644
> --- a/tools/testing/selftests/amd-pstate/Makefile
> +++ b/tools/testing/selftests/amd-pstate/Makefile
> @@ -7,11 +7,6 @@ all:
>  uname_M := $(shell uname -m 2>/dev/null || echo not)
>  ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
> 
> -ifeq (x86,$(ARCH))
> -TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py
> -TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> -endif
> -
>  TEST_PROGS := run.sh
>  TEST_FILES := basic.sh tbench.sh gitsource.sh
> 
> --
> 2.25.1
> 
>