Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 20 Jan 2023 12:10:32 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Appana Durga Kedareswara rao 
        <appana.durga.kedareswara.rao@amd.com>
Cc:     appanad@amd.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, michal.simek@xilinx.com,
        derek.kiernan@xilinx.com, dragan.cvetic@xilinx.com, arnd@arndb.de,
        linux-arm-kernel@lists.infradead.org, git@amd.com
Subject: Re: [PATCH v7 4/4] drivers: misc: Add Support for TMR Inject IP
Message-ID: <Y8p2qOdzONxHfN+X@kroah.com>
References: <20221125054113.122833-1-appana.durga.kedareswara.rao@amd.com>
 <20221125054113.122833-5-appana.durga.kedareswara.rao@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221125054113.122833-5-appana.durga.kedareswara.rao@amd.com>
Precedence: bulk

On Fri, Nov 25, 2022 at 11:11:13AM +0530, Appana Durga Kedareswara rao wrote:
> +static int xtmr_inject_remove(struct platform_device *pdev)
> +{
> +	debugfs_remove_recursive(dbgfs_root);
> +	dbgfs_root = NULL;

Nit, no need to set this to NULL.  Not an issue, but something you can
clean up later...

thanks,

greg k-h