Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 20 Jan 2023 12:57:31 +0100 (CET)
From:   Michael Petlan <mpetlan@redhat.com>
To:     "Liang, Kan" <kan.liang@linux.intel.com>
cc:     peterz@infradead.org, mingo@redhat.com,
        linux-kernel@vger.kernel.org, steve.wahl@hpe.com,
        alexander.antonov@linux.intel.com, ak@linux.intel.com,
        eranian@google.com, namhyung@kernel.org
Subject: Re: [PATCH RESEND 0/5] Fix UPI uncore issue on SPR
In-Reply-To: <81c169dd-1b8a-b324-c845-4edb97295884@linux.intel.com>
Message-ID: <alpine.LRH.2.20.2301201256560.5281@Diego>
References: <20230112200105.733466-1-kan.liang@linux.intel.com> <81c169dd-1b8a-b324-c845-4edb97295884@linux.intel.com>
User-Agent: Alpine 2.20 (LRH 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 19 Jan 2023, Liang, Kan wrote:
> Hi Peter & Ingo,
> 
> Gentle Ping. Please let me know if you have any comments on the patch set.
> 
> Thanks
> Kan
> 
> On 2023-01-12 3:01 p.m., kan.liang@linux.intel.com wrote:
> > From: Kan Liang <kan.liang@linux.intel.com>
> > 
> > The discovery table of UPI on SPR MCC is broken. The patch series is
> > to mitigate the issue by providing a hardcode pre-defined table.
> > 
> > The broken discovery table can trigger a kernel warning message, which
> > is overkilled. The patch series also refine the error handling code.
> > 
> > Kan Liang (5):
> >   perf/x86/uncore: Factor out uncore_device_to_die()
> >   perf/x86/uncore: Fix potential NULL pointer in uncore_get_alias_name
> >   perf/x86/uncore: Ignore broken units in discovery table
> >   perf/x86/uncore: Add a quirk for UPI on SPR
> >   perf/x86/uncore: Don't WARN_ON_ONCE() for a broken discovery table

For the series,

Tested-by: Michael Petlan <mpetlan@redhat.com>

> > 
> >  arch/x86/events/intel/uncore.c           |  34 ++++-
> >  arch/x86/events/intel/uncore.h           |   4 +
> >  arch/x86/events/intel/uncore_discovery.c |  60 ++++++---
> >  arch/x86/events/intel/uncore_discovery.h |  14 +-
> >  arch/x86/events/intel/uncore_snbep.c     | 158 ++++++++++++++++++-----
> >  5 files changed, 210 insertions(+), 60 deletions(-)
> > 
> 
>