Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 20 Jan 2023 19:43:30 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Cristian Marussi <cristian.marussi@arm.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Linux Documentation <linux-doc@vger.kernel.org>
Cc:     sudeep.holla@arm.com, Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH] firmware: arm_scmi: Clarify Raw per-channel ABI
 documentation
Message-ID: <Y8qMclu5Tc3dKCS6@debian.me>
References: <20230120122326.1932614-1-cristian.marussi@arm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="tFqp+/Q7r8KZ5dAF"
Content-Disposition: inline
In-Reply-To: <20230120122326.1932614-1-cristian.marussi@arm.com>
Precedence: bulk


--tFqp+/Q7r8KZ5dAF
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

[Also Cc: linux-doc list]

On Fri, Jan 20, 2023 at 12:23:26PM +0000, Cristian Marussi wrote:
> diff --git a/Documentation/ABI/testing/debugfs-scmi-raw b/Documentation/A=
BI/testing/debugfs-scmi-raw
> index 5468ec08c084..b1c505ed444c 100644
> --- a/Documentation/ABI/testing/debugfs-scmi-raw
> +++ b/Documentation/ABI/testing/debugfs-scmi-raw
> @@ -80,9 +80,13 @@ Description:	SCMI Raw synchronous message injection/sn=
ooping facility; write
>  		Each write to the entry causes one command request to be built
>  		and sent while the replies are read back one message at time
>  		(receiving an EOF at each message boundary).
> +		Channel identifier <m> matches the SCMI protocol number which
> +		has been associated with this transport channel in the DT
> +		description, with Base protocol number 0x10 being the default
> +		channel for this instance.

s/Base/base/

>  		Note that these per-channel entries rooted at <..>/channels
>  		exist only if the transport is configured to have more than
> -		one channel.
> +		one default channel.
>  Users:		Debugging, any userspace test suite
> =20
>  What:		/sys/kernel/debug/scmi/<n>/raw/channels/<m>/message_async
> @@ -103,7 +107,11 @@ Description:	SCMI Raw asynchronous message injection=
/snooping facility; write
>  		Each write to the entry causes one command request to be built
>  		and sent while the replies are read back one message at time
>  		(receiving an EOF at each message boundary).
> +		Channel identifier <m> matches the SCMI protocol number which
> +		has been associated with this transport channel in the DT
> +		description, with Base protocol number 0x10 being the default
> +		channel for this instance.

Same here.

>  		Note that these per-channel entries rooted at <..>/channels
>  		exist only if the transport is configured to have more than
> -		one channel.
> +		one default channel.
>  Users:		Debugging, any userspace test suite
=20
Otherwise LGTM.

--=20
An old man doll... just what I always wanted! - Clara

--tFqp+/Q7r8KZ5dAF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY8qMcgAKCRD2uYlJVVFO
o/J3AQDrocI8z2YOvnr2lD+y7uAkRhGCdKRDNm0FgOKAHd4zsAEA/eiJeWiy8guK
Tr6z61MAb+ttTNN+z2RMkkHAmvAwEgE=
=Rlz4
-----END PGP SIGNATURE-----

--tFqp+/Q7r8KZ5dAF--