Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     jaegeuk@kernel.org, chao@kernel.org
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Yangtao Li <frank.li@vivo.com>
Subject: [PATCH 2/4] f2fs: add sanity check for ipu_policy
Date:   Fri, 20 Jan 2023 21:40:27 +0800
Message-Id: <20230120134029.69200-2-frank.li@vivo.com>
In-Reply-To: <20230120134029.69200-1-frank.li@vivo.com>
References: <20230120134029.69200-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RWGgjf44CD8q8i5vfgPV1OwvM65zlZbCu67NZlB8eK+JfP7MRPJp0o2j0gC0?=
 =?us-ascii?Q?CiHoe9s5Vo4wxWzE5tC/JC6cPNE15F0uKd3vNYW05WMIA6kMdeXZ/+OsoPSf?=
 =?us-ascii?Q?aFFFtLVeVKizPanLrWnJyhw1zMgwtV7PloriUP45uJhZobwzn7FTp9P1jebu?=
 =?us-ascii?Q?S1a4hw88JXKUWznWHQ0ogVf6AWPb3Rk7Jv+m21qqw/H1QBW5D6maSnw9mjG+?=
 =?us-ascii?Q?zZS/DSXhzom6BZHU/HkZonm0c+8nypUxMjT4oLnMxncnfN0rDvmxfCxpfc/g?=
 =?us-ascii?Q?Ye7WyH5XmLrXWRVzFOcGlfcfN5uSbjk89wb0GKrEpDN1mJAaux3Ef8MZ8H6/?=
 =?us-ascii?Q?4gw3Pv7sb7H8U9hJFB9CZ88hXoyblLX266wMNSxNa4u+B6J95AVgEJlgYQHo?=
 =?us-ascii?Q?0EAMa2xEi4VRd1mtc1CvgsoqLswOKVkWsNj4TiV4QVlt9X4u5dI+qUyuTio8?=
 =?us-ascii?Q?Dfxm0UJaa+Q8SBQLDYa7VJGae9iLOks11EVGSnPjJRCVab67FNDq1WNfzmqM?=
 =?us-ascii?Q?7jBm9c2ZeDui9wE9CkBD0pFpbIc+i4RuQmCeL77ghH3fL0Kgk0SMn2oIItx3?=
 =?us-ascii?Q?Gn+sye3rk5UAW0loYv75/fbg+zYUlHsEv7JndWlTY0939UKO3GrDYlbxdS1K?=
 =?us-ascii?Q?A0GXS19HP0Cts1aYYuaPOcEUA3p9058Uu2wRZYCpN9pRuJ1uHl1/SAoHaxks?=
 =?us-ascii?Q?9slpZSM68tfvJcXQLyVg1dQJksXABcMgT+ioeWhrJMYw0lXmObB01LTCa8J3?=
 =?us-ascii?Q?vXO9YMDgwKr0MNJoQa33kpTQ4t4vENovVuoY80atoOqKi/vGemk8c4TQYeXT?=
 =?us-ascii?Q?9fAe3C/x5kiz70mB4Sknb5AdYm0w8TLeM1FJhjmdWdom1G5wbLrTA85ZlL/7?=
 =?us-ascii?Q?vJ+fobZXUelHWjgql5k+rbo5cuNbumXNrcEujikcHWPr57QGwsRYmkXKNg8Y?=
 =?us-ascii?Q?PS+i/F0v8mexYD76KT6yBVbEI19cvEZ8928i/NW9TPfSWTCT+wirMaoY482a?=
 =?us-ascii?Q?+LEXeXiY8AIHydSWfIqiOUA2K1fSmayAXzkKS5SG4Ty62SfChstv4C/iMnFo?=
 =?us-ascii?Q?GvW1+18fEug8OGPFLWkXlN9/cwUPw5V1PDftI/eSmSmBd7PVbCjjupuT4uTK?=
 =?us-ascii?Q?g4iYUUdyqY4U8LgRZdsGVXhVFeCKF4L54MyyzAUM6bv/63nQKOODzOMYYdBh?=
 =?us-ascii?Q?NOf/7pFkFo/1BXcE9yw5NAC3GjUWpjuxyzHnMR7nnAinw8H2WW5lZI1hT8lE?=
 =?us-ascii?Q?BvQAT4fTe53eCftq3OFBxVmzh6Nt1t6xzxvlQlgpYP1lV2I1xaa45xMGEE3a?=
 =?us-ascii?Q?rmhzKRMO65Y6fksc6/98vdjMvNo4ZSWUL+9+obxGdsANcv3Y0y1oVOlvYuJo?=
 =?us-ascii?Q?Yt37M77GnPgp8iQfS9iQ+rxFExwoaOl5ceyf+j2PJbCOdwZVmXXS09ajcxap?=
 =?us-ascii?Q?7A/AKbx7OqsyzxU0AJ84VO+hyydkiINLYvMyTQ4n6piKu0RiUvM89HBXHArr?=
 =?us-ascii?Q?rrjHnTiROk68rtgeLWjdNCPEphw84OFnvF7Mb1BQ4+Ofw/Fl48JT2vNK1op+?=
 =?us-ascii?Q?wSxTcKSx9RI7G31yI0mTZ85glB8XfBd2cwFr1J1h?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 331be740-6006-4157-8302-08dafaebf280
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2023 13:40:52.0206
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HnugIPF/2l2ForYzuwyAbeFYkPA5WRhDBlCOnGVqKw/Fh4EuligokRvTZT7z093Jgv89fF/l/CEg7LhRWo0Tdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5127
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Disallow the value set beyond the range, and disallow to change
the value in lfs mode.

BTW, convert open code to use BIT().

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 fs/f2fs/segment.h |  1 +
 fs/f2fs/sysfs.c   | 11 ++++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
index 0b0eb8f03cba..d73e988566a5 100644
--- a/fs/f2fs/segment.h
+++ b/fs/f2fs/segment.h
@@ -681,6 +681,7 @@ enum {
 	F2FS_IPU_ASYNC,
 	F2FS_IPU_NOCACHE,
 	F2FS_IPU_HONOR_OPU_WRITE,
+	F2FS_IPU_MAX,
 };
 
 #define F2FS_IPU_POLICY(name)					\
diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
index bdc761f36310..576e6416ffb9 100644
--- a/fs/f2fs/sysfs.c
+++ b/fs/f2fs/sysfs.c
@@ -452,7 +452,7 @@ static ssize_t __sbi_store(struct f2fs_attr *a,
 	if (ret < 0)
 		return ret;
 #ifdef CONFIG_F2FS_FAULT_INJECTION
-	if (a->struct_type == FAULT_INFO_TYPE && t >= (1 << FAULT_MAX))
+	if (a->struct_type == FAULT_INFO_TYPE && t >= BIT(FAULT_MAX))
 		return -EINVAL;
 	if (a->struct_type == FAULT_INFO_RATE && t >= UINT_MAX)
 		return -EINVAL;
@@ -706,6 +706,15 @@ static ssize_t __sbi_store(struct f2fs_attr *a,
 		return count;
 	}
 
+	if (!strcmp(a->attr.name, "ipu_policy")) {
+		if (F2FS_OPTION(sbi).fs_mode == FS_MODE_LFS)
+			return -EINVAL;
+		if (t >= BIT(F2FS_IPU_MAX))
+			return -EINVAL;
+		SM_I(sbi)->ipu_policy = (unsigned int)t;
+		return count;
+	}
+
 	*ui = (unsigned int)t;
 
 	return count;
-- 
2.25.1