Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Paulo Alcantara <pc@cjr.nz>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Steve French <stfrench@microsoft.com>,
        linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
        linux-kernel@vger.kernel.org
Cc:     Steve French <sfrench@samba.org>,
        Ronnie Sahlberg <lsahlber@redhat.com>,
        Shyam Prasad N <sprasad@microsoft.com>,
        Tom Talpey <tom@talpey.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v1 1/1] cifs: Get rid of unneeded conditional in the
 smb2_get_aead_req()
In-Reply-To: <20230120120857.60444-1-andriy.shevchenko@linux.intel.com>
References: <20230120120857.60444-1-andriy.shevchenko@linux.intel.com>
Date:   Fri, 20 Jan 2023 11:21:01 -0300
Message-ID: <87r0vpe182.fsf@cjr.nz>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:

> In the smb2_get_aead_req() the skip variable is used only for
> the very first iteration of the two nested loops, which means
> it's basically in invariant to those loops. Hence, instead of
> using conditional on each iteration, unconditionally assing
> the 'skip' variable before the loops and at the end of the
> inner loop.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  fs/cifs/smb2ops.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)

Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>