Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-85-gd6d859e0cf-fm-20230116.001-gd6d859e0
Mime-Version: 1.0
Message-Id: <9965e2d1-bae8-4ce7-911c-783c772e9ff1@app.fastmail.com>
In-Reply-To: <20230120145316.GA4155@tellis.lin.mbt.kalray.eu>
References: <20230120141002.2442-1-ysionneau@kalray.eu>
 <20230120141002.2442-10-ysionneau@kalray.eu>
 <aa4d68b2-b5b5-4c17-a44f-7c6db443ea4c@app.fastmail.com>
 <20230120145316.GA4155@tellis.lin.mbt.kalray.eu>
Date:   Fri, 20 Jan 2023 16:01:11 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Jules Maselbas" <jmaselbas@kalray.eu>
Cc:     "Yann Sionneau" <ysionneau@kalray.eu>,
        "Jonathan Corbet" <corbet@lwn.net>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        "Marc Zyngier" <maz@kernel.org>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        "Will Deacon" <will@kernel.org>,
        "Peter Zijlstra" <peterz@infradead.org>,
        "Boqun Feng" <boqun.feng@gmail.com>,
        "Mark Rutland" <mark.rutland@arm.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        "Kees Cook" <keescook@chromium.org>,
        "Oleg Nesterov" <oleg@redhat.com>,
        "Ingo Molnar" <mingo@redhat.com>,
        "Waiman Long" <longman@redhat.com>,
        "Aneesh Kumar" <aneesh.kumar@linux.ibm.com>,
        "Andrew Morton" <akpm@linux-foundation.org>,
        "Nicholas Piggin" <npiggin@gmail.com>,
        "Paul Moore" <paul@paul-moore.com>,
        "Eric Paris" <eparis@redhat.com>,
        "Christian Brauner" <brauner@kernel.org>,
        "Paul Walmsley" <paul.walmsley@sifive.com>,
        "Palmer Dabbelt" <palmer@dabbelt.com>,
        "Albert Ou" <aou@eecs.berkeley.edu>,
        "Guillaume Thouvenin" <gthouvenin@kalray.eu>,
        "Clement Leger" <clement@clement-leger.fr>,
        "Vincent Chardon" <vincent.chardon@elsys-design.com>,
        =?UTF-8?Q?Marc_Poulhi=C3=A8s?= <dkm@kataplop.net>,
        "Julian Vetter" <jvetter@kalray.eu>,
        "Samuel Jones" <sjones@kalray.eu>,
        "Ashley Lesdalons" <alesdalons@kalray.eu>,
        "Thomas Costis" <tcostis@kalray.eu>,
        "Marius Gligor" <mgligor@kalray.eu>,
        "Jonathan Borne" <jborne@kalray.eu>,
        "Julien Villette" <jvillette@kalray.eu>,
        "Luc Michel" <lmichel@kalray.eu>,
        "Louis Morhet" <lmorhet@kalray.eu>,
        "Julien Hascoet" <jhascoet@kalray.eu>,
        "Jean-Christophe Pince" <jcpince@gmail.com>,
        "Guillaume Missonnier" <gmissonnier@kalray.eu>,
        "Alex Michon" <amichon@kalray.eu>,
        "Huacai Chen" <chenhuacai@kernel.org>,
        "WANG Xuerui" <git@xen0n.name>,
        "Shaokun Zhang" <zhangshaokun@hisilicon.com>,
        "John Garry" <john.garry@huawei.com>,
        "Guangbin Huang" <huangguangbin2@huawei.com>,
        "Bharat Bhushan" <bbhushan2@marvell.com>,
        "Bibo Mao" <maobibo@loongson.cn>,
        "Atish Patra" <atishp@atishpatra.org>,
        "Jason A . Donenfeld" <Jason@zx2c4.com>,
        "Qi Liu" <liuqi115@huawei.com>,
        "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
        "Catalin Marinas" <catalin.marinas@arm.com>,
        "Mark Brown" <broonie@kernel.org>,
        "Janosch Frank" <frankja@linux.ibm.com>,
        "Alexey Dobriyan" <adobriyan@gmail.com>,
        "Benjamin Mugnier" <mugnier.benjamin@gmail.com>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-mm@kvack.org,
        Linux-Arch <linux-arch@vger.kernel.org>, linux-audit@redhat.com,
        linux-riscv@lists.infradead.org, bpf@vger.kernel.org
Subject: Re: [RFC PATCH v2 09/31] kvx: Add build infrastructure
Content-Type: text/plain
Precedence: bulk

On Fri, Jan 20, 2023, at 15:53, Jules Maselbas wrote:
> On Fri, Jan 20, 2023 at 03:39:22PM +0100, Arnd Bergmann wrote:
>> On Fri, Jan 20, 2023, at 15:09, Yann Sionneau wrote:
>> >      - Fix clean target raising an error from gcc (LIBGCC)
>> 
>> I had not noticed this on v1 but:
>> 
>> > +# Link with libgcc to get __div* builtins.
>> > +LIBGCC	:= $(shell $(CC) $(DEFAULT_OPTS) --print-libgcc-file-name)
>> 
>> It's better to copy the bits of libgcc that you actually need
>> than to include the whole thing. The kernel is in a weird
> It was initialy using KCONFIG_CFLAGS which do not contains valid options
> when invoking the clean target.
>
> I am not exactly sure what's needed by gcc for --print-libgcc-file-name,
> my guess is that only the -march option matters, I will double check
> internally with compiler peoples.
>
>> state that is neither freestanding nor the normal libc based
>> environment, so we generally want full control over what is
>> used. This is particularly important for 32-bit architectures
>> that do not want the 64-bit division, but there are probably
>> enough other cases as well.

To clarify: I meant you should not include libgcc.a at all but
add the minimum set of required files as arch/kvx/lib/*.S.

     Arnd