Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp2862900rwb; Fri, 20 Jan 2023 08:14:19 -0800 (PST) X-Google-Smtp-Source: AMrXdXvtj7aTavlfsDwvrpdZjBavcr0k8GZSSmRjRC4NDt0KyMx8lO1pLF48h6C3W+/KliT8LBQM X-Received: by 2002:a17:906:2787:b0:86e:bbdf:95b8 with SMTP id j7-20020a170906278700b0086ebbdf95b8mr15660537ejc.46.1674231259731; Fri, 20 Jan 2023 08:14:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674231259; cv=none; d=google.com; s=arc-20160816; b=0BaXRhCZIwlxsJFP5YGB3G4w0bJuF+nceTpRQOQotNbWT8slIH0OyPzmmYbrQ1qEfU yJrG2+RTChb2xriaVDc0U7XM2AQdgoKvm8kBChZlT4WzToSch0b7+d1gYc4Gv7LIZn7m vFLUAuNe4s+w7+zxxgbKTnqC5XGObKnYbegbtXWHEXwJsiP9kMa3Ibhme6M92T8BrChY DTFZyxVODlFOWmw4/fpia0luonxOJ1/pRYt6kg6IwyqRhsBWoIWEpiQSlI0A1PpAnm0F J279SGLnhHQoKunomcYQkRcGCD6nmpdpYZ85GeVoYhJplgObL0ZZ7Ls2/cly81Xt4g1X wkDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=WWZZyEASnVJeDNF1yNLqxhUJXWQQRy8pnWrzIYnrXKE=; b=FfQULrbndtHfT3TGBpFfU0J8ggq/eQD/O3gdqIkuPO4nJXHeHgEEBn9LDpelpUXfv2 b7/AUAP/ogax4eVESQnIa5wa5TJXYfyhL7RuvQvOc6s7nCBN3OyUvsY7FHIutl9XM4EH 4LqnLFPE4dG4IO6YbNhT9JEIjsJUzPrZTtVuWPNtqmwIzSfvSvk2T/GHGAPrp5pIiuhZ smMEIjdV+jT0byY6X0PtjmLv0F5JnnpVWocb2QdkWkNYLmaluacNbfJwPyaKb4+dGqW8 0mfKE5qUsldzgn9yea7jU9caxkVtHG4zcs+hgipOaHuB4oDQsyuo5pADji7/Ggia6UfX takA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=v2V3ahcw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mp16-20020a1709071b1000b007ae86742c37si19707931ejc.60.2023.01.20.08.14.06; Fri, 20 Jan 2023 08:14:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=v2V3ahcw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230356AbjATPlF (ORCPT + 50 others); Fri, 20 Jan 2023 10:41:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229723AbjATPlD (ORCPT ); Fri, 20 Jan 2023 10:41:03 -0500 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D464180BB6 for ; Fri, 20 Jan 2023 07:40:45 -0800 (PST) Received: by mail-il1-x12e.google.com with SMTP id m15so2882801ilq.2 for ; Fri, 20 Jan 2023 07:40:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WWZZyEASnVJeDNF1yNLqxhUJXWQQRy8pnWrzIYnrXKE=; b=v2V3ahcwOyuebwYuu9dRu7UT8QxS8g94SXGFFKxIyCBqAbk2llyobeFPWj5Awzp1qK hyFTDrKlLj0HTzsuVN0Ycdxcns3gvZ7iqlYGkwPE2i5qvSixBE4o0cfm+EEi1B5j0JK6 ri82Hp2zJUo/yb/sbEGQLhndTz2ilFTLxLp4O1EpOrAyXL/ALrRKupl+oJM1y3NRFE9w uKjWYSkQL4ktfGdUg9UY01GzXNAu42C2JMxhoW87zWGYXh3QEyHSrhPd46XOC8A+z9GY eDuwuA9oIBHqazOS+DFeQff3wzNLoBTwTZ+LeSOqKS9M1AVp0XJ8FxZuFv7tDnv25Sqq 3nSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WWZZyEASnVJeDNF1yNLqxhUJXWQQRy8pnWrzIYnrXKE=; b=LABQc/E8IgOC6BwS1liPoNlVxGaN31YTuXnispMn5P/Q6nNzczJjJH6+gPb7Msa4Nk nGuWRQaaUh9yFkFGRjl00uN32nSxbhzPygAhBaozwcduenq0o+vruXEwjb4i+ebnw/6L ML7kkbm6GnBrKDj2hbuNBygWq+vERuvyvcAL7eG2VDQovDlBAo47AqMhdehY2QQpLXAn bQKXqQbyTTRpXrNT1W2mlRUWrp6DzruWRv6/u6QMGA9qGb7C3V4U17N6IhX2CfLSVXbC 5Redg3Sl/WmOYFuiDc5sACvTx/bW+SvSMCU//4C+s9yXQaAZfqMXVo0E9e+2te1PB+R2 EbKQ== X-Gm-Message-State: AFqh2kp5U/zGkRriAcMi+LJtCM7PEVsT5BUs090lt++dm6V4YDElJ0ba 7APhq5RTFyS2a8BTd7RsMTPlo5KSMqaol+zv X-Received: by 2002:a92:c5d1:0:b0:30d:9eea:e51 with SMTP id s17-20020a92c5d1000000b0030d9eea0e51mr2273147ilt.1.1674229245097; Fri, 20 Jan 2023 07:40:45 -0800 (PST) Received: from [127.0.0.1] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id b11-20020a02a58b000000b003a60e5a2638sm1886075jam.94.2023.01.20.07.40.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jan 2023 07:40:44 -0800 (PST) From: Jens Axboe To: tj@kernel.org, josef@toxicpanda.com, Yu Kuai Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com In-Reply-To: <20230117070806.3857142-1-yukuai1@huaweicloud.com> References: <20230117070806.3857142-1-yukuai1@huaweicloud.com> Subject: Re: [PATCH v4 0/5] blk-iocost: random bugfix Message-Id: <167422924424.669768.14436700036484270833.b4-ty@kernel.dk> Date: Fri, 20 Jan 2023 08:40:44 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12-dev-78c63 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Jan 2023 15:08:01 +0800, Yu Kuai wrote: > changes in v4: > - a litter code optimization to make it easier to understand in patch > 4. > > changes in v3: > - move some patches into separate patchset > - don't return other error number for match_u64() in patch 1 > - instead of checking user input separately, set page directly if > 'bps + IOC_PAGE_SIZE' will overflow. > > [...] Applied, thanks! [1/5] blk-iocost: check return value of match_u64() commit: 7b6a2c89052bfaf750260691dee29c2e457c0929 [2/5] blk-iocost: don't allow to configure bio based device commit: 204a9e1eeb4b72cd260274f14e521162b130a978 [3/5] blk-iocost: read params inside lock in sysfs apis commit: 7b810b50390b53c2a81051adce8fcbff3200fc74 [4/5] blk-iocost: fix divide by 0 error in calc_lcoefs() commit: 4e952a32301a77faea0d36c540ae16847cf2a8ee [5/5] blk-iocost: change div64_u64 to DIV64_U64_ROUND_UP in ioc_refresh_params() commit: ad5572498be17b800e75bc36f7d810dd3b673802 Best regards, -- Jens Axboe