Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp2886453rwb; Fri, 20 Jan 2023 08:30:36 -0800 (PST) X-Google-Smtp-Source: AMrXdXvdAWcJze572WniI5gRCDfa+UlEpCphYx4vpfZo9+ZH4OK3wuw8/J1lzbOXfI37MKEOcDP2 X-Received: by 2002:a17:906:4d89:b0:86f:57d3:e3a7 with SMTP id s9-20020a1709064d8900b0086f57d3e3a7mr14817884eju.48.1674232236038; Fri, 20 Jan 2023 08:30:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674232236; cv=none; d=google.com; s=arc-20160816; b=PB/A06xlIXMmtUblp/0czdmn+8chEXv0Wu3omj5OGJ+TvAeTzjfu1teKvkimbHltz3 6gmYWp2zSMf3/85VYnLlTRlWXuttbLxJv/DQUiM5+igiIPFaNC+t5BCJpJqZV/Re+BC7 kHM2lHvJU/U6p915RNFBJK9lu7f46j56NzecDWUqTrj+vSrUmQGxW7MyUGBMxmiq6AhX zqH2Q/kXppiiu9bi8AeYscG2tBZjZ50UT9rbw0QHLjhdThd6k7kfQFsJMKzF9x4iCM+P cYsOgmbI4FixXxjtO+6zTHr1RWx1N0Xj5Rk1MVoXXKDiymBc4zjbi96SIG7w0F5I/6Om Gs9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=zsldfkqGG+7Cljy7c/H58EAzw+tnuAFFiJ3pu4picU0=; b=KClbMtw5W4zJl7y3d4Nt7mkTnugaIq708ZjUpwSrvL/fJbuDcaCScHY8wkXQ/zrTj0 gv0MaI3jNfv4DUFbOUO18FUhmGJcaDJLJiIs81GM272otwnX8TO7amWOnXILCPb2MkMP gfRkwtzcDkk8qXx6BYVKNADVGvYXlQFAGvnDvoPZ2xDYCqOV2TCP1C8pHENRqh7WdJ6Z BMY69u0KT5rmBGmLNFUxHOdAziOkwQtKcESwYwaqNJ027q4xEJxIr3feem9/HFNSM7Zc l3VdPkkOw9NBnDUVZRajfG0jdw3TEgNDofFZbVGvsletpLrm7dz2zFb4lxWTCjb+2o1p Y8KQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HJOXrB9M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xd9-20020a170907078900b007c16107b16bsi33593201ejb.432.2023.01.20.08.30.23; Fri, 20 Jan 2023 08:30:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HJOXrB9M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229558AbjATQTl (ORCPT + 50 others); Fri, 20 Jan 2023 11:19:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjATQTk (ORCPT ); Fri, 20 Jan 2023 11:19:40 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62ED54490 for ; Fri, 20 Jan 2023 08:19:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674231579; x=1705767579; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=6tstgeiA8M5RCL6APE+7P6EVA/i1StlatlS96Xt6uqc=; b=HJOXrB9MO8RNUYA8pDZPN+Fha+0CN/V3ai8fFRMoc+Y//rIc2cxc4B/U punJs5cR4CQNdrbU6RCUazyfKK6n2tn6uXO2zN1dS6xvOR/09NSRFlKxB Lzhs1t1i0CyOVmkHTe9jZkUwdkzdDeXbvvxvi4JJErPex4+u6fOPG3Fsc gBI0q0cjS1jEG2VJfnNxlQTDoVUSzsM7zARzR72OesmaTEUWWyUZ7VFB6 U9YArlKNcrv50rf6/yTliA/w55y3mrf2m4YNa741VTZPTq1f1BTGYut9c rNkmPYtwG/2ZERApzriJ49jFJTlmk1aTPqxcnWQKhqiFX2GPww+AcAB1i Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10596"; a="411846544" X-IronPort-AV: E=Sophos;i="5.97,232,1669104000"; d="scan'208";a="411846544" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2023 08:19:37 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10596"; a="653836362" X-IronPort-AV: E=Sophos;i="5.97,232,1669104000"; d="scan'208";a="653836362" Received: from araj-ucode.jf.intel.com ([10.23.0.19]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2023 08:19:37 -0800 From: Ashok Raj To: Boris Petkov , Thomas Gleixner Cc: Ashok Raj , LKML , x86 , Ingo Molnar , Tony Luck , Dave Hansen , Alison Schofield , Reinette Chatre , Tom Lendacky , Stefan Talpalaru , David Woodhouse , Benjamin Herrenschmidt , Jonathan Corbet , "Rafael J . Wysocki" , Peter Zilstra , Andy Lutomirski , Andrew Cooper , Boris Ostrovsky Subject: [Patch v5 0/5] Some fixes and cleanups for microcode Date: Fri, 20 Jan 2023 08:19:18 -0800 Message-Id: <20230120161923.118882-1-ashok.raj@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, Here is a followup after v4[1] with all comments addressed. Please review and apply. Changes since v4[1]: Boris: - Fix compile errors for 32bit. - Drop last patch that displays loading failure during early load. Changes since v3[2]: Tony, Ingo - Display clear message when microcode load fails. Boris - Changed function names microcode_store_cpu_caps() -> store_cpu_caps(). - Fix commit logs - Document new parameter to microcode_check() Dave Hansen - Fix commit log - Change parameter names from generic to something that's meaningful. [1] https://lore.kernel.org/lkml/20230109153555.4986-1-ashok.raj@intel.com/ [2] https://lore.kernel.org/lkml/20230103180212.333496-1-ashok.raj@intel.com/ Ashok Raj (5): x86/microcode: Add a parameter to microcode_check() to store CPU capabilities x86/microcode/core: Take a snapshot before and after applying microcode x86/microcode: Display revisions only when update is successful x86/microcode/intel: Use a plain revision argument for print_ucode_rev() x86/microcode/intel: Print old and new rev during early boot arch/x86/include/asm/processor.h | 3 +- arch/x86/kernel/cpu/common.c | 48 +++++++++++++++++++-------- arch/x86/kernel/cpu/microcode/core.c | 20 ++++++++--- arch/x86/kernel/cpu/microcode/intel.c | 41 +++++++++-------------- 4 files changed, 69 insertions(+), 43 deletions(-) base-commit: 5dc4c995db9eb45f6373a956eb1f69460e69e6d4 Cc: LKML Cc: x86 Cc: Ingo Molnar Cc: Tony Luck Cc: Dave Hansen Cc: Alison Schofield Cc: Reinette Chatre Cc: Thomas Gleixner (Intel) Cc: Tom Lendacky Cc: Stefan Talpalaru Cc: David Woodhouse Cc: Benjamin Herrenschmidt Cc: Jonathan Corbet Cc: Rafael J. Wysocki Cc: Peter Zilstra (Intel) Cc: Andy Lutomirski Cc: Andrew Cooper Cc: Boris Ostrovsky -- 2.34.1