Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230112052453.3365-1-kunyu@nfschina.com>
In-Reply-To: <20230112052453.3365-1-kunyu@nfschina.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Fri, 20 Jan 2023 17:45:59 +0100
Message-ID: <CAJZ5v0gunKQKOtMz4wOWAkyn1_Q5fGFtyqOWd7Y7=FedWAJikw@mail.gmail.com>
Subject: Re: [PATCH] power: hibernate: optimize function structure
To:     Li kunyu <kunyu@nfschina.com>
Cc:     rafael@kernel.org, pavel@ucw.cz, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        x86@kernel.org, hpa@zytor.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 12, 2023 at 6:25 AM Li kunyu <kunyu@nfschina.com> wrote:
>
> The goto statement jump is not required at the end of the if statement
> block, because it will be executed to the lower part of the goto
> statement.
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>

The patch itself is OK, but its subject should be something like "PM:
hibernate: x86: Drop unneeded goto statement from arch_resume_nosmt()"
and the changelog should be more precise, for example:

"The last goto statement in arch_resume_nosmt() is not necessary,
because the target label is right next to it."

Please update.

> ---
>  arch/x86/power/hibernate.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/power/hibernate.c b/arch/x86/power/hibernate.c
> index 6f955eb1e163..936558c4e821 100644
> --- a/arch/x86/power/hibernate.c
> +++ b/arch/x86/power/hibernate.c
> @@ -210,8 +210,6 @@ int arch_resume_nosmt(void)
>                 if (ret)
>                         goto out;
>                 ret = cpuhp_smt_disable(old);
> -               if (ret)
> -                       goto out;
>         }
>  out:
>         cpu_hotplug_disable();
> --
> 2.18.2
>