Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp2990896rwb; Fri, 20 Jan 2023 09:45:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXu0WpJlmoN7hyWjIDKJjIqk/HLO8ieffciChe8eYl8MWaF1OO9vY6/24Sr5nPzU5M2atRHC X-Received: by 2002:a17:90a:7884:b0:228:edc5:24c9 with SMTP id x4-20020a17090a788400b00228edc524c9mr16092858pjk.6.1674236740294; Fri, 20 Jan 2023 09:45:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674236740; cv=none; d=google.com; s=arc-20160816; b=OJL0f5A4NQKXLd3UYrJqcai7GC5G7CaVjB4fB3bmKYFFhrBFKTQWpu8cft5EQBi//w iru3TtZJW2NRUijAkXDMvKjYZqGkkHmmo5uMPtHkSQABQNYCCaybDAjXCZ+H1gH3/KQ/ IOA+IdFk3fxaPidjZlGG37BUpIU9bQX3MvAdlXgHsbv2xw+ZwexeQ7QK22F8l2XHHFya oQskf3TpuVZc0Yao5S2w8HTqKwzSk9V0Wr66Uq8qUhX56jwXsszwvsKxCA1THEEC5SPn 0dBqBOYCg5mHrsR2fmAgNCavjxZTRShhj6WSTWuN88FA9b3eFSSavMe16wZh5TGzvcEx WU6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=ReqL3/KdTtoMI5gOn47wEfy8Brch/hDuTRzHxmxqXLI=; b=piO3WuM3WTcAAntxW4wup9i5GsaNP3VZ16+pONmHGe41KyxfYS5s5/MS0bfWXaHcb+ 7muJSOVyt+ZIK5FKE9heRoUpFRUtPOk2+nPV+qV4km8eJYiHMSn78EnudfESBlrv3W5M NjIPrBw7Lo17mm0jYApKB+h/LiZR9EL03cY6utkvNQW2Fzr3yW0NvgesnciGSeUzzgIs UXKvIi72w+Gucb/SIkAmfQ5ZGSfhJDiOQykRTBaUYrzw5obzz9gMv8aQP+4hkrhWPHyp 6/SyMiF4PCZqRMnxBAzydnPzPe8nkRIS0abQLIVXpYTR/9L8oFyIGL9vz+WRNJ9dmD1w akSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HrWAbzIu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d32-20020a17090a6f2300b002291890533esi2965255pjk.114.2023.01.20.09.45.33; Fri, 20 Jan 2023 09:45:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HrWAbzIu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230500AbjATQto (ORCPT + 50 others); Fri, 20 Jan 2023 11:49:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229840AbjATQtm (ORCPT ); Fri, 20 Jan 2023 11:49:42 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B05314EE5 for ; Fri, 20 Jan 2023 08:49:41 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id bk16so5355580wrb.11 for ; Fri, 20 Jan 2023 08:49:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ReqL3/KdTtoMI5gOn47wEfy8Brch/hDuTRzHxmxqXLI=; b=HrWAbzIu1bfu5+Ce6Jw2FEMPVasYO23fFdoUKI+s2D5dbd/iFNqYGuO1NWjYcusFKy fP9liXt78VZOHABtZOIYTAWWAAwkkrz7GVp/N10X76oFvPrJmDlHk+4Fgwv8rjCKwuus tFouDnkYAVUa4IIcvCYAQxzY/2uIqD/2hPonHIq4+yuN/6kQgGsnpArb/o55+WXIgbEB tRn0xd4tH8ozAowgLV/G7pe9Hr7HEcWabeLEvmDCDJNMCpwGvWH2rIokvMONX8B9UE5M pQuSJnDvLsfG3xLeUvaKGtLV2rDhWCWwojOJBeUj/zyGuO6T4FPiweqaOlj1sZm9tP9y mvEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ReqL3/KdTtoMI5gOn47wEfy8Brch/hDuTRzHxmxqXLI=; b=GrEa7MBqZgSXYHIqFZELC9sAx3KP3OOo0Dv22yykXYA4+zwoNXPKZuyxbd0iVmBTAe p9Oe7ReJC6CS31cFTt1nkugNpr7cYlx5hMrwZH4hJoTmZhqkl0pJH80ocGRykiRrFMAP SOrtF6bolITvQxoVQYq7ziaEr7lGqS1CFZWU/FMxglTqkEjM9xB26M8BjnJR0Os3j3h3 29ah5C+hyUAmkyLuLthCETjxNqNMP7a/2r8Sq1Dq2cDTIWZprHxqOWiO6rMNJYZLCKOG y5J5B/n3dS35F8yyr/JQNJ9JrXMpOfcsn3qh2FB6ltEXfPLjFm1meqv+NbilDa97f5s6 Aefw== X-Gm-Message-State: AFqh2koQwCVCb8vOZq/wPoYdqwZXlIMOG/Bul4Fy/nBuuu4AqsrJJ047 T/Rdx6uS0EEhEjhL852KwdOM9Q== X-Received: by 2002:a5d:4e84:0:b0:2be:c94c:ebff with SMTP id e4-20020a5d4e84000000b002bec94cebffmr1852291wru.56.1674233380271; Fri, 20 Jan 2023 08:49:40 -0800 (PST) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id y18-20020a5d6152000000b002425be3c9e2sm35581781wrt.60.2023.01.20.08.49.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Jan 2023 08:49:39 -0800 (PST) Message-ID: Date: Fri, 20 Jan 2023 16:49:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: sm6350: Add camera clock controller Content-Language: en-US To: Luca Weiss , Andy Gross , Bjorn Andersson , Konrad Dybcio , Loic Poulain , Robert Foss , Rob Herring , Krzysztof Kozlowski Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221213-sm6350-cci-v2-0-15c2c14c34bb@fairphone.com> <20221213-sm6350-cci-v2-2-15c2c14c34bb@fairphone.com> From: Bryan O'Donoghue In-Reply-To: <20221213-sm6350-cci-v2-2-15c2c14c34bb@fairphone.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/01/2023 13:13, Luca Weiss wrote: > + camcc: clock-controller@ad00000 { > + compatible = "qcom,sm6350-camcc"; > + reg = <0 0x0ad00000 0 0x16000>; > + clocks = <&rpmhcc RPMH_CXO_CLK>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + #power-domain-cells = <1>; > + }; Should you include required-opps = <&rpmhpd_opp_low_svs>; ? --- bod