Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp2996369rwb; Fri, 20 Jan 2023 09:50:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXuYd8O/Yt+BCUCrt54E/4wpOTfYmWl26ed86gn+xWuQwLQBdo12lTD3Ih64+FdFNCZ//bRn X-Received: by 2002:a17:902:ab8f:b0:193:1952:5a45 with SMTP id f15-20020a170902ab8f00b0019319525a45mr16252619plr.19.1674237014088; Fri, 20 Jan 2023 09:50:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674237014; cv=none; d=google.com; s=arc-20160816; b=QI+trl8ScHH46CLf4dYpYoNk0AUn4RXtu1bzxbhDzwiTRclrw55vdpP3Vj2m9zbu6+ Sz0uNDNw7gL9l/QtZrtSVZFLsapNU4LG2JYl6COV2qvFP5WUw7TNTColaIimA7Dj0P08 N/Ax4qOx9jGovl4wV6kruHBax6wTXOZcaaDl7wWVR8DraGY71Q86FcWgLlrxjUPUqJci G1xNh0ryKpYZOaS4Au95rQ7SdcPj6cUZ//dHB21YsH4GaCkxM0nZKMzy7iiLli/dFDSy bvRLfQgFRtR2NiLqF8RD9hcZLXG45kx2hfSikl3NnJt7N9qCiNBJ62ViyCHgsPW8wXIx yPnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=H13BNLRK8D73Qt1gU+Vxj70WqHOnnOjorB09VPCtjdE=; b=YzgmL0YQ5zPGwGfSGwpngLNDbJg8AEyOHyIQdbCMbu4hRqI24EDz5nv/NtT/dkijA4 +pZkeOK8KXet4rzMdaqH0SES+y6ptQDNNQHVllz+u3m6cJG7+dtkzhwHNtGDLIU1o7Dj 9D5vb+3QsXy0ETs/2lVSVAJapnk6/mQCk9cddrg4pWvtrhhBcrd/UDBlTOdw5K2tXsfd wkfGDzk2uCeojh7ZH+w2Vg3qEkbhzYeF2jj9ZwVy1OXhOSRnAINt/8IwDsH38i2WjGiG RVEENxhxxFSawGPwd+cjlSJeKNME96S7HdcYuAikceBJU2CU65018CMdt8tPVmf39Bx6 /YoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y62-20020a638a41000000b004d32d43a7fbsi2906409pgd.15.2023.01.20.09.50.07; Fri, 20 Jan 2023 09:50:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229489AbjATQ5O (ORCPT + 50 others); Fri, 20 Jan 2023 11:57:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbjATQ5N (ORCPT ); Fri, 20 Jan 2023 11:57:13 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BFC97B2D2 for ; Fri, 20 Jan 2023 08:56:51 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 344DAB82940 for ; Fri, 20 Jan 2023 16:56:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27B1DC433D2; Fri, 20 Jan 2023 16:56:47 +0000 (UTC) Date: Fri, 20 Jan 2023 16:56:44 +0000 From: Catalin Marinas To: Krzysztof Kozlowski Cc: Mohan Kumar D , will@kernel.org, dmitry.baryshkov@linaro.org, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, treding@nvidia.com, jonathanh@nvidia.com Subject: Re: [PATCH v2] arm64: defconfig: Enable HDA INTEL config for ARM64 Message-ID: References: <20230117181658.17010-1-mkumard@nvidia.com> <1afa38ad-716f-49f8-efd1-ed37bd8dbf6e@nvidia.com> <35eb1396-b91b-8a7f-6585-30d2f2adcf85@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 20, 2023 at 07:20:01AM +0100, Krzysztof Kozlowski wrote: > On 20/01/2023 06:48, Mohan Kumar D wrote: > > On 18-01-2023 18:06, Krzysztof Kozlowski wrote: > >> External email: Use caution opening links or attachments > >> On 18/01/2023 12:46, Mohan Kumar D wrote: > >>> On 18-01-2023 13:04, Krzysztof Kozlowski wrote: > >>>> External email: Use caution opening links or attachments > >>>> On 17/01/2023 19:16, Mohan Kumar wrote: > >>>>> Enable CONFIG_SND_HDA_INTEL for NVIDIA PCI based graphics sound card for > >>>>> ARM64 based platforms as Intel PCI driver was used for registering the > >>>>> sound card. > >>>> It's not a part of SoC, not a common device used during debugging or > >>>> development, so I don't think it is reasonable to enable it. We do not > >>>> enable driver just because someone uses them. Otherwise please clarify > >>>> which board has this device embedded (not pluggable by user, but embedded). > >>> This change is required for enabling HDA sound registration for Nvidia > >>> discrete GPU cards based on PCI and pluggable to Nvidia Jetson Platforms. > >> You can plug anything to PCI slot and we do not enable every such PCI > >> adapter. > > Without this config enabled, the Intel hda audio driver won't be built > > and dGPU won't be able to register sound card. Do you have any > > suggestion here? > > Without hundreds of other drivers they also won't be built and won't be > usable. Anyway, this is just defconfig, so it does not matter. You can > always enable it in your setup, why is this a problem? > > Again, we do not enable drivers for every PCI card. I don't think we have any set rules for what goes in a defconfig. If one has a real use-case, we tend to enable stuff in defconfig, especially if it's a module. -- Catalin