Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Tanmay Jagdale <tanmay@marvell.com>
To:     James Clark <james.clark@arm.com>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
        "leo.yan@linaro.org" <leo.yan@linaro.org>,
        "mike.leach@linaro.org" <mike.leach@linaro.org>
CC:     Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        George Cherian <gcherian@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Bharat Bhushan <bbhushan2@marvell.com>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        John Garry <john.g.garry@oracle.com>,
        Will Deacon <will@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        "coresight@lists.linaro.org" <coresight@lists.linaro.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 0/8] perf cs_etm: Basic support for virtual/kernel
 timestamps
Thread-Topic: [PATCH v5 0/8] perf cs_etm: Basic support for virtual/kernel
 timestamps
Thread-Index: AQHZLPbWmCAToFxcOEGnB59qOKa3yg==
Date:   Fri, 20 Jan 2023 17:44:24 +0000
Message-ID: <PH0PR18MB50177B0B9AA2578C7F95243ED6C59@PH0PR18MB5017.namprd18.prod.outlook.com>
References: <20230120143702.4035046-1-james.clark@arm.com>
In-Reply-To: <20230120143702.4035046-1-james.clark@arm.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WQJ1zezNVOcKng1Pjeuq4ELw4jBwOXYR8IClvHv1guIuTTAMOR525rgXCEu4?=
 =?us-ascii?Q?D8vC8DoLESsX1jo0EfvyCZMxwrnW8BJ+68qXC1hIDDrzPd2gvm3cBYeMqsRN?=
 =?us-ascii?Q?IIQaYV/ZWXVCVXEH038jr60eJV0SiVE6x6CWtncVTHrfzZ/pflphqHSqew0W?=
 =?us-ascii?Q?2X7alb6eX2xIz12xoqTR5ygUsswiV4rv0N5BqPb9S/lRUE5/7I3l74WkVmUo?=
 =?us-ascii?Q?cUOFrwu40myqDWLV7Bzo0HeXqZ2Q5rtuVBwRp2G3ikHzBi7H87QSXtVQDU5D?=
 =?us-ascii?Q?Py8H22khrjbySTTaadjBbfGGnb9NHu6OhQtaV245ljKny6xaAWyvF9fZoPwc?=
 =?us-ascii?Q?g4jPji1PwjWsI6R34Ble1SAYLLfH6aIxeuvAPiaNL+iFZ63TWgyhesyYktgy?=
 =?us-ascii?Q?cWzhTQWdTU/RGqNH6X1vPBtl7IzwQndHcCLL0kQeZC6DDveZCrTitWXgbQPy?=
 =?us-ascii?Q?NR2qPS+zEyX4o03evfhUZ6fZoAAla5/DYFuPGf954J8BcidhVhUz9CAkA7/s?=
 =?us-ascii?Q?F0nPo1FLWXEvLbtLp3Sx9s7/aJR9Rxj6rzDppUj1TXM0bamztX26c26j8+aA?=
 =?us-ascii?Q?e7GEPUnpJ5Rulx4tVLKvzUuLUrmg9i/0xrC4JB9NbMTZjME98mN1Stq6c05Q?=
 =?us-ascii?Q?+FahZFPvvUAytL04lco9m8bGvEqYUuRL5V9WQIThOZUvZCQRPTo286unE+3y?=
 =?us-ascii?Q?tySFS+EyJgXiZIkHKqLM2JJfpH1Sh5W1pqz/syblQVAAy51U6ir/452NSUBl?=
 =?us-ascii?Q?BZSYsEzfobi8KUvFTWcyPE/dfRJ3glmemfTaa9xuc3pq9vRbayZJYW3BwCLZ?=
 =?us-ascii?Q?UVqhbZYewybI5FwXvf5GacNH7wg/mUtOeYWs0qCf/p5zG5Mc2Fr9Iuwifneg?=
 =?us-ascii?Q?ZnY5gcEdCuVkarMOVTDPRtaT/VTSJCzvRsopXkwNz3aX2bJpsP+gLSnAQbq9?=
 =?us-ascii?Q?AYl3tFYnY6uSoOD4jmudq1GsUgE44wYjCXoDOMRopxXdSIm1mVvmTSYflvBE?=
 =?us-ascii?Q?5OcPCRwxYtuK2t8CKnKa2NqJL6CUbvJXY8h25/EDAON2vqC3lMxd11sb7SmE?=
 =?us-ascii?Q?5TRVqE9hZrkEWmvwUlcolyfXSGpTOR0nqrk3KT42TXFWn2Oi/aU1LuubuJKW?=
 =?us-ascii?Q?ENjyPXv6H+U57cqR6vj15ZgM+fGtrZYEDYaEwAskC70ZFgn9NueBUTtNAM2+?=
 =?us-ascii?Q?omdCLwD5DhfOi5OdYVPL+WUMoyzJOLbqrJtZQzWBvdstIG7axfDRkb0OG2uO?=
 =?us-ascii?Q?TnC/IxgQwDdrRXnFtrFzrF6/ie6M2X0Udyo+CB6DtepSmKuM/HPedpnkWJmN?=
 =?us-ascii?Q?M/6RKcXOxL9EvFZamiU6r4NI0ZhQm0Azja3Al2ub2zN5W4+cx7PIKVN9AvlE?=
 =?us-ascii?Q?U1diVqiCrCYfMPDE/mvimG6qrzutBmNfVqSskODRUcFWvOmQS+80RlS/Qj2Z?=
 =?us-ascii?Q?UiOTofglFE/l8iOhQEvcVSA5ARNVAbX+hXSGXZDyruP2R7Kuxn+HR+kk6PMH?=
 =?us-ascii?Q?aVUP7W9m8fWRjw2nitLxefqy3p3aZKb9GX80pJzx7Ii5hGBKFT5+1zrjoXSW?=
 =?us-ascii?Q?D6YBccAYazmjp7Ee7kLp+VPSa/cp3kKNBztqrSr9?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB5017.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b27a17e1-858a-4060-a5d8-08dafb0df882
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2023 17:44:24.8336
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PDC+8NEiIgTzoHED90x4rlTYyT3SXAACJMN2Zt4NL70e2as4xLohfRC1emD1vxTKzusvdtFGlrVp6u344SykLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4761
X-Proofpoint-GUID: -Pk4JGEFp4RWbQaYsAClCRoia3VAR5fV
X-Proofpoint-ORIG-GUID: mEit1PhXCH4drx79jRDK3aFzputC_XSB
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-20_09,2023-01-20_01,2022-06-22_01
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi James,

> Changes since v4:
>=20
>   * Rebase onto perf/core
>   * Convert new perf_pmu__cpu_slots_per_cycle() function to use
>     new helper functions
>=20
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> Changes since v3:
>=20
>   * Scale time estimates by INSTR_PER_NS, rather than assuming 1
>     instruction =3D 1ns
>   * Add a new commit that fixes some issues around timestamps going
>     backwards
>   * Use nanoseconds inside cs-etm-decoder.c, rather than storing the
>     raw time values and converting when a sample is synthesized. This
>     simplifies some of the code like estimating the first timestamp.
>=20
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> Changes since v2:
>=20
>   * Remove const to non-const change and copy strings where needed
>     instead.
>   * Use sizeof() instead of PATH_MAX
>   * Append "will not be set accurately." to new error message
>   * Remove unneeded stat() call
>   * Rebase on perf/core
>=20
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
>=20
> Changes since v1:
>=20
>   * Add 3 refactor commits for sysfs reading around pmu.c as suggested
>     by Arnaldo here [1]
>   * The dependency on [2] has now reached mainline so is no longer
>     blocking
>   * Rebase on perf/core
>=20
> [1]: https://lore.kernel.org/all/YnqVqq5QW%2Fb14oPZ@kernel.org/
> [2]: https://lore.kernel.org/all/20220503123537.1003035-1-german.gomez@ar=
m.com/
>=20
> German Gomez (4):
>   perf pmu: Add function to check if a pmu file exists
>   perf cs_etm: Keep separate symbols for ETMv4 and ETE parameters
>   perf cs_etm: Record ts_source in AUXTRACE_INFO for ETMv4 and ETE
>   perf cs_etm: Set the time field in the synthetic samples
>=20
> James Clark (4):
>   perf: Remove duplication around EVENT_SOURCE_DEVICE_PATH
>   perf: Use perf_pmu__open_file() and perf_pmu__scan_file()
>   perf: Remove remaining duplication of bus/event_source/devices/...
>   perf: cs-etm: Ensure that Coresight timestamps don't go backwards
>=20
>  tools/perf/arch/arm/util/auxtrace.c           |   5 +-
>  tools/perf/arch/arm/util/cs-etm.c             |  91 ++++++++-
>  tools/perf/arch/arm64/util/pmu.c              |   4 +-
>  tools/perf/arch/x86/util/pmu.c                |  12 +-
>  tools/perf/util/cputopo.c                     |   9 +-
>  tools/perf/util/cs-etm-base.c                 |  34 +++-
>  .../perf/util/cs-etm-decoder/cs-etm-decoder.c |  68 +++++--
>  tools/perf/util/cs-etm.c                      |  95 +++++++++-
>  tools/perf/util/cs-etm.h                      |  16 +-
>  tools/perf/util/pmu-hybrid.c                  |  27 +--
>  tools/perf/util/pmu.c                         | 177 +++++++-----------
>  tools/perf/util/pmu.h                         |  10 +-
>  12 files changed, 351 insertions(+), 197 deletions(-)
>=20
>=20
> base-commit: 1962ab6f6e0b39e4216206205bda14aff87705f3
> prerequisite-patch-id: 9722bf86e3e6d16d177ff9a1411992a795a7dcbd
> prerequisite-patch-id: b05dbef439c2ea8465f3321532257b0ca29f21f9
> prerequisite-patch-id: 92680a4781cbcf010fcb007e6ea030f59e9eaefc
> prerequisite-patch-id: 8e3a73a04e4b89b503377b5fac1d89d551159393
> prerequisite-patch-id: 09980d8fedcdaa70b220a7802428109f48448a58
For the series,

Tested-by: Tanmay Jagdale <tanmay@marvell.com>

Thanks,
Tanmay
> --
> 2.25.1