Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 20 Jan 2023 18:51:00 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     Qi Feng <fengqi706@gmail.com>
cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        fengqi <fengqi@xiaomi.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH] HID: add KEY_CAMERA_FOCUS event in HID
In-Reply-To: <20230109123216.4974-1-fengqi706@gmail.com>
Message-ID: <nycvar.YFH.7.76.2301201849090.1734@cbobk.fhfr.pm>
References: <20230109123216.4974-1-fengqi706@gmail.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 9 Jan 2023, Qi Feng wrote:

> From: fengqi <fengqi@xiaomi.com>
> 
> Our HID device need KEY_CAMERA_FOCUS event to control camera, but this 
> event is non-existent in current HID driver. So we add this event in 
> hid-input.c
> 
> Signed-off-by: fengqi <fengqi@xiaomi.com>
> ---
>  drivers/hid/hid-input.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 9b59e436df0a..22cca3406b5c 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -1105,6 +1105,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
>  		case 0x0e5: map_key_clear(KEY_BASSBOOST);	break;
>  		case 0x0e9: map_key_clear(KEY_VOLUMEUP);	break;
>  		case 0x0ea: map_key_clear(KEY_VOLUMEDOWN);	break;
> +		case 0x0ee: map_key_clear(KEY_CAMERA_FOCUS);	break;
>  		case 0x0f5: map_key_clear(KEY_SLOW);		break;
>  
>  		case 0x181: map_key_clear(KEY_BUTTONCONFIG);	break;

[ CCing Benjamin ]

Hi,

so according to HUT 1.3.0, 0xeb-0xef are Reserved for now, so I'd be a 
little bit hesitatnt to but this into the generic mapping, as later HUT 
revision might define this in a different way.

Which devices are known to be producing this?

-- 
Jiri Kosina
SUSE Labs