Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f709f410-f21b-b2e7-4e76-04b15fb2001a@quicinc.com>
Date:   Fri, 20 Jan 2023 13:13:16 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v6 0/2] Add base device tree files for QDU1000/QRU1000
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
CC:     <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230112210722.6234-1-quic_molvera@quicinc.com>
Content-Language: en-US
From:   Melody Olvera <quic_molvera@quicinc.com>
In-Reply-To: <20230112210722.6234-1-quic_molvera@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Can someone review these patches please?

Thanks,
Melody

On 1/12/2023 1:07 PM, Melody Olvera wrote:
> This series adds the base device tree files and DTS support for the
> Qualcomm QDU1000 and QRU1000 IDP SoCs, including the clocks, tlmm, smmu,
> regulators, mmc, interconnects, cpufreq, and qup. 
>
> This patchset requires the dt-bindings changes from [1-3].
>
> The Qualcomm Technologies, Inc. Distributed Unit 1000 and Radio Unit
> 1000 are new SoCs meant for enabling Open RAN solutions. See more at
> https://www.qualcomm.com/content/dam/qcomm-martech/dm-assets/documents/qualcomm_5g_ran_platforms_product_brief.pdf
>
> [1] https://lore.kernel.org/all/20221216231426.24760-1-quic_molvera@quicinc.com/
> [2] https://lore.kernel.org/all/20230112204446.30236-1-quic_molvera@quicinc.com/
> [3] https://lore.kernel.org/all/20230112203653.23139-1-quic_molvera@quicinc.com/
>
> Changes from v5:
> - Moved XYZ-names fields under XYZ fields
> - Removed irrelevant comments
> - Updated ordering of some fields
> - Removed unneeded fields
> - Revised style on clocks and interrupts
>
> Changes from v4:
> - Added chassis-type
> - Added missing regulator voltages
> - Sorted includes
> - Remaned memory nodes
> - Reorganized nodes to start with compatible/reg
> - Removed unnecessary clocks
> - Switched to deleting nodes by label
> - Moved pin biases and drive strengths to dts files
>
> Changes from v3:
> - added PCIE and USB clocks
> - added missing qdu1000 compats
>
> Changes from v2:
> - Revised device nodes to match updated dt-bindings
> - Revised rpmh-rsc bindings to allow for generic regulator nodes
> - Updated soc ordering
> - Moved clock node to DTS files
> - Updated regulator nodes to be generic
> - Removed some unnecessary whitespace
>
> Melody Olvera (2):
>   arm64: dts: qcom: Add base QDU1000/QRU1000 DTSIs
>   arm64: dts: qcom: Add base QDU1000/QRU1000 IDP DTs
>
>  arch/arm64/boot/dts/qcom/Makefile        |    2 +
>  arch/arm64/boot/dts/qcom/qdu1000-idp.dts |  453 ++++++++
>  arch/arm64/boot/dts/qcom/qdu1000.dtsi    | 1333 ++++++++++++++++++++++
>  arch/arm64/boot/dts/qcom/qru1000-idp.dts |  453 ++++++++
>  arch/arm64/boot/dts/qcom/qru1000.dtsi    |   26 +
>  5 files changed, 2267 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>  create mode 100644 arch/arm64/boot/dts/qcom/qdu1000.dtsi
>  create mode 100644 arch/arm64/boot/dts/qcom/qru1000-idp.dts
>  create mode 100644 arch/arm64/boot/dts/qcom/qru1000.dtsi
>
>
> base-commit: 0a093b2893c711d82622a9ab27da4f1172821336
> prerequisite-patch-id: d439ef85a730c7b736ed8c63162e24c7ae661b60
> prerequisite-patch-id: c55ff1a38fed5356caa8f40a85ef0b8ebc4d1fa4
> prerequisite-patch-id: 984e8570d2464f4027dc59294c10f47e7ae29a84