Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 20 Jan 2023 15:21:06 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, songmuchun@bytedance.com,
        willy@infradead.org, jhubbard@nvidia.com
Subject: Re: [PATCH 1/9] mm/hugetlb: convert hugetlb_install_page to folios
Message-ID: <Y8sh4mI6+nPkUwx1@monkey>
References: <20230119211446.54165-1-sidhartha.kumar@oracle.com>
 <20230119211446.54165-2-sidhartha.kumar@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230119211446.54165-2-sidhartha.kumar@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?C/5nJ2opEH58wtvRHfgZ3gPfLin9h9x5otwlzCz6TszjNTu07DzIWAuaLBbr?=
 =?us-ascii?Q?c5J4ID2pps+rYXyQ0eFUv9XkMX4SmP8KkZR2A6hU7dzJW8V2FMQrSMMMznx9?=
 =?us-ascii?Q?dHphEiFc1TWI7maLZRP1sRIDLnadA6UZx2Kprvtv171XStuaOP3SAVbPf3r1?=
 =?us-ascii?Q?NmjIdc2bFdQejauqhi3AY8chrSqnJHxLf/RVQBH4jpE8IPMkooq9aXcZRwbo?=
 =?us-ascii?Q?u04126gEmMbYBQVwQvrGiMj2vvSp8l1es+ibxsrn2KjsFGu5FWGdBhfclh1K?=
 =?us-ascii?Q?HxzR1S7wfQNKLGH4IESjvB66OEXb1SFGmc11seZfHnjoDxg6r/FKQwMLZVWe?=
 =?us-ascii?Q?zPQIfGG1B7yHEh9THgvGvc4AxroeojbdhOczgHt4YL6zoPzC01gP+d3MJBuX?=
 =?us-ascii?Q?DPEsFWdCBTAUzfxXxqaWNlb+puWGkieseHSCwDhKrWiAnlQlXfRyf5AnstnF?=
 =?us-ascii?Q?m83Gi8ptouX6yOZVRk5PdlG2K65VoC0as/XFhVNtyty+F4T2ZrlSt7ZsbcCl?=
 =?us-ascii?Q?0sAJMFDU6UlRJC/2qF518tQU6dE/taAh7NtQba05MWokE+XzqwRGV7erh5NJ?=
 =?us-ascii?Q?UU/aKOR9jgac8QGBtlcaqm5FFcUjwgH3X0qby9mOpDVNeb8hIDB3yq5PiPId?=
 =?us-ascii?Q?jW02oI6SYYuURx3EIidyWjkfZdY+n95Z/GvDusFD9xYYIs102PMDsuY68Nd1?=
 =?us-ascii?Q?KWhan3/4JNbUzWYyT3VxIVYxLUTY2/QZxq3QbXODNooHBLrqVTJj1maJcI2u?=
 =?us-ascii?Q?hKhA7n4H7p58lm7gOFMmnfXsLTuEOXhz6EHvbtOm4Z29ueokIsOgHKtZuIaJ?=
 =?us-ascii?Q?WypHRde/DbH0yDIgHW9h+/XNuuJFrnZAjTB5Ee5zQKO4eR2zXJoQnqaDo0GB?=
 =?us-ascii?Q?EHuDz8HQ/hHccUFX9HRHPLBPtXI6BfiZzO5AOlS/APL6Y7HAXWs3eHKPTs+L?=
 =?us-ascii?Q?pZ2Ropa3SX1Qtgv0kQ0p7qrNAOjDkhEAawq6I2WuoLmEYLsqck/wBe604GKn?=
 =?us-ascii?Q?pCmmMP2UrBBj/kFncHgrwVJQm6bbxuv0knrv9rDiJkS3TXEZQyBmTlHI5Rrx?=
 =?us-ascii?Q?liiLRe/HkWp3F02Z1oaScnyM3S+nqH5sLrokt1RmIFfLGj84npvdKZdj+C+v?=
 =?us-ascii?Q?qIHFgt1Xbs5FXY9SAa+b/4C1H0T/yv7yTBWYru6J+BLE2HrjleJlZDn+w7rF?=
 =?us-ascii?Q?iVkOTiYULthuEljgRBT3Iv1EMxJpDErtTCYnEG7h5xTHu4d30GKRnNmwWi6C?=
 =?us-ascii?Q?VUqWcW11x9ksp3yg9SJn722BYDeMZE5HIuoh65zFCe8kDDdLTUqez/ymGk9/?=
 =?us-ascii?Q?S/spLkR5gXqs3clqnTmwjV+9QdaD0i4WWk2hgPQWsb1zqqphh/P3R9Ufq8DZ?=
 =?us-ascii?Q?sJE8EOLeawxcmWeXc456t7LaQFXtgLuxj5856Nkk/xWKNexnskMGIRu8owWA?=
 =?us-ascii?Q?Z5XO1cd9QLn7a6vIKJ16EBB3wxNL/ArluFxNrN57bLJBP5xy1d4HItDqK8Pz?=
 =?us-ascii?Q?lXumBPYWBmW0pRcQffBuMRr52K9LF1f3mg89bK0bvqrpfYdeQnjIkede3dM9?=
 =?us-ascii?Q?yk3BowADEGbRZRTAJIpO+2cGTdQJFMTPcl+OScCWPWcHlEtDaEM+IzLK/pju?=
 =?us-ascii?Q?8Q=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?p4PsUK3vWdyxOaRsypBACTks9DqX/ocC/esqU2BVly90YWzWMz8GmbUa8oOV?=
 =?us-ascii?Q?aY2XdWFeV1liMVH8q2F2k+xhHAtD79J1CVnLh6SjD0Wi4wpNTgsZamGIksb8?=
 =?us-ascii?Q?zYVX7qi3MBFGaotwyyK+J21LM0XPnckhUnk0fjPIyW3trgGOMzPlmr801B2+?=
 =?us-ascii?Q?bp9zcIDjzKInq0NHQcH6Wo9tlyL9Dqngjym5QqQ7en4TpaE8DEbL4Uu4uTQe?=
 =?us-ascii?Q?EoFqVrKmWL1wfrkP7MhUOZvAnvLaIg7V9NTah9QVbvHNywokm+2GqYCzzER1?=
 =?us-ascii?Q?NLvQCaNgNQwVwVrSOiTxKZULZSbneBCn34LWScg/waiaABbVWRz64HNdNKQZ?=
 =?us-ascii?Q?pRntCdpAKQUhZM/yl+rQNIV+10FTTLCHveC4JpFLyJUfu6k+zXlUJ2HK+ep5?=
 =?us-ascii?Q?ayluCiUx5A5QAvmu1A/4S/QQxJun9XStWbAZLMdm5YAWgOkzncntMXDovyGd?=
 =?us-ascii?Q?7VrpGppWSpAq85aDcXL7EMwwqRGAy91dIeF/BsKtG5uM4cZj8B47tRocGSDh?=
 =?us-ascii?Q?bNlDV+Yd1Wwq+i0MD3CtGu20V6s/fDkbGkA5AyYF9PWnUHd4e3yxBmSJ3iio?=
 =?us-ascii?Q?zJhAGyNhPtKGoCcX7TCHEvjg4NqemXqgVlQMXhkn42P9msGpJJ8DKywPBs38?=
 =?us-ascii?Q?6xDiXPEBCXKRO4IPEOKwYPrX2QelYWzgOqsojM8YpyRFSISQxmoK9xGezDJe?=
 =?us-ascii?Q?JG/fwSvRZRrrUvsETNI5/p9mPz+5mE6O+jfgTdpVOzVNtKjB3sTl3gbx5ckW?=
 =?us-ascii?Q?IU84wIhxcsYkYdmHno4K8C5Elfsk+x+5X2XWUdYi7EmzwSSJc108618mxJPD?=
 =?us-ascii?Q?Ah2Y8RS+UTlIWUX/EtZzTEp2lzDbPXnVtuwYHQx7JIvHXOJEBu/jyAr/Z4hp?=
 =?us-ascii?Q?JMqlQ95PrmdISXM/MhtKkLsiEddcPvr4c03ElrT+sNhLfHmkcvK+/9EBPHmI?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7da2e561-bfba-4fe8-f3f8-08dafb3d02e6
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2023 23:21:09.0049
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: od9T0HG+7skTEmnsm3GWsWkOb8BU3r955F7bZyqaGeG50u0MFLfV83B/ccKqmq1iaeTlKnC8vNpGASAHGN7IuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4565
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-20_11,2023-01-20_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 phishscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301200224
X-Proofpoint-GUID: uyXFJjUQve8ivK-5NswMzh7YK4eaWmh2
X-Proofpoint-ORIG-GUID: uyXFJjUQve8ivK-5NswMzh7YK4eaWmh2
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/19/23 13:14, Sidhartha Kumar wrote:
> Change hugetlb_install_page() to hugetlb_install_folio(). This reduces one
> user of the Huge Page flag macros which take in a page.
> 
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
>  mm/hugetlb.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

Looks good, thanks!

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz