Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 20 Jan 2023 15:40:34 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Sidhartha Kumar <sidhartha.kumar@oracle.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, songmuchun@bytedance.com,
        jhubbard@nvidia.com
Subject: Re: [PATCH 2/9] mm/hugetlb: convert hugetlbfs_pagecache_present() to
 folios
Message-ID: <Y8smcgsffpX3X/bd@monkey>
References: <20230119211446.54165-1-sidhartha.kumar@oracle.com>
 <20230119211446.54165-3-sidhartha.kumar@oracle.com>
 <Y8oqEOICcNV762IA@casper.infradead.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y8oqEOICcNV762IA@casper.infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3ZngRbWFjSufm1To0pLZn4e7z8f5i+DKNrtJQDCaDBc1PYDwJBzGP2o2o5xa?=
 =?us-ascii?Q?6mEEIsRU6tj5fBTA+6VsL2KfQjsVp55h7GoG/7J2Syh4OhvyuzjZf1Ohsh7L?=
 =?us-ascii?Q?U2YmDwLzlG8J8DKHzWKlW/gkx61bNh883Vm20colZr0a/RlWEwRDRCwXYk/c?=
 =?us-ascii?Q?3ZVoEd9s1J/SSCluxqEMnrA1KZXalFukqXGVsDhdpbesiTyKQMYxqqkO01tL?=
 =?us-ascii?Q?TIHc+0eKseTv9/b6RnqhcfFZu/LU7BijLLbQyHR3jcp0qFQ4h3CRmOW8pfhr?=
 =?us-ascii?Q?zP5SBwPCk9Z5MmjBCQzaD2V5ePlwvaU2d8TAha4NSPR8RphoeNdRBp2Km4D9?=
 =?us-ascii?Q?Dltf8GC5k14Zt+Drf2SOGMvzbDEBXbowP9jhDLn0/PAErEmqY2wkahTOmdCF?=
 =?us-ascii?Q?d5EhGBmDCETiZkEbJsc0RhFI6FchsSu+RTRB1nzv81yLucZ+Eb2yDAwOaRYU?=
 =?us-ascii?Q?jtd4JsqI8h11nduuz8JzbUu7z9/4Fb0L9P4z4xLbvjstDjf39j2xeRASCLQg?=
 =?us-ascii?Q?Ae7vPnHjK7jnDwkpeYvt9/gTZegoWl2/0aTAO4I5b1mE8FAFPhY9nLb0gvRT?=
 =?us-ascii?Q?DtiFLlu5PNO34gd9F0N5DagotEfkDinHZ9mHT7cr6xirwlsv3mlnLyOaPXjc?=
 =?us-ascii?Q?mswSQYhozk32ut4XJW+R74Pqv2WCovyEu9Z81JBNuImZCz48NxEYsNXxhTs8?=
 =?us-ascii?Q?c0skE/30VfBLMuF0uA1WwoUavAKDDNi90nMh4vqW/lhXUdCphA06Fh1yL8c+?=
 =?us-ascii?Q?TmFhiPYekgHhjSpGqN4qCQdiYUpf1twCjRTRxWRTK5wZ79H2EqAMKPOE2x+Y?=
 =?us-ascii?Q?D31thdpMCBLHMWaRqeKJuKZ3lWD5cyfyTL0EC8BXkCcfYnuYp89on8UQTNPc?=
 =?us-ascii?Q?InV4F7PZgSI16x5p/0zKchlc880lC7iBnGcC8AWdPNzwgOfWNpzddvhpoiij?=
 =?us-ascii?Q?833nQxhuRXGrFI6L9zquznPOUwm07ofTL0083dPXHjFBH4lqmsVWCN+rpRyw?=
 =?us-ascii?Q?1VX2KOt7AXTDuvsSY2rPRkjGT4JwVqrqY+9mxKEl4/UUXwK9lJutnmKxEcg1?=
 =?us-ascii?Q?8ePi1qj/XC3yge0v8bnW1JYLJnILrdcOndJ4sDbc91SWIdii0sL9imlAGSw0?=
 =?us-ascii?Q?kpAvPlnVE7vyK6pXJeknktH7eUrXyagYdLJykpd4mlmQN7WSoz9jheVk7hDe?=
 =?us-ascii?Q?1LxGzZ241PyRp17TgKSnZgTcETI7SH9IoctP5KE68j/jdCle4KmBm04yQ8Nt?=
 =?us-ascii?Q?MrrDI7k3/r0Pj38MCUuJVKJauFLyhw+/+SfxinMWgSl/z4/ySyN61jyPqM+f?=
 =?us-ascii?Q?d6HBVLZZjJlpicIySfwi02k1JCabePjxpqdS5WEtG0xCrHvekzHzJFAkjhww?=
 =?us-ascii?Q?VX+TKK5KoBKaGP3bg4plqlASNuzKDcCP7gU0SedWV8Q0SVlyJvaqyaeMOK/c?=
 =?us-ascii?Q?nuSdaUja6ZZzfRBowsaI/z1C9vkJhl1GhwXMnc4n5V7pthlQVQslvOfohnM/?=
 =?us-ascii?Q?DPOUk9z/4+duHsbolSgvU5/cki7WwqEVvgZLz/lGW5leL5SgMe/z0jeTKgre?=
 =?us-ascii?Q?dmGgNqXHXEaoXuIosvaOUBFm/RYWqvAhGWToaR3ABRxsdIZGLr17iF8rfoLy?=
 =?us-ascii?Q?1w=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?q8WVkxB5O173LezKWITX8Pt5laNV2v5V+lnxEUO0ZFdBmfYCoHQHpdWhPIub?=
 =?us-ascii?Q?4ef7u1VX7Fxe+HUviTZ0mAia9GObU9/7NZcAzNsnGEzch3RHtB6KOY1fFBxL?=
 =?us-ascii?Q?KWcbgbq5u4rP4PNjwIdTi7r0Kr7nQjHdPYAPHZfGB9fioB+ZArorS395vrTH?=
 =?us-ascii?Q?snqEW2AffuRHfR8a96EhyMawzuVLCkGHUjgWp+8DXcRTjvjoKyElCjaYyvPv?=
 =?us-ascii?Q?pbOKCNg8u86Zv7+1qhL37faC0ZacDfQbAgUEbggSdRdyfagg95FA4kB/Hvp6?=
 =?us-ascii?Q?laO49lmPFuC+rhKLKyWYEqu08kQq4jhbJNjbBHCtVJ45XP+LSHsjVm+aar/8?=
 =?us-ascii?Q?hSttb1covtNFLgDenn8yVE9vXaNB76vtGmzlmmP6AvDc58MSWRIlr1IkjF1b?=
 =?us-ascii?Q?rxaxP2Nz1jVn922FOQX1TxOmVBfvNAYYkl9BFlVtj3LRwR1CU2MDoEfcMOyn?=
 =?us-ascii?Q?29S4pwGKxylqQQHzZDOTBl8sfLM6l2gNLJyvB7TUFHiemSk9ORnN3feF25cD?=
 =?us-ascii?Q?V73bnYAH5YXHRMS6A+6cuTox2ybjUO/dmWZt9bh/wlRl+QJ5ebn5ExXKTj+J?=
 =?us-ascii?Q?E0KV8XT2Z36C6iRZclCfM0N+HFUS1hJK1mmce6RGbjNF99kyV4zkty1TGfKG?=
 =?us-ascii?Q?VqQsMRc0M7T419yOntXhJsplc8UGF7qJdy4EhIdNb3G3QbE5pcCbVLRGBzyG?=
 =?us-ascii?Q?wAqEGEiRPmW07bYEkfEP9XxzK36e5ZDXhwjlKiNJHoUw3irCFukXu+0EfQIY?=
 =?us-ascii?Q?wUxKq2YXTS3VVgWlC0f8/V3Y3bhbPsPUP9MdmeU+T3a5QxUG5ErEUw/SIZao?=
 =?us-ascii?Q?syFB/FkZWLgyImPau7V0kpIF0Pjx5n+H0ie6Rue/xdi37cnpqdzNBTWwREaU?=
 =?us-ascii?Q?q3UBu587mIlSSoNhSw6HaM98Ko/5PpHwPWLQ8Wjsv4yv94b1ZTjb93baOBE5?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f4ee71a-a2b1-473d-cd12-08dafb3fbbd4
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2023 23:40:38.0861
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nApDzdp/krHSueITevdlOhVXRCd1VTmTKOY6ge58G5x4MvnrC/DwH+ODBJRJ59+iL74KqMw38Gh+JDp2N4di9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6064
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-20_12,2023-01-20_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0
 spamscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2301200227
X-Proofpoint-ORIG-GUID: aEUeMAnqg4pdHOaaGpL4MTocoOIaULai
X-Proofpoint-GUID: aEUeMAnqg4pdHOaaGpL4MTocoOIaULai
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/20/23 05:43, Matthew Wilcox wrote:
> On Thu, Jan 19, 2023 at 01:14:39PM -0800, Sidhartha Kumar wrote:
> > +++ b/mm/hugetlb.c
> > @@ -5653,15 +5653,15 @@ static bool hugetlbfs_pagecache_present(struct hstate *h,
> >  {
> >  	struct address_space *mapping;
> >  	pgoff_t idx;
> > -	struct page *page;
> > +	struct folio *folio;
> >  
> >  	mapping = vma->vm_file->f_mapping;
> >  	idx = vma_hugecache_offset(h, vma, address);
> >  
> > -	page = find_get_page(mapping, idx);
> > -	if (page)
> > -		put_page(page);
> > -	return page != NULL;
> > +	folio = filemap_get_folio(mapping, idx);
> > +	if (folio)
> > +		folio_put(folio);
> > +	return folio != NULL;
> >  }
> 
> Seems to me this function could be ...
> 
> 	struct address_space *mapping = vma->vm_file->f_mapping;
> 	pgoff_t index = vma_hugecache_offset(h, vma, address);
> 	bool present;
> 
> 	rcu_read_lock();
> 	present = page_cache_next_miss(mapping, index, 1) != index;
> 	rcu_read_unlock();
> 
> 	return present;
> 
> No need to get/drop a refcount on the folio.  It's a bit similar to
> filemap_range_has_page(), but the API is wrong.  Maybe there's room
> for a little refactoring here.

Thanks Matthew, I did not know those APIs were available.  Perhaps just
use page_cache_next_miss as suggested above for now.

FYI - There is the same pattern in hugetlbfs_fallocate()

		/* See if already present in mapping to avoid alloc/free */
		folio = filemap_get_folio(mapping, index);
		if (folio) {
			folio_put(folio);
			mutex_unlock(&hugetlb_fault_mutex_table[hash]);
			hugetlb_drop_vma_policy(&pseudo_vma);
			continue;
		}

-- 
Mike Kravetz