Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 21 Jan 2023 08:28:00 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Kechen Lu <kechenl@nvidia.com>
Cc:     kvm@vger.kernel.org, seanjc@google.com, pbonzini@redhat.com,
        zhi.wang.linux@gmail.com, chao.gao@intel.com,
        shaoqin.huang@intel.com, vkuznets@redhat.com,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [RFC PATCH v6 1/6] KVM: x86: only allow exits disable before
 vCPUs created
Message-ID: <Y8uUAFv9Qz7GvSei@kroah.com>
References: <20230121020738.2973-1-kechenl@nvidia.com>
 <20230121020738.2973-2-kechenl@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230121020738.2973-2-kechenl@nvidia.com>
Precedence: bulk

On Sat, Jan 21, 2023 at 02:07:33AM +0000, Kechen Lu wrote:
> From: Sean Christopherson <seanjc@google.com>
> 
> Since VMX and SVM both would never update the control bits if exits
> are disable after vCPUs are created, only allow setting exits
> disable flag before vCPU creation.
> 
> Fixes: 4d5422cea3b6 ("KVM: X86: Provide a capability to disable MWAIT intercepts")
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>

Nit, no blank line between fixes and signed-off-by please.

And an RFC on v6?  An RFC usually means "I don't think this is correct
so do not take it".  How can you do that for 6 versions?  And know that
no one will take an RFC series for that reason (or at least I will
not...)

thanks,

greg k-h