Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp4092742rwb; Sat, 21 Jan 2023 05:49:56 -0800 (PST) X-Google-Smtp-Source: AMrXdXvTV0ebma2JI3WHtX3zuxAuTJ2Ide3UpSgdAYVPvXydiPrUoNs64It/Z0Nwt1g297ZuV1cc X-Received: by 2002:a17:906:f9cd:b0:7c0:b569:8efe with SMTP id lj13-20020a170906f9cd00b007c0b5698efemr19046885ejb.60.1674308996334; Sat, 21 Jan 2023 05:49:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674308996; cv=none; d=google.com; s=arc-20160816; b=oAnrbdTtKXRiytUwfbiTRHz9Pxwv3+wNAIJ0zn2NCJSI149079v1JMmoyp6g5srR1S iMiS62CCn3Gs0u4WF6iaelwVum/ikY8NYdodK9PFzOYQip+JHFOcLRc6POsSy2Dq+Q5B IZqqzy1rtoSabmM2Nu/5g3CxEWSTOFO4L7y1A4ZKPXgC6zVg8yXY19g+LMOPMqM+umAL Ml3onf0njCNc2myyeH8VdHAAkGTHHxQM07dwJk0jReUFWtR0LVkGGiLDzKBffoQcgkRM 6Lv3blOuPWNHOlDqNbCFEg+VBdZJCVegzhqC0HvkMng9Nn6OHRAcYwiUYG+91jwIxxe9 AGgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=KZ87iyK2fCKE6lUSEoIxgZ62brcKGXwnNfVm3IcTvPE=; b=kyquAMKLo2BvoTdj7Jjph9XwPK2saMBStKPGfg87vdLQRhiLam8Z4jqQYdRN0JBBrl p9M+KVYhxFIBOM0V8JJGGANwkkhSj7eYRhQg+eS/WynAdV9gaDSVjIYnhN2LbMyMdk72 DSqg14ejcUvU6/gIY17i3TxHNXBP8uQvygoKnI+taWTSMYIX5Yet87/3m3Xd5sDXRQFG cdRHgjeDlafKnMmGilkbB6OzszTbCNPRaHnIbgvgOksOCyZtWvwq8k9LkiAn1sO2RieP p58CVP2L+kdpqJCwdcLXAJ+KznXv/iFRCpqNK9vfDQB7vTNPQuYZUAgXhi4ls/TSmu/2 eqvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="mH/kcykm"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr6-20020a170907720600b0084d197a89e2si531949ejc.957.2023.01.21.05.49.41; Sat, 21 Jan 2023 05:49:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="mH/kcykm"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229795AbjAUNFo (ORCPT + 50 others); Sat, 21 Jan 2023 08:05:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229762AbjAUNFj (ORCPT ); Sat, 21 Jan 2023 08:05:39 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72CC4457E2; Sat, 21 Jan 2023 05:05:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KZ87iyK2fCKE6lUSEoIxgZ62brcKGXwnNfVm3IcTvPE=; b=mH/kcykm8xfGpdwTLf5BFtcIXH VZ5SwMou2cdq0/HRHws+AjAFLpbt52f9V+tFgK7AiFSjmDpesmq2jCOOx0PeYFMEgdoQbEj5gGsVh 7h7hWGBkxfXNPiSrzKZhH1FoL1EXSrTn2CoA2tMxKHOTuiDSzB/HpGrFrfkLvF5DCCS4S+PVDTglC YKlf0PD1DsLJ70vI/RWw54rLdFXiPWeeM6Xhyv3qQXerkD13PgExXQ5MnFe4nqAC0QQOsuoib5Bm9 cSYFy6lvOdGXkKl4iyBJsSRpbaBCmCNl8IE+bakeJOmqFmO7N/NtNacQubaZvOZV3nW/kHDRk3PlB x1Z9YKFg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJDYi-00Dsgc-OV; Sat, 21 Jan 2023 13:05:24 +0000 Date: Sat, 21 Jan 2023 05:05:24 -0800 From: Christoph Hellwig To: David Howells Cc: Al Viro , Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v7 5/8] block: Add BIO_PAGE_PINNED Message-ID: References: <20230120175556.3556978-1-dhowells@redhat.com> <20230120175556.3556978-6-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230120175556.3556978-6-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 20, 2023 at 05:55:53PM +0000, David Howells wrote: > BIO_PAGE_PINNED to indicate that the pages in a bio were pinned (FOLL_PIN) > and that the pin will need removing. Just adding the flag without the infrastructure and users is a bit silly. See the link to my branch to see what I think is better split.