Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Message-ID: <trinity-cbf3ad23-15c0-4c77-828b-94c76c1785a1-1674310370120@3c-app-gmx-bap60>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Landen Chao <Landen.Chao@mediatek.com>,
        Sean Wang <sean.wang@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Daniel Golle <daniel@makrotopia.org>
Subject: Aw: Re: [BUG] vlan-aware bridge breaks vlan on another port on same
 gmac
Content-Type: text/plain; charset=UTF-8
Date:   Sat, 21 Jan 2023 15:12:50 +0100
Importance: normal
Sensitivity: Normal
In-Reply-To: <20230121133549.vibz2infg5jwupdc@skbuf>
References: <trinity-e6294d28-636c-4c40-bb8b-b523521b00be-1674233135062@3c-app-gmx-bs36>
 <20230120172132.rfo3kf4fmkxtw4cl@skbuf>
 <trinity-b0df6ff8-cceb-4aa5-a26f-41bc04dc289c-1674303103108@3c-app-gmx-bap60>
 <20230121122223.3kfcwxqtqm3b6po5@skbuf>
 <trinity-7c2af652-d3f8-4086-ba12-85cd18cd6a1a-1674304362789@3c-app-gmx-bap60>
 <20230121133549.vibz2infg5jwupdc@skbuf>
UI-OutboundReport: notjunk:1;M01:P0:wmk6B6aAZVQ=;J+QEXdqV5YCSowD2rT41GWI/15W
 ANNdU1r+EaPYx1m0uefzzmBGIPKHJ8krgl/s2qdQIcFTC3UwEykS2lHeSOxLBJjpTAUvNOaD7
 oZgGmnCwoj08Sf+uazEre6Op3RmL7bhVqbPrJecpBkFfVPRCO1LcmFrjEupzHybA1HtFWHbib
 KfIb3FWy9sRRqvM3qWvloTC+xY5AKH2T18aZ+pr0F+ii3s0WhIreTxwABm2O/yf7duSSF9dZC
 caYmieU1phDZWzJ9s5geiKPGl/dnkEihtAaKI/t5Foy5j02UuIp0vFUwlGF7BT6ja5qJ474t0
 jowKNArDRemdfGT5rGfXcc9jaRu6C64snaGRhAk8adoIquO1s5bg8sDaMNb3MlfN77Rbf3T1X
 TocKg/85mHUOhWKncnOw2bezKMhskj/pxjO1rfE4wr2dQ7Hl9Ww1h+1QQt/mmgQV2TFMMn2qR
 hJ3/0zbhWoC09Jgx+e2qL7U32TGEqvBoZHuTdy/rp8U7YmaekboldRp0HLcbtbCNGBDOUEot0
 QGdhldj+7pWUnFPyygfd6l8LcIMgcAEtlZP2d0dawdEyEStzKA9L+H6bcFdas7oik+O4eHQ2k
 748e/BNfea30yLLeOXmaObwi1dXz4wvtrRFVXYbqYfzEOTXeF8sg8X4cq+NP25qUMhCKDoprM
 VdAk+uyMduwnXOFBbxV4f5cebdvljoLuQPKn5P+MRf+UXPlceIkw9r41163MOrm5w/YiAT3/R
 cXxyl4O3YhrVT2PuAKizJ7uvngtNup6QuqDSdxsn9yxDW6jQ7RSV2XC4+NlCaJKwz9tTaMwBb
 r8gtt3JcGahtSdjjH4NwdkwQ==
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi

> Gesendet: Samstag, 21. Januar 2023 um 14:35 Uhr
> Von: "Vladimir Oltean" <olteanv@gmail.com>
> An: "Frank Wunderlich" <frank-w@public-files.de>
> Cc: "Andrew Lunn" <andrew@lunn.ch>, "Florian Fainelli" <f.fainelli@gmail=
.com>, "David S. Miller" <davem@davemloft.net>, "Eric Dumazet" <edumazet@g=
oogle.com>, "Jakub Kicinski" <kuba@kernel.org>, "Paolo Abeni" <pabeni@redh=
at.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Landen Cha=
o" <Landen.Chao@mediatek.com>, "Sean Wang" <sean.wang@mediatek.com>, "DENG=
 Qingfang" <dqfext@gmail.com>, "Matthias Brugger" <matthias.bgg@gmail.com>=
, "Daniel Golle" <daniel@makrotopia.org>
> Betreff: Re: [BUG] vlan-aware bridge breaks vlan on another port on same=
 gmac
>
> On Sat, Jan 21, 2023 at 01:32:42PM +0100, Frank Wunderlich wrote:
> > so first patch fixes the behaviour on bpi-r3 (mt7531)...but maybe mt75=
30 need the tagging on cpu-port
> >
> > > Can you try the second patch instead of the first one? Without diggi=
ng
> > > deeply into mt7530 hardware docs, that's the best chance of making
> > > things work without changing how the hardware operates.
> >
> > second patch works for wan, but vlan on bridge is broken, no packets r=
eceiving my laptop (also no untagged ones).
>
> It's hard for me to understand how applying only patch "tag_mtk only
> combine VLAN tag with MTK tag is user port is VLAN aware" can produce
> the results you describe... For packets sent to port lan0, nothing
> should have been changed by that patch, because dsa_port_is_vlan_filteri=
ng(dp)
> should return true.
>
> If you can confirm there isn't any mistake in the testing procedure,
> I'll take a look later today at the hardware documentation and try to
> figure out why the CPU port is configured the way it is.

ok, booted again the kernel with first patch ("mt7530 don't make the CPU p=
ort a VLAN user port")
and yes lan0-vlan is broken...
seems i need to reboot after each lan/wan test to at least clean arp-cache=
.

but patch2 ("tag_mtk only combine VLAN tag with MTK tag is user port is VL=
AN aware") still not
works on lanbridge vlan (no packet received on target).

regards Frank