Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Message-ID: <trinity-fd23c4a0-a979-475e-a077-330577d7d632-1674311727972@3c-app-gmx-bap60>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Landen Chao <Landen.Chao@mediatek.com>,
        Sean Wang <sean.wang@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Daniel Golle <daniel@makrotopia.org>
Subject: Aw: Re: [BUG] vlan-aware bridge breaks vlan on another port on same
 gmac
Content-Type: text/plain; charset=UTF-8
Date:   Sat, 21 Jan 2023 15:35:28 +0100
Importance: normal
Sensitivity: Normal
In-Reply-To: <20230121133549.vibz2infg5jwupdc@skbuf>
References: <trinity-e6294d28-636c-4c40-bb8b-b523521b00be-1674233135062@3c-app-gmx-bs36>
 <20230120172132.rfo3kf4fmkxtw4cl@skbuf>
 <trinity-b0df6ff8-cceb-4aa5-a26f-41bc04dc289c-1674303103108@3c-app-gmx-bap60>
 <20230121122223.3kfcwxqtqm3b6po5@skbuf>
 <trinity-7c2af652-d3f8-4086-ba12-85cd18cd6a1a-1674304362789@3c-app-gmx-bap60>
 <20230121133549.vibz2infg5jwupdc@skbuf>
UI-OutboundReport: notjunk:1;M01:P0:8TBN3mYj3Qk=;JpZuon1vS0wKt2XiGySils9iO1y
 5enzztuoZKIr0nhGBkdHdRcmD+D2Fkax1WGNzwNVvbs7vVlyYnT3gnZ8xbygCRBfDO1l5NJ2k
 tLqkoSl5iH4jbkIqcIyrHPEpel2z/okOvrvFSiPmJfGHI9i6jeOI8Ow/Yd25liQcD/oOEWwjQ
 qJ7un59Dsbu2FuzKsl4UZrx0VukvU0tWhomZqIzCmLER8UN0SgxqD9p2ykcjaGs5z/scc51kt
 JF+Hof+vtVXZkbWQlAh/N3aB6XEh0fEA9tzOklCTVTu8r3Nbo2oceIZEKR7pr+eSnqC8oiiw9
 pCMZ6yTTEB3nr3UZXk4nwK6v0ra5oG8aB+tVDlwnJg8xXeGeBlqyXzVZr6cxsQo2znb3agLBm
 XbjM4KSa5eOSO99/vC9Zp2ZKUwzr0ZNkKt+zTInnV0GQcF8d1tu0CkZmrMmTxJ/xsaVGAKEAr
 WRLmqZfx3wPsEuClZuEaUfSbBcfA10sHo0k6JmaVS5dmKvmW5KpYzCj3nDjnG2FXYiZ7M9iwM
 P5kLmKmdjWN4jrSKZ0di5Jf7ahaTj3Nlb7FwYMp0Qx4eC1nBh90cHfHD84AFyvHJ011fTnywW
 Bgw1J6z/iD7ANtEb5TFIlS7goa/I6Dcqwx3ML9er768Mmtu6KvMs3+etnmkaYpcp7AOaszn/1
 F5az59YW82AxaGs30DmGOc7D/+T6mWQ4WNtKA+qFlfjbgf0/zyPVG3+600cgi6vevdnwKDsG6
 5MJxR8rFccXl0E2g8RfCJlUrZTXMmcUOzIJvdBhjTGRfMdhUUaHEpZlXhmEvwbb+U1GQvBJWF
 PUs6MFR8HlCYywFiZb7YMdEg==
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

> Gesendet: Samstag, 21. Januar 2023 um 14:35 Uhr
> Von: "Vladimir Oltean" <olteanv@gmail.com>
> It's hard for me to understand how applying only patch "tag_mtk only
> combine VLAN tag with MTK tag is user port is VLAN aware" can produce
> the results you describe... For packets sent to port lan0, nothing
> should have been changed by that patch, because dsa_port_is_vlan_filteri=
ng(dp)
> should return true.
>
> If you can confirm there isn't any mistake in the testing procedure,
> I'll take a look later today at the hardware documentation and try to
> figure out why the CPU port is configured the way it is.

booted an older kernel without your patches, and tried the vlan-aware brid=
ge the same way,
and it is not working there too. So not broken with your patches.

this is how i have created the bridge completely (to exclude a mistake in =
my setup):

BRIDGE=3Dlanbr0
ip link add name ${BRIDGE} type bridge vlan_filtering 1 vlan_default_pvid =
1
ip link set ${BRIDGE} up
ip link set lan0 master ${BRIDGE}
ip link set lan0 up

ip link add link lanbr0 name lanbr0.100 type vlan id 110
ip a a 192.168.110.5/24 dev lanbr0.100
ip link set lanbr0.100 up

btw. why is my vlan software-only and not pushed to hardware?

regards Frank