Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 21 Jan 2023 17:49:25 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Nuno =?UTF-8?B?U8Oh?= <noname.nuno@gmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Michael Hennerich <michael.hennerich@analog.com>
Subject: Re: [PATCH v1 1/2] iio: core: Replace
 iio_sysfs_match_string_with_gaps() by __sysfs_match_string()
Message-ID: <20230121174925.41beef31@jic23-huawei>
In-Reply-To: <93c5f822dd332c188e05da2d7e7eb1ac72cc6067.camel@gmail.com>
References: <20230118074828.66155-1-andriy.shevchenko@linux.intel.com>
        <5f9b713b-9c71-7da6-e674-b6ebd28dc5d5@metafoo.de>
        <Y8gVDs0UoiHqCRsM@smile.fi.intel.com>
        <64406c4f-c9da-b434-360b-1050ff685d2d@metafoo.de>
        <bb2e8b7b4ca894ed53d70bf04e2d52bed2553105.camel@gmail.com>
        <Y8koLwGVjyrDb66P@smile.fi.intel.com>
        <93c5f822dd332c188e05da2d7e7eb1ac72cc6067.camel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 19 Jan 2023 14:24:07 +0100
Nuno S=C3=A1 <noname.nuno@gmail.com> wrote:

> On Thu, 2023-01-19 at 13:23 +0200, Andy Shevchenko wrote:
> > On Thu, Jan 19, 2023 at 09:00:45AM +0100, Nuno S=C3=A1 wrote: =20
> > > On Wed, 2023-01-18 at 08:37 -0800, Lars-Peter Clausen wrote: =20
> > > > On 1/18/23 07:49, Andy Shevchenko wrote: =20
> > > > > On Wed, Jan 18, 2023 at 07:22:30AM -0800, Lars-Peter Clausen
> > > > > wrote: =20
> > > > > > On 1/17/23 23:48, Andy Shevchenko wrote: =20
> > > > > > > None of the current users is using gaps in the list of the
> > > > > > > items.
> > > > > > > No need to have a specific function for that, just replace
> > > > > > > it
> > > > > > > by
> > > > > > > library available __sysfs_match_string(). =20
> > > > > > Hm, I specifically remember adding this for a driver where
> > > > > > there
> > > > > > were gaps.
> > > > > > One of the DACs. But it might be that the driver itself never
> > > > > > made it
> > > > > > upstream. =20
> > > > > I have checked all modules that have struct iio_enum and/or
> > > > > ("or"
> > > > > probably may
> > > > > not happen) IIO_ENUM() in them.
> > > > >=20
> > > > > It might be that I missed something. =20
> > > > I checked too, I can't find it either. The driver probably never
> > > > made
> > > > it=20
> > > > upstream. =20
> > >=20
> > > Yeah, I also did a quick check and I could find it in one adc (most
> > > likely we have more downstream users of this) that did not make it
> > > upstream. Eventually, we want to have it upstream but the ABI using
> > > the
> > > gaps can arguably be dropped...
> > >=20
> > > Anyways, from my side I'm fine with this change. We can revert it
> > > if we
> > > ever have a real user for this. I'll just have to be careful when
> > > updating ADI tree (but that is our problem :)).

You could always upstream the problematic drivers :)

> >=20
> > We usually do not keep a dead code in the kernel, and handling gaps
> > is a dead code. =20
>=20
> Yes, I know... That is why I cannot really complain about this
> change :)

I joined in because I was really really sure we had a user of this
at somepoint. However, despite there having been a bunch of users
in the counter stuff before that spun out as a separate subsystem
looks like they were contiguous as well. Ah well the reasoning behind
this dance may remain lost to history :)

Series applied,

Jonathan

>=20
> - Nuno S=C3=A1
>=20