Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 21 Jan 2023 12:00:38 -0800
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Willy Tarreau <w@1wt.eu>
Cc:     linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
        linux-kselftest@vger.kernel.org,
        Ammar Faizi <ammarfaizi2@gnuweeb.org>
Subject: Re: [PATCH 0/2] selftests/nolibc: small simplification of test
 development phase
Message-ID: <20230121200038.GG2948950@paulmck-ThinkPad-P17-Gen-1>
Reply-To: paulmck@kernel.org
References: <20230121085320.11712-1-w@1wt.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230121085320.11712-1-w@1wt.eu>
Precedence: bulk

On Sat, Jan 21, 2023 at 09:53:18AM +0100, Willy Tarreau wrote:
> Hello Paul,
> 
> while developing and testing the recent changes for errno/environ/auxv, I
> found that I wasn't relying on the kernel that much and that I was mostly
> using qemu in userland only with my local kernel.
> 
> I figured that it was more convenient for this purpose than rebuilding an
> initramfs and kernel for a quick test, and decided to make this approach
> easier to use for everyone by adding a "run-user" target to the Makefile
> to do exactly this. E.g:
> 
> Native build:
>   $ time make -C tools/testing/selftests/nolibc run-user
>   ...
>   make: Entering directory '/g/public/linux/master/tools/testing/selftests/nolibc'
>     MKDIR   sysroot/x86/include
>   make[1]: Entering directory '/g/public/linux/master/tools/include/nolibc'
>   make[2]: Entering directory '/g/public/linux/master'
>   make[2]: Leaving directory '/g/public/linux/master'
>   make[2]: Entering directory '/g/public/linux/master'
>     INSTALL /g/public/linux/master/tools/testing/selftests/nolibc/sysroot/sysroot/include
>   make[2]: Leaving directory '/g/public/linux/master'
>   make[1]: Leaving directory '/g/public/linux/master/tools/include/nolibc'
>     CC      nolibc-test
>   18 chroot_root = -1 EPERM               [FAIL]
>   43 link_dir = -1 EACCES  != (-1 EPERM)  [FAIL]
>   See all results in /g/public/linux/master/tools/testing/selftests/nolibc/run.out
>   make: Leaving directory '/g/public/linux/master/tools/testing/selftests/nolibc'
> 
>   real    0m0.966s
>   user    0m0.731s
>   sys     0m0.164s
> 
> Cross build:
>   $ time make -C tools/testing/selftests/nolibc run-user ARCH=s390 CROSS_COMPILE=/f/tc/nolibc/gcc-11.3.0-nolibc/s390-linux/bin/s390-linux-
>   make: Entering directory '/g/public/linux/master/tools/testing/selftests/nolibc'
>     MKDIR   sysroot/s390/include
>   make[1]: Entering directory '/g/public/linux/master/tools/include/nolibc'
>   make[2]: Entering directory '/g/public/linux/master'
>   make[2]: Leaving directory '/g/public/linux/master'
>   make[2]: Entering directory '/g/public/linux/master'
>     INSTALL /g/public/linux/master/tools/testing/selftests/nolibc/sysroot/sysroot/include
>   make[2]: Leaving directory '/g/public/linux/master'
>   make[1]: Leaving directory '/g/public/linux/master/tools/include/nolibc'
>     CC      nolibc-test
>   18 chroot_root = -1 EPERM               [FAIL]
>   43 link_dir = -1 EACCES  != (-1 EPERM)  [FAIL]
>   See all results in /g/public/linux/master/tools/testing/selftests/nolibc/run.out
>   make: Leaving directory '/g/public/linux/master/tools/testing/selftests/nolibc'
> 
>   real    0m1.014s
>   user    0m0.732s
>   sys     0m0.183s
> 
> In addition, the "x86_64" value for ARCH= is now supported as I got caught
> too many times with it not working in this subdir while it's used for the
> rest of the kernel ("x86" is used instead as coming from subarch.include).
> Generally you don't type it as x86_64 probably is the native build for most
> users, but when you start to test toolchains it's a different thing.
> 
> There's no matter of urgency for these patches, they're just a bit of
> user-friendly stuff. As such, if you're fine with stacking them on top of
> what you already have for 6.3, that will be great, otherwise they can
> easily wait.
> 
> Thank you!
> Willy

Nice, thank you!

I have these placed on top of the -rcu "dev" branch initially for further
review and testing.  If things go well over the next week or so, I will
set it up for the upcoming merge window.

One dependency is of course qemu-x86_64, so in the meantime I will figure
out where I get that from.  ;-)

							Thanx, Paul

> [CCing Ammar who could benefit from this]
> 
> ---
> Willy Tarreau (2):
>   selftests/nolibc: support "x86_64" for arch name
>   selftests/nolibc: add a "run-user" target to test the program in user
>     land
> 
>  tools/testing/selftests/nolibc/Makefile | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> -- 
> 2.17.5
>