Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp4981026rwb; Sun, 22 Jan 2023 00:35:33 -0800 (PST) X-Google-Smtp-Source: AMrXdXuqIdt2u4Pnt5AxlkCXWrx2p1GGS4rpKgULjUPJwvGXOQSBKa25XUArLY4iiy3U6ucuo2cg X-Received: by 2002:a05:6a00:288d:b0:58b:853f:75ad with SMTP id ch13-20020a056a00288d00b0058b853f75admr21849183pfb.12.1674376533160; Sun, 22 Jan 2023 00:35:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674376533; cv=none; d=google.com; s=arc-20160816; b=jZmFW/mvTFGBUGW+DsKJ3ncT+yiPxoorYaCWtLblQiEWqS7p65IfwthIokFWEem0+Y BAOULSPIfdsSwn23IYPhA9+N//D4p1MGliCvcCK6GNxaDspXtKPtHwVzC1wjZQzaEwpp PB1kPd7uSVAwM9h6xE+iwxKXHFD/yOs7AUZBmNfphwfukFCKCKlSFmDFKw/i7OgxZANT UnlqnjlrsxG7/9lzWu+Q6etgBxmH6l8/7iMhTgLNJyUtV/2Pz36E5UwP6Rsn5VMpLa2f BSufUg8Uba2tvqKo2YNoW1308yXFTvYKThtMVh6ymPffzEeSf8p0ceAY5ufq1AeycvsG tyOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=1uRC+XrhxcUM/tSM9DcF1OpmRXdWBDLdUzrm16HiaX8=; b=EI1zE0A06gFcypfcChFSONrvJCbbLYUE3zr0vtMfqeRl0lytUL5QeKnxm5ggOURbu1 bGjBKB0xAi8Htv5hEjd7d3q9h5PXlbu7re0yTIE8XcLpJN1annsq+H6d1BM8HXMke9o+ MjFtjwP8oAJ2Yd96fLxI/A2+V4SpqG3Tz/cHCE+LgYgDODSDSMC0FsQNEkeF4vdQ3wPv jaOx7NnvY9PdFwKkGlA4n6dtfOadx3lw9ChLqujdlZeOGBu9UKpILO2s4FiC0h3hjEgJ fam8muZW175vUBiEaUz0wm6ESK2Tpj6nSYlRJpjgHz6tZM+QpzIs3uEGmNIslrxQXtKs ra+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z6-20020a626506000000b00589c467f33fsi19818907pfb.55.2023.01.22.00.35.24; Sun, 22 Jan 2023 00:35:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229750AbjAVH5Q (ORCPT + 52 others); Sun, 22 Jan 2023 02:57:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229480AbjAVH5P (ORCPT ); Sun, 22 Jan 2023 02:57:15 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEECE1CADD; Sat, 21 Jan 2023 23:57:14 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 1370C68AA6; Sun, 22 Jan 2023 08:57:10 +0100 (CET) Date: Sun, 22 Jan 2023 08:57:10 +0100 From: Christoph Hellwig To: Ondrej Zary Cc: Damien Le Moal , Christoph Hellwig , Sergey Shtylyov , Jens Axboe , Tim Waugh , linux-block@vger.kernel.org, linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] pata_parport: add driver (PARIDE replacement) Message-ID: <20230122075710.GA4046@lst.de> References: <20230121225314.32459-1-linux@zary.sk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230121225314.32459-1-linux@zary.sk> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I suspect a comment in the Kconfig for the old PARIDE code to point to this and maybe even a runtime warning when using the old paride code would be great. But except for that the code looks awesome, so let's get it merged ASAP: Reviewed-by: Christoph Hellwig